From 8a84b2c97fd64bf45ace009e43e867ea35bdb0d0 Mon Sep 17 00:00:00 2001 From: Jatin K Malik Date: Wed, 28 Jan 2026 19:54:11 -0800 Subject: [PATCH] fix: remove --system-site-packages to avoid Python 3.12+ conflicts (#79) Fixes #66 The --system-site-packages flag causes the virtual environment to inherit system packages, which can include versions incompatible with newer Python versions. On Arch/EndeavourOS with Python 3.12, an old coverage package from the system causes Whisper to fail with: module 'coverage.types' has no attribute 'Tracer' By creating an isolated virtual environment, all dependencies are installed at compatible versions within the venv, avoiding such conflicts. --- install.sh | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/install.sh b/install.sh index 5ec3d99..88b29bc 100755 --- a/install.sh +++ b/install.sh @@ -568,13 +568,11 @@ setup_virtual_environment() { fi # Create virtual environment - python3 -m venv "$VENV_DIR" --system-site-packages || { - print_error "Failed to create virtual environment" - print_info "Trying without --system-site-packages..." - python3 -m venv "$VENV_DIR" || { - print_error "Failed to create virtual environment. Please check your Python installation." - exit 1 - } + # Note: We don't use --system-site-packages to avoid conflicts with system packages + # that may be incompatible with Python 3.12+ (e.g., old coverage versions) + python3 -m venv "$VENV_DIR" || { + print_error "Failed to create virtual environment. Please check your Python installation." + exit 1 } # Activate virtual environment