From 9eba80b53da7ac9f351768004824ac3e0c833a01 Mon Sep 17 00:00:00 2001
From: "devin-ai-integration[bot]"
 <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Date: Wed, 7 Oct 2026 17:45:06 -0700
Subject: [PATCH] fix(packaging): declare python3-pysocks in deb and rpm deps
 (#920)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* fix(packaging): declare python3-pysocks in deb and rpm deps

#909 added PySocks as a runtime dependency for SOCKS5 proxy support but
only covered the AUR PKGBUILD — the nfpm deb and rpm packages never
declared python3-pysocks, so
test_every_project_dependency_is_covered_in_both_formats fails on main
and on every PR's merge check. Add it to both depends lists and the
test's DEB/RPM_PROVIDES maps.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* fix(packaging): deb name is python3-socks

Debian/Ubuntu package PySocks as python3-socks (1.7.1+dfsg); the rpm
name stays python3-pysocks — Fedora's python3-socks is a different
library (python-socks). Verified in debian:12, ubuntu:24.04 and
fedora:42 containers.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

---------

Co-authored-by: Jatin K Malik <jk.malik@yahoo.com>
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
---
 packaging/native/nfpm.yaml     | 2 ++
 tests/test_native_packaging.py | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/packaging/native/nfpm.yaml b/packaging/native/nfpm.yaml
index 129ea74..6f53cdd 100644
--- a/packaging/native/nfpm.yaml
+++ b/packaging/native/nfpm.yaml
@@ -66,6 +66,7 @@ overrides:
       - python3-psutil
       - python3-evdev
       - python3-pyaudio
+      - python3-socks
       - python3-xlib
     recommends:
       # Host tools the injectors fall back through; install.d documents the
@@ -95,6 +96,7 @@ overrides:
       - python3-psutil
       - python3-evdev
       - python3-pyaudio
+      - python3-pysocks
       - python3-xlib
     recommends:
       - xdotool
diff --git a/tests/test_native_packaging.py b/tests/test_native_packaging.py
index a339399..c73d458 100644
--- a/tests/test_native_packaging.py
+++ b/tests/test_native_packaging.py
@@ -39,6 +39,7 @@ DEB_PROVIDES = {
     "psutil": "python3-psutil",
     "evdev": "python3-evdev",
     "pyaudio": "python3-pyaudio",
+    "pysocks": "python3-socks",
     "xlib": "python3-xlib",
     "pygobject": "python3-gi",
 }
@@ -54,6 +55,7 @@ RPM_PROVIDES = {
     "psutil": "python3-psutil",
     "evdev": "python3-evdev",
     "pyaudio": "python3-pyaudio",
+    "pysocks": "python3-pysocks",
     "xlib": "python3-xlib",
     "pygobject": "python3-gobject",
 }