test(coverage): improve test coverage from 57% to 80%+ (#327)
* test(coverage): improve test coverage from 57% to 80%+ Add 30 new test files with 861 additional test cases to improve overall test coverage from 57% to 80%+ (statement coverage). Key modules covered: - recognition_manager.py: 43% → 69% (audio device detection, transcription, model download, engine initialization, buffer management) - text_injector.py: improved coverage for X11/Wayland text injection, environment detection, clipboard fallback, shortcut injection - ibus_engine.py: 22% → 73% (engine lifecycle, text injection, socket server) - evdev_backend.py: 11% → 78% (device detection, key event handling) - pynput_backend.py: 43% → 76% (start/stop, key handling, callbacks) - keyboard_backends/__init__.py: 54% → improved (backend creation, env detection) - whispercpp_model_info.py: 32% → improved (GPU detection, model recommendations) - about_dialog.py, first_run_dialog.py, main.py, single_instance.py, common_types.py, config_manager.py, autostart_manager.py: various improvements All 1433 tests pass with proper test isolation to prevent mock pollution between test modules. * test(quality): audit and fix test quality issues Code review audit identified and fixed the following issues: - Remove bare try/except blocks that swallow all errors (7 tests fixed in recognition_manager_deep, replaced with proper assertions or deleted) - Delete source code inspection tests that read .py files as strings instead of testing behavior (deleted test_about_dialog_coverage.py and test_first_run_dialog_coverage.py entirely - ~35 useless tests removed) - Add meaningful assertions replacing weak assertIsNotNone/assertIsInstance checks (common_types_coverage, ibus_engine_coverage, keyboard_backends_extra) - Fix tests that mock the system under test instead of its dependencies (text_injector_extra now mocks subprocess.run instead of injection methods) - Add missing assertions to tests with no verification (ibus_engine focus_out, log window info, copy to clipboard) - Verify download tests check requests.get was called with correct URLs (coverage_boost download tests) - Fix pytest warning by renaming test_audio_input import to avoid pytest collecting it as a test function All 1356 tests pass with 0 failures and 0 warnings. Statement coverage: 80.3% (3257/4054 lines covered). * style(tests): fix black formatting and isort import ordering Auto-format all new test files with black and isort to pass CI lint checks. * fix(tests): resolve CI hangs and rename test files for clarity - Fix CI hangs by properly mocking gi/GTK/IBus in all test files - Fix sys.modules pollution in recognition manager tests by using tmp_path - Add pytest-timeout to prevent future hangs - Rename 28 test files to use descriptive, consistent names mapping to source modules * fix(tests): resolve Python 3.13 CI failures - Fix _load_stdlib_module() in test_recognition_manager_downloads.py to handle stdlib modules that are packages (directories with __init__.py) rather than single .py files. In Python 3.13, zipfile became a package, causing FileNotFoundError during test collection (exit code 2). - Fix invalid escape sequence '$' in test_cross_distro_compatibility.py by using a raw string. Python 3.13 reports this as SyntaxWarning and Python 3.14 will make it a SyntaxError. * fix(tests): use direct import for zipfile instead of _load_stdlib_module The _load_stdlib_module approach fails on Python 3.13 where zipfile is a package (zipfile/__init__.py). Loading it via spec_from_file_location with a custom name breaks relative imports inside the package (e.g. 'from ._path import ...' resolves to '_stdlib_zipfile._path' which doesn't exist). Simply import zipfile at module level before any test mocks can pollute sys.modules — this is safe because the module-level code runs during test collection, before any test fixtures or patches are applied. * fix(tests): mock gi/GTK in conftest to prevent CI hangs On CI, real PyGObject is installed and module-level imports in vocalinux source files (ibus_engine, tray_indicator, settings_dialog, etc.) trigger GTK initialization or IBus daemon connections that hang indefinitely in headless environments. pytest-timeout's signal-based timeout cannot interrupt these C-level blocking calls. Fix by mocking gi and gi.repository in conftest.py (which runs before any test module is collected), ensuring all test files are protected regardless of whether they remember to mock individually. Also add timeout-minutes: 10 to the CI test job as a safety net so that any remaining hangs fail fast instead of running indefinitely. * fix(tests): unconditionally mock gi in conftest for CI The previous 'if gi not in sys.modules' guard was ineffective on CI because PyGObject is installed via pip, so the real gi module is already loaded. This caused GTK initialization and IBus daemon connections that hang indefinitely in headless CI environments. Now unconditionally replace gi and gi.repository with mocks during test collection, regardless of whether the real package is installed. * fix(tests): reduce timeout to 10s and use thread-based timeout Use timeout_method=thread instead of signal (default) so that pytest-timeout can interrupt C-level blocking calls (GTK operations, socket accepts, subprocess waits) that the signal-based method cannot handle. Also reduce per-test timeout from 30s to 10s since no legitimate unit test should take longer, and hanging tests were consuming the entire CI job timeout budget. * fix(tests): set global socket timeout to prevent blocking on CI Tests in test_ibus_engine.py create real Unix sockets with daemon threads that block on socket.accept(). When tests fail or timeout, these threads remain blocked indefinitely, preventing pytest from completing. The thread-based timeout catches the hang but cannot terminate the blocking accept() call. Set socket.setdefaulttimeout(5) in conftest.py so all socket operations (accept, connect, recv) will raise socket.timeout after 5 seconds instead of blocking forever. * fix(tests): add cleanup fixture for IBus socket server threads Add autouse fixture that stops any leftover VocalinuxEngine socket server threads after each test. Tests that trigger _start_socket_server() spawn daemon threads blocking on socket.accept() that persist after the test completes, eventually causing pytest-timeout to kill the process. The cleanup fixture sets _server_running=False and closes the server socket, which unblocks the accept() call and allows the daemon thread to terminate. * fix(tests): reduce socket timeout to 0.1s to avoid slowing tests The 5-second socket timeout caused socket operations in daemon threads to block for 5 seconds per iteration before timing out, significantly slowing the test suite on CI. Reduce to 0.1s so blocking socket calls fail fast without noticeably impacting test execution time. * fix(tests): use 2s socket timeout and increase CI timeout to 15min The 0.1s socket timeout was too aggressive and caused legitimate test socket operations to fail. Use 2s which is long enough for test sockets to work but short enough to unblock daemon threads. Increase CI job timeout to 15 minutes to accommodate the socket timeout overhead from daemon threads that retry every 2 seconds. * fix(tests): block known-blocking daemon threads to prevent CI hangs Instead of using socket timeouts (which either break tests or are too slow), prevent specific known-blocking daemon threads from starting: - ibus_engine.server_thread: blocks on socket.accept() - evdev_backend._monitor_devices: blocks on select.select() These threads are identified by their target function name and skipped during Thread.start(). The thread is marked as started/stopped so join() calls in cleanup code don't raise RuntimeError. Test-created daemon threads (e.g. mock socket servers) are unaffected since they use different target function names. * fix(tests): patch Thread.join for Python 3.13 compatibility Python 3.13 changed threading internals — join() now uses _handle.join() which raises 'thread not started' for threads that were never actually started. Instead of trying to fake internal state, patch join() to be a no-op for threads that were skipped by our _safe_thread_start guard. This fixes the 2 remaining test_evdev_backend_ext failures on Python 3.13.
This commit is contained in:
Jatin K Malik
@@ -0,0 +1,653 @@
|
||||
"""
|
||||
Comprehensive test coverage for IBus engine module.
|
||||
|
||||
This test file provides extensive coverage for the IBus text injection engine,
|
||||
testing initialization, signal handlers, socket communication, and text injection.
|
||||
"""
|
||||
|
||||
import os
|
||||
import socket
|
||||
import struct
|
||||
import subprocess
|
||||
import sys
|
||||
import threading
|
||||
import unittest
|
||||
from pathlib import Path
|
||||
from unittest.mock import MagicMock, Mock, call, patch
|
||||
|
||||
# Add src to path for imports
|
||||
sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), "..", "src")))
|
||||
|
||||
# Mock GI imports before importing the module (follow test_ibus_engine.py pattern)
|
||||
mock_gi = MagicMock()
|
||||
mock_ibus = MagicMock()
|
||||
mock_glib = MagicMock()
|
||||
mock_gobject = MagicMock()
|
||||
|
||||
# Set up IBus mock - Engine should be the actual MagicMock class, not an instance
|
||||
mock_ibus.Engine = MagicMock
|
||||
mock_ibus.Bus = MagicMock
|
||||
mock_ibus.Factory = MagicMock
|
||||
mock_ibus.Factory.new = MagicMock(return_value=MagicMock())
|
||||
mock_ibus.Text = MagicMock()
|
||||
mock_ibus.Text.new_from_string = MagicMock(return_value=MagicMock())
|
||||
|
||||
# Mock GLib.MainLoop
|
||||
mock_glib.MainLoop = MagicMock
|
||||
|
||||
# Mock socket.SO_PEERCRED (Linux-specific constant)
|
||||
if not hasattr(socket, "SO_PEERCRED"):
|
||||
socket.SO_PEERCRED = 17
|
||||
|
||||
sys.modules["gi"] = mock_gi
|
||||
sys.modules["gi.repository"] = MagicMock()
|
||||
sys.modules["gi.repository"].IBus = mock_ibus
|
||||
sys.modules["gi.repository"].GLib = mock_glib
|
||||
sys.modules["gi.repository"].GObject = mock_gobject
|
||||
|
||||
|
||||
class TestIBusEngineModuleFunctions(unittest.TestCase):
|
||||
"""Test module-level functions in ibus_engine.py."""
|
||||
|
||||
def setUp(self):
|
||||
"""Set up test fixtures."""
|
||||
# No patching needed - module mocks are already set up at module level
|
||||
pass
|
||||
|
||||
def tearDown(self):
|
||||
"""Clean up after tests."""
|
||||
# Module cache cleanup not needed since mocks are global
|
||||
pass
|
||||
|
||||
def test_ibus_setup_error_exception(self):
|
||||
"""Test that IBusSetupError is a RuntimeError."""
|
||||
from vocalinux.text_injection.ibus_engine import IBusSetupError
|
||||
|
||||
error = IBusSetupError("Test error")
|
||||
self.assertIsInstance(error, RuntimeError)
|
||||
self.assertEqual(str(error), "Test error")
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_is_ibus_daemon_running_success(self, mock_run):
|
||||
"""Test ibus daemon detection when daemon is running."""
|
||||
mock_run.return_value = MagicMock(returncode=0)
|
||||
from vocalinux.text_injection.ibus_engine import is_ibus_daemon_running
|
||||
|
||||
result = is_ibus_daemon_running()
|
||||
self.assertTrue(result)
|
||||
mock_run.assert_called_once_with(
|
||||
["pgrep", "-x", "ibus-daemon"],
|
||||
capture_output=True,
|
||||
timeout=2,
|
||||
)
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_is_ibus_daemon_running_not_running(self, mock_run):
|
||||
"""Test ibus daemon detection when daemon is not running."""
|
||||
mock_run.return_value = MagicMock(returncode=1)
|
||||
from vocalinux.text_injection.ibus_engine import is_ibus_daemon_running
|
||||
|
||||
result = is_ibus_daemon_running()
|
||||
self.assertFalse(result)
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_is_ibus_daemon_running_command_not_found(self, mock_run):
|
||||
"""Test ibus daemon detection when pgrep is not found."""
|
||||
mock_run.side_effect = FileNotFoundError()
|
||||
from vocalinux.text_injection.ibus_engine import is_ibus_daemon_running
|
||||
|
||||
result = is_ibus_daemon_running()
|
||||
self.assertFalse(result)
|
||||
|
||||
def test_is_ibus_active_input_method_gtk_im_module(self):
|
||||
"""Test IBus detection via GTK_IM_MODULE environment variable."""
|
||||
with patch.dict("os.environ", {"GTK_IM_MODULE": "ibus"}):
|
||||
from vocalinux.text_injection.ibus_engine import is_ibus_active_input_method
|
||||
|
||||
result = is_ibus_active_input_method()
|
||||
self.assertTrue(result)
|
||||
|
||||
def test_is_ibus_active_input_method_qt_im_module(self):
|
||||
"""Test IBus detection via QT_IM_MODULE environment variable."""
|
||||
with patch.dict("os.environ", {"QT_IM_MODULE": "ibus", "GTK_IM_MODULE": ""}):
|
||||
from vocalinux.text_injection.ibus_engine import is_ibus_active_input_method
|
||||
|
||||
result = is_ibus_active_input_method()
|
||||
self.assertTrue(result)
|
||||
|
||||
def test_is_ibus_active_input_method_xmodifiers(self):
|
||||
"""Test IBus detection via XMODIFIERS environment variable."""
|
||||
with patch.dict(
|
||||
"os.environ",
|
||||
{"XMODIFIERS": "@im=ibus", "GTK_IM_MODULE": "", "QT_IM_MODULE": ""},
|
||||
):
|
||||
from vocalinux.text_injection.ibus_engine import is_ibus_active_input_method
|
||||
|
||||
result = is_ibus_active_input_method()
|
||||
self.assertTrue(result)
|
||||
|
||||
def test_is_ibus_active_input_method_not_active(self):
|
||||
"""Test when IBus is not the active input method."""
|
||||
with patch.dict(
|
||||
"os.environ",
|
||||
{"GTK_IM_MODULE": "fcitx", "QT_IM_MODULE": "", "XMODIFIERS": ""},
|
||||
clear=True,
|
||||
):
|
||||
from vocalinux.text_injection.ibus_engine import is_ibus_active_input_method
|
||||
|
||||
result = is_ibus_active_input_method()
|
||||
self.assertFalse(result)
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_is_engine_registered_success(self, mock_run):
|
||||
"""Test engine registration detection."""
|
||||
mock_run.return_value = MagicMock(returncode=0, stdout="vocalinux other-engine")
|
||||
from vocalinux.text_injection.ibus_engine import is_engine_registered
|
||||
|
||||
result = is_engine_registered()
|
||||
self.assertTrue(result)
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_is_engine_registered_not_found(self, mock_run):
|
||||
"""Test when engine is not registered."""
|
||||
mock_run.return_value = MagicMock(returncode=0, stdout="other-engine")
|
||||
from vocalinux.text_injection.ibus_engine import is_engine_registered
|
||||
|
||||
result = is_engine_registered()
|
||||
self.assertFalse(result)
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_is_engine_active_success(self, mock_run):
|
||||
"""Test when engine is active."""
|
||||
mock_run.return_value = MagicMock(returncode=0, stdout="vocalinux")
|
||||
from vocalinux.text_injection.ibus_engine import is_engine_active
|
||||
|
||||
result = is_engine_active()
|
||||
self.assertTrue(result)
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_is_engine_active_not_active(self, mock_run):
|
||||
"""Test when engine is not active."""
|
||||
mock_run.return_value = MagicMock(returncode=0, stdout="other-engine")
|
||||
from vocalinux.text_injection.ibus_engine import is_engine_active
|
||||
|
||||
result = is_engine_active()
|
||||
self.assertFalse(result)
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_get_current_engine_success(self, mock_run):
|
||||
"""Test getting the current engine."""
|
||||
mock_run.return_value = MagicMock(returncode=0, stdout="current-engine\n")
|
||||
from vocalinux.text_injection.ibus_engine import get_current_engine
|
||||
|
||||
result = get_current_engine()
|
||||
self.assertEqual(result, "current-engine")
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_get_current_engine_failure(self, mock_run):
|
||||
"""Test when unable to get current engine."""
|
||||
mock_run.return_value = MagicMock(returncode=1)
|
||||
from vocalinux.text_injection.ibus_engine import get_current_engine
|
||||
|
||||
result = get_current_engine()
|
||||
self.assertIsNone(result)
|
||||
|
||||
@patch("subprocess.run")
|
||||
@patch("vocalinux.text_injection.ibus_engine.get_current_engine")
|
||||
def test_switch_engine_success(self, mock_get_current, mock_run):
|
||||
"""Test switching engine successfully."""
|
||||
mock_get_current.return_value = "vocalinux"
|
||||
from vocalinux.text_injection.ibus_engine import switch_engine
|
||||
|
||||
result = switch_engine("vocalinux")
|
||||
self.assertTrue(result)
|
||||
|
||||
@patch("subprocess.run")
|
||||
@patch("vocalinux.text_injection.ibus_engine.get_current_engine")
|
||||
def test_switch_engine_failure(self, mock_get_current, mock_run):
|
||||
"""Test when engine switch fails."""
|
||||
mock_get_current.return_value = "other-engine"
|
||||
from vocalinux.text_injection.ibus_engine import switch_engine
|
||||
|
||||
result = switch_engine("vocalinux")
|
||||
self.assertFalse(result)
|
||||
|
||||
@patch("vocalinux.text_injection.ibus_engine.PID_FILE")
|
||||
def test_is_engine_process_running_no_pid_file(self, mock_pid_file):
|
||||
"""Test when PID file doesn't exist."""
|
||||
mock_pid_file.exists.return_value = False
|
||||
from vocalinux.text_injection.ibus_engine import is_engine_process_running
|
||||
|
||||
result = is_engine_process_running()
|
||||
self.assertFalse(result)
|
||||
|
||||
@patch("vocalinux.text_injection.ibus_engine.PID_FILE")
|
||||
@patch("os.kill")
|
||||
def test_is_engine_process_running_process_exists(self, mock_kill, mock_pid_file):
|
||||
"""Test when engine process is running."""
|
||||
mock_pid_file.exists.return_value = True
|
||||
mock_pid_file.read_text.return_value = "1234"
|
||||
mock_kill.return_value = None # No exception means process exists
|
||||
|
||||
with patch("pathlib.Path.exists", return_value=False): # /proc check fails
|
||||
from vocalinux.text_injection.ibus_engine import is_engine_process_running
|
||||
|
||||
result = is_engine_process_running()
|
||||
self.assertTrue(result)
|
||||
|
||||
@patch("vocalinux.text_injection.ibus_engine.PID_FILE")
|
||||
@patch("os.kill")
|
||||
def test_is_engine_process_running_process_not_exists(self, mock_kill, mock_pid_file):
|
||||
"""Test when engine process doesn't exist."""
|
||||
mock_pid_file.exists.return_value = True
|
||||
mock_pid_file.read_text.return_value = "1234"
|
||||
mock_kill.side_effect = OSError() # Process doesn't exist
|
||||
|
||||
from vocalinux.text_injection.ibus_engine import is_engine_process_running
|
||||
|
||||
result = is_engine_process_running()
|
||||
self.assertFalse(result)
|
||||
|
||||
@patch("subprocess.run")
|
||||
@patch("vocalinux.text_injection.ibus_engine.start_engine_process")
|
||||
def test_start_ibus_daemon_already_running(self, mock_start_process, mock_run):
|
||||
"""Test when ibus-daemon is already running."""
|
||||
with patch(
|
||||
"vocalinux.text_injection.ibus_engine.is_ibus_daemon_running", return_value=True
|
||||
):
|
||||
from vocalinux.text_injection.ibus_engine import start_ibus_daemon
|
||||
|
||||
result = start_ibus_daemon()
|
||||
self.assertTrue(result)
|
||||
mock_run.assert_not_called()
|
||||
|
||||
@patch("vocalinux.text_injection.ibus_engine.is_ibus_available", return_value=False)
|
||||
def test_start_ibus_daemon_not_available(self, mock_available):
|
||||
"""Test when IBus is not available."""
|
||||
with patch(
|
||||
"vocalinux.text_injection.ibus_engine.is_ibus_daemon_running", return_value=False
|
||||
):
|
||||
from vocalinux.text_injection.ibus_engine import start_ibus_daemon
|
||||
|
||||
result = start_ibus_daemon()
|
||||
self.assertFalse(result)
|
||||
|
||||
def test_ensure_ibus_dir(self):
|
||||
"""Test directory creation and permissions."""
|
||||
with patch("pathlib.Path.mkdir") as mock_mkdir, patch("pathlib.Path.chmod") as mock_chmod:
|
||||
from vocalinux.text_injection.ibus_engine import ensure_ibus_dir
|
||||
|
||||
ensure_ibus_dir()
|
||||
mock_mkdir.assert_called_once_with(parents=True, exist_ok=True)
|
||||
mock_chmod.assert_called_once_with(0o700)
|
||||
|
||||
def test_verify_peer_credentials_same_user(self):
|
||||
"""Test peer credential verification for same user."""
|
||||
mock_socket = MagicMock()
|
||||
mock_uid = os.getuid()
|
||||
cred_data = struct.pack("iII", 1234, mock_uid, 1000)
|
||||
mock_socket.getsockopt.return_value = cred_data
|
||||
|
||||
from vocalinux.text_injection.ibus_engine import verify_peer_credentials
|
||||
|
||||
result = verify_peer_credentials(mock_socket)
|
||||
self.assertTrue(result)
|
||||
|
||||
def test_verify_peer_credentials_different_user(self):
|
||||
"""Test peer credential verification rejects different user."""
|
||||
mock_socket = MagicMock()
|
||||
mock_uid = os.getuid()
|
||||
other_uid = mock_uid + 1000 # Different user
|
||||
cred_data = struct.pack("iII", 1234, other_uid, 1000)
|
||||
mock_socket.getsockopt.return_value = cred_data
|
||||
|
||||
from vocalinux.text_injection.ibus_engine import verify_peer_credentials
|
||||
|
||||
result = verify_peer_credentials(mock_socket)
|
||||
self.assertFalse(result)
|
||||
|
||||
def test_verify_peer_credentials_error(self):
|
||||
"""Test peer credential verification error handling."""
|
||||
mock_socket = MagicMock()
|
||||
mock_socket.getsockopt.side_effect = OSError("Permission denied")
|
||||
|
||||
from vocalinux.text_injection.ibus_engine import verify_peer_credentials
|
||||
|
||||
result = verify_peer_credentials(mock_socket)
|
||||
self.assertFalse(result)
|
||||
|
||||
|
||||
class TestVocalinuxEngine(unittest.TestCase):
|
||||
"""Test VocalinuxEngine class."""
|
||||
|
||||
def setUp(self):
|
||||
"""Set up test fixtures - force module reload to get fresh mocks."""
|
||||
import importlib
|
||||
|
||||
# Ensure our mocks are in sys.modules
|
||||
sys.modules["gi"] = mock_gi
|
||||
sys.modules["gi.repository"] = MagicMock()
|
||||
sys.modules["gi.repository"].IBus = mock_ibus
|
||||
sys.modules["gi.repository"].GLib = mock_glib
|
||||
sys.modules["gi.repository"].GObject = mock_gobject
|
||||
# Force reload the module so it picks up our mocks
|
||||
if "vocalinux.text_injection.ibus_engine" in sys.modules:
|
||||
importlib.reload(sys.modules["vocalinux.text_injection.ibus_engine"])
|
||||
|
||||
def tearDown(self):
|
||||
"""Clean up after tests."""
|
||||
# Reset class-level state
|
||||
from vocalinux.text_injection.ibus_engine import VocalinuxEngine
|
||||
|
||||
VocalinuxEngine._active_instance = None
|
||||
VocalinuxEngine._socket_server = None
|
||||
VocalinuxEngine._server_socket = None
|
||||
VocalinuxEngine._server_running = False
|
||||
|
||||
def test_vocalinux_engine_init(self):
|
||||
"""Test VocalinuxEngine initialization."""
|
||||
from vocalinux.text_injection.ibus_engine import VocalinuxEngine
|
||||
|
||||
engine = VocalinuxEngine()
|
||||
self.assertIsNotNone(engine)
|
||||
# Verify the engine is properly initialized with expected attributes
|
||||
self.assertIsInstance(engine, VocalinuxEngine)
|
||||
# Verify class-level attributes exist
|
||||
self.assertIsNone(VocalinuxEngine._active_instance)
|
||||
self.assertIsNone(VocalinuxEngine._socket_server)
|
||||
self.assertIsNone(VocalinuxEngine._server_socket)
|
||||
self.assertFalse(VocalinuxEngine._server_running)
|
||||
|
||||
def test_vocalinux_engine_do_enable(self):
|
||||
"""Test engine enable signal handler."""
|
||||
from vocalinux.text_injection.ibus_engine import VocalinuxEngine
|
||||
|
||||
engine = VocalinuxEngine()
|
||||
with patch.object(engine, "_start_socket_server"):
|
||||
engine.do_enable()
|
||||
# Verify active instance is set
|
||||
self.assertEqual(VocalinuxEngine._active_instance, engine)
|
||||
|
||||
def test_vocalinux_engine_do_disable(self):
|
||||
"""Test engine disable signal handler."""
|
||||
from vocalinux.text_injection.ibus_engine import VocalinuxEngine
|
||||
|
||||
engine = VocalinuxEngine()
|
||||
engine.do_enable()
|
||||
engine.do_disable()
|
||||
# Instance should still be active (not cleared on disable)
|
||||
self.assertEqual(VocalinuxEngine._active_instance, engine)
|
||||
|
||||
def test_vocalinux_engine_do_focus_in(self):
|
||||
"""Test engine focus in signal handler."""
|
||||
from vocalinux.text_injection.ibus_engine import VocalinuxEngine
|
||||
|
||||
engine = VocalinuxEngine()
|
||||
engine.do_focus_in()
|
||||
self.assertEqual(VocalinuxEngine._active_instance, engine)
|
||||
|
||||
def test_vocalinux_engine_do_focus_out(self):
|
||||
"""Test engine focus out signal handler."""
|
||||
from vocalinux.text_injection.ibus_engine import VocalinuxEngine
|
||||
|
||||
engine = VocalinuxEngine()
|
||||
VocalinuxEngine._active_instance = engine
|
||||
engine.do_focus_out()
|
||||
# Focus out should not clear the active instance
|
||||
self.assertEqual(VocalinuxEngine._active_instance, engine)
|
||||
|
||||
def test_vocalinux_engine_do_process_key_event(self):
|
||||
"""Test engine key event processing."""
|
||||
from vocalinux.text_injection.ibus_engine import VocalinuxEngine
|
||||
|
||||
engine = VocalinuxEngine()
|
||||
result = engine.do_process_key_event(65, 38, 0)
|
||||
# Should return False to pass through all keys
|
||||
self.assertFalse(result)
|
||||
|
||||
def test_vocalinux_engine_inject_text_empty(self):
|
||||
"""Test text injection with empty text."""
|
||||
from vocalinux.text_injection.ibus_engine import VocalinuxEngine
|
||||
|
||||
engine = VocalinuxEngine()
|
||||
result = engine.inject_text("")
|
||||
# Empty text should return True (no-op)
|
||||
self.assertTrue(result)
|
||||
|
||||
def test_vocalinux_engine_inject_text_success(self):
|
||||
"""Test successful text injection."""
|
||||
from vocalinux.text_injection.ibus_engine import VocalinuxEngine
|
||||
|
||||
engine = VocalinuxEngine()
|
||||
mock_text = MagicMock()
|
||||
mock_ibus.Text.new_from_string.return_value = mock_text
|
||||
|
||||
# Mock the commit_text method
|
||||
engine.commit_text = MagicMock()
|
||||
result = engine.inject_text("Hello World")
|
||||
self.assertTrue(result)
|
||||
engine.commit_text.assert_called_once()
|
||||
|
||||
def test_vocalinux_engine_inject_text_failure(self):
|
||||
"""Test text injection error handling."""
|
||||
from vocalinux.text_injection.ibus_engine import VocalinuxEngine
|
||||
|
||||
engine = VocalinuxEngine()
|
||||
# Mock commit_text to raise an exception
|
||||
engine.commit_text = MagicMock(side_effect=Exception("Test error"))
|
||||
result = engine.inject_text("Hello World")
|
||||
self.assertFalse(result)
|
||||
|
||||
@patch("vocalinux.text_injection.ibus_engine.SOCKET_PATH")
|
||||
@patch("vocalinux.text_injection.ibus_engine.ensure_ibus_dir")
|
||||
@patch("socket.socket")
|
||||
def test_start_socket_server(self, mock_socket_cls, mock_ensure_dir, mock_socket_path):
|
||||
"""Test socket server startup."""
|
||||
mock_socket_path.exists.return_value = False
|
||||
mock_socket = MagicMock()
|
||||
mock_socket_cls.return_value = mock_socket
|
||||
|
||||
from vocalinux.text_injection.ibus_engine import VocalinuxEngine
|
||||
|
||||
# Start socket server in background
|
||||
VocalinuxEngine._server_running = False
|
||||
with patch("threading.Thread"):
|
||||
VocalinuxEngine._start_socket_server()
|
||||
self.assertTrue(VocalinuxEngine._server_running)
|
||||
|
||||
@patch("vocalinux.text_injection.ibus_engine.SOCKET_PATH")
|
||||
def test_stop_socket_server(self, mock_socket_path):
|
||||
"""Test socket server shutdown."""
|
||||
from vocalinux.text_injection.ibus_engine import VocalinuxEngine
|
||||
|
||||
mock_socket = MagicMock()
|
||||
VocalinuxEngine._server_socket = mock_socket
|
||||
VocalinuxEngine._server_running = True
|
||||
mock_socket_path.exists.return_value = True
|
||||
|
||||
VocalinuxEngine.stop_socket_server()
|
||||
self.assertFalse(VocalinuxEngine._server_running)
|
||||
self.assertIsNone(VocalinuxEngine._server_socket)
|
||||
|
||||
|
||||
class TestIBusTextInjector(unittest.TestCase):
|
||||
"""Test IBusTextInjector class."""
|
||||
|
||||
def setUp(self):
|
||||
"""Set up test fixtures."""
|
||||
# Module mocks are already set up at module level
|
||||
pass
|
||||
|
||||
def tearDown(self):
|
||||
"""Clean up after tests."""
|
||||
# No cleanup needed
|
||||
pass
|
||||
|
||||
@patch("vocalinux.text_injection.ibus_engine.ensure_ibus_dir")
|
||||
def test_ibus_text_injector_init_no_auto_activate(self, mock_ensure_dir):
|
||||
"""Test IBusTextInjector initialization without auto-activation."""
|
||||
from vocalinux.text_injection.ibus_engine import IBusTextInjector
|
||||
|
||||
injector = IBusTextInjector(auto_activate=False)
|
||||
self.assertIsNotNone(injector)
|
||||
# Verify auto_activate=False means _previous_engine is not set
|
||||
self.assertFalse(
|
||||
hasattr(injector, "_previous_engine") and injector._previous_engine is not None
|
||||
)
|
||||
# Verify the auto_activate flag is properly False (no setup was called)
|
||||
self.assertIsNone(injector._previous_engine)
|
||||
|
||||
@patch("vocalinux.text_injection.ibus_engine.ensure_ibus_dir")
|
||||
@patch("vocalinux.text_injection.ibus_engine.is_engine_registered", return_value=True)
|
||||
@patch("vocalinux.text_injection.ibus_engine.is_component_up_to_date", return_value=True)
|
||||
@patch("vocalinux.text_injection.ibus_engine.start_engine_process", return_value=True)
|
||||
@patch("vocalinux.text_injection.ibus_engine.is_engine_active", return_value=True)
|
||||
def test_ibus_text_injector_init_with_auto_activate(
|
||||
self, mock_active, mock_start, mock_update, mock_registered, mock_ensure_dir
|
||||
):
|
||||
"""Test IBusTextInjector initialization with auto-activation."""
|
||||
from vocalinux.text_injection.ibus_engine import IBusTextInjector
|
||||
|
||||
injector = IBusTextInjector(auto_activate=True)
|
||||
self.assertIsNotNone(injector)
|
||||
|
||||
@patch("vocalinux.text_injection.ibus_engine.ensure_ibus_dir")
|
||||
@patch("vocalinux.text_injection.ibus_engine.switch_engine")
|
||||
@patch("vocalinux.text_injection.ibus_engine.get_current_engine", return_value="other-engine")
|
||||
def test_ibus_text_injector_stop(self, mock_current_engine, mock_switch, mock_ensure_dir):
|
||||
"""Test IBusTextInjector stop restores previous engine."""
|
||||
from vocalinux.text_injection.ibus_engine import IBusTextInjector
|
||||
|
||||
injector = IBusTextInjector(auto_activate=False)
|
||||
injector._previous_engine = "other-engine"
|
||||
|
||||
injector.stop()
|
||||
mock_switch.assert_called_once_with("other-engine")
|
||||
|
||||
@patch("vocalinux.text_injection.ibus_engine.ensure_ibus_dir")
|
||||
@patch("socket.socket")
|
||||
@patch("vocalinux.text_injection.ibus_engine.SOCKET_PATH")
|
||||
@patch("vocalinux.text_injection.ibus_engine.is_engine_active", return_value=True)
|
||||
def test_ibus_text_injector_inject_text_success(
|
||||
self, mock_active, mock_socket_path, mock_socket_cls, mock_ensure_dir
|
||||
):
|
||||
"""Test successful text injection."""
|
||||
from vocalinux.text_injection.ibus_engine import IBusTextInjector
|
||||
|
||||
mock_socket_path.exists.return_value = True
|
||||
mock_socket = MagicMock()
|
||||
mock_socket.__enter__.return_value = mock_socket
|
||||
mock_socket.__exit__.return_value = None
|
||||
mock_socket.recv.return_value = b"OK"
|
||||
mock_socket_cls.return_value = mock_socket
|
||||
|
||||
injector = IBusTextInjector(auto_activate=False)
|
||||
result = injector.inject_text("Hello World")
|
||||
self.assertTrue(result)
|
||||
|
||||
@patch("vocalinux.text_injection.ibus_engine.ensure_ibus_dir")
|
||||
@patch("vocalinux.text_injection.ibus_engine.is_engine_active", return_value=True)
|
||||
def test_ibus_text_injector_inject_text_empty(self, mock_active, mock_ensure_dir):
|
||||
"""Test text injection with empty text."""
|
||||
from vocalinux.text_injection.ibus_engine import IBusTextInjector
|
||||
|
||||
injector = IBusTextInjector(auto_activate=False)
|
||||
result = injector.inject_text("")
|
||||
self.assertTrue(result)
|
||||
|
||||
@patch("vocalinux.text_injection.ibus_engine.ensure_ibus_dir")
|
||||
@patch("vocalinux.text_injection.ibus_engine.is_engine_active", return_value=True)
|
||||
@patch("vocalinux.text_injection.ibus_engine.SOCKET_PATH")
|
||||
def test_ibus_text_injector_socket_not_found(
|
||||
self, mock_socket_path, mock_active, mock_ensure_dir
|
||||
):
|
||||
"""Test text injection when socket is not found."""
|
||||
from vocalinux.text_injection.ibus_engine import IBusTextInjector
|
||||
|
||||
mock_socket_path.exists.return_value = False
|
||||
|
||||
injector = IBusTextInjector(auto_activate=False)
|
||||
result = injector.inject_text("Hello World")
|
||||
self.assertFalse(result)
|
||||
|
||||
@patch("vocalinux.text_injection.ibus_engine.ensure_ibus_dir")
|
||||
@patch("vocalinux.text_injection.ibus_engine.is_engine_active", return_value=True)
|
||||
@patch("socket.socket")
|
||||
@patch("vocalinux.text_injection.ibus_engine.SOCKET_PATH")
|
||||
def test_ibus_text_injector_socket_timeout(
|
||||
self, mock_socket_path, mock_socket_cls, mock_active, mock_ensure_dir
|
||||
):
|
||||
"""Test text injection with socket timeout."""
|
||||
from vocalinux.text_injection.ibus_engine import IBusTextInjector
|
||||
|
||||
mock_socket_path.exists.return_value = True
|
||||
mock_socket = MagicMock()
|
||||
mock_socket.__enter__.return_value = mock_socket
|
||||
mock_socket.__exit__.return_value = None
|
||||
mock_socket.connect.side_effect = socket.timeout()
|
||||
mock_socket_cls.return_value = mock_socket
|
||||
|
||||
injector = IBusTextInjector(auto_activate=False)
|
||||
result = injector.inject_text("Hello World")
|
||||
self.assertFalse(result)
|
||||
|
||||
|
||||
class TestVocalinuxEngineApplication(unittest.TestCase):
|
||||
"""Test VocalinuxEngineApplication class."""
|
||||
|
||||
def setUp(self):
|
||||
"""Set up test fixtures - force module reload to get fresh mocks."""
|
||||
import importlib
|
||||
|
||||
sys.modules["gi"] = mock_gi
|
||||
sys.modules["gi.repository"] = MagicMock()
|
||||
sys.modules["gi.repository"].IBus = mock_ibus
|
||||
sys.modules["gi.repository"].GLib = mock_glib
|
||||
sys.modules["gi.repository"].GObject = mock_gobject
|
||||
if "vocalinux.text_injection.ibus_engine" in sys.modules:
|
||||
importlib.reload(sys.modules["vocalinux.text_injection.ibus_engine"])
|
||||
|
||||
def tearDown(self):
|
||||
"""Clean up after tests."""
|
||||
pass
|
||||
|
||||
@patch("vocalinux.text_injection.ibus_engine.VocalinuxEngine._start_socket_server")
|
||||
def test_vocalinux_engine_application_init(self, mock_start_server):
|
||||
"""Test VocalinuxEngineApplication initialization."""
|
||||
from vocalinux.text_injection.ibus_engine import VocalinuxEngineApplication
|
||||
|
||||
app = VocalinuxEngineApplication()
|
||||
self.assertIsNotNone(app)
|
||||
# Verify bus attribute is properly initialized
|
||||
self.assertIsNotNone(app.bus)
|
||||
# Verify mainloop attribute is properly initialized
|
||||
self.assertIsNotNone(app.mainloop)
|
||||
# Verify they are the correct types (mocked in test)
|
||||
self.assertEqual(type(app.bus).__name__, "MagicMock")
|
||||
self.assertEqual(type(app.mainloop).__name__, "MagicMock")
|
||||
|
||||
@patch("vocalinux.text_injection.ibus_engine.VocalinuxEngine._start_socket_server")
|
||||
def test_vocalinux_engine_application_on_disconnected(self, mock_start_server):
|
||||
"""Test IBus disconnection handler."""
|
||||
from vocalinux.text_injection.ibus_engine import VocalinuxEngineApplication
|
||||
|
||||
app = VocalinuxEngineApplication()
|
||||
mock_bus = MagicMock()
|
||||
|
||||
with patch.object(app.mainloop, "quit"):
|
||||
app._on_disconnected(mock_bus)
|
||||
app.mainloop.quit.assert_called_once()
|
||||
|
||||
@patch("vocalinux.text_injection.ibus_engine.VocalinuxEngine._start_socket_server")
|
||||
def test_vocalinux_engine_application_run(self, mock_start_server):
|
||||
"""Test engine application main loop."""
|
||||
from vocalinux.text_injection.ibus_engine import VocalinuxEngineApplication
|
||||
|
||||
app = VocalinuxEngineApplication()
|
||||
with patch.object(app.mainloop, "run"):
|
||||
app.run()
|
||||
app.mainloop.run.assert_called_once()
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
Reference in New Issue
Block a user