Commit Graph
2 Commits
Author SHA1 Message Date
4497bfae6c fix(logs): let the View Logs dialog close via titlebar-X (#892)
* fix(logs): let the View Logs dialog close via titlebar-X

_on_response only destroyed on ResponseType.CLOSE and ignored
DELETE_EVENT, so the Logs window could not be dismissed with the
window-manager close button — unlike Settings, which handles both. A
window force-destroyed behind the dialog then crashed quit with a
BadWindow error instead of an orderly shutdown.

* test(logs): cover _on_response behavior; annotate its signature

---------

Co-authored-by: Jatin K Malik <jatinkrmalik@gmail.com>
2026-09-30 05:55:33 -07:00
Jatin K MalikandGitHub c75893b2a4 test: add comprehensive tests for UI dialog redesigns (#135)
* test: add comprehensive tests for UI dialog redesigns

- Add tests for AboutDialog (show_about_dialog function and class)
- Add tests for LoggingDialog (CSS, filtering, actions, toast notifications)
- Update SettingsDialog tests for instant-apply pattern (Close-only buttons)
- Use source code inspection to verify method existence with GTK mocks
- All 382 tests passing

* fix(test): rewrite UI dialog tests to use source inspection

Replace GTK mocking with source code inspection approach to fix
CI failures on Python 3.8 and 3.10. The new approach reads source
files directly and verifies method definitions, CSS classes, and
expected code patterns exist, avoiding Python version-specific
module caching issues with patched imports.
2026-02-05 14:51:36 -08:00