* chore(build): migrate justfile tooling to uv All recipes now run through 'uv run' against .venv, with a shared DEV_EXTRAS variable (dev + vad) because uv syncs the environment exactly and would otherwise uninstall the dev tools between recipes. 'deps' installs dev+vad; new 'deps-all' covers every extra. 'build' switches to 'uv build'; 'version' uses --no-sync. Bump [tool.uv] required-version to >=0.12,<0.13 for uv 0.12.x, and raise the mypy python_version target to 3.12: mypy 1.19 in the lock cannot target 3.9 and numpy 2.x stubs need a 3.12 target to parse (mypy is not run in CI or pre-commit; this only affects 'just typecheck'). * fix(tests): isolate test runs from real XDG state; fix Arch model-path crash Local test runs failed en masse (185 failures) while CI stayed green: tests picked up the developer's real ~/.local/share/vocalinux models via the default XDG paths and switched IBus/keyboard code paths through the desktop session env (XDG_CURRENT_DESKTOP/ XDG_SESSION_TYPE on GNOME/Wayland, issue #478 branches). conftest now points XDG base dirs at a throwaway session-wide directory and clears session variables at import time, mirroring a fresh CI runner (paths like MODELS_DIR freeze at first import during collection, so fixture-time isolation is too late). Also guard the Arch branch of _get_system_model_paths(): it removed /usr/local/share/vocalinux/models unconditionally and crashed with ValueError on Arch hosts when a custom XDG_DATA_DIRS never added that path. Add regression tests, and make the lock-file test assert the actual $XDG_DATA_HOME/vocalinux contract instead of the hardcoded ~/.local/share default. * fix(tests): keep the IBus engine double a plain class Python 3.14's unittest.mock re-instantiates a user subclass when it builds child mocks (klass(name=...)). VocalinuxEngine inherits from whatever IBus.Engine resolves to, and the test module bound that to the MagicMock class itself, so every engine instantiation raised TypeError: VocalinuxEngine.__init__() got an unexpected keyword argument 'name' on 3.14 while passing on 3.13. Replace it with a plain stand-in class that still hands out per-instance MagicMocks for the IBus API surface the engine touches. The same pattern remains in test_ibus_engine.py, test_ibus_engine_utils.py, test_ibus_active_engine_guard.py and test_ibus_xkb_wayland.py; those never instantiate the engine, so they are unaffected for now. * fix(install): build the venv from the system Python install.sh looked up a bare `python3` from PATH. Started from an activated virtualenv — a shell left in uv's .venv after `just deps` — it built venv/ from that interpreter, where distro PyGObject is invisible even with --system-site-packages, and the run aborted with Distro PyGObject (python3-gi / python3-gobject) is not importable in the venv. A mismatched venv/ then survived every retry, because the installer reuses whatever venv it finds. - drop an inherited VIRTUAL_ENV (and its bin from PATH) before any interpreter lookup - select the interpreter explicitly: $SYSTEM_PYTHON (default /usr/bin/python3) or PATH python3, preferring one that can import gi, and create the venv with it instead of `python3` - recreate venv/ when it was built by a different interpreter - name the interpreter in the PyGObject guard's error Documents the two environments (uv's .venv for tooling, venv/ for the installed app) in CONTRIBUTING, the justfile header and AGENTS.md, and adds the mismatch symptom to the INSTALL troubleshooting section. * chore(python): raise the supported floor to 3.11 requires-python promised 3.9 while the CI matrix ran 3.9/3.10/3.11/3.13, the classifiers advertised up to 3.14, mypy targeted 3.12 and install.sh enforced 3.9 — five different answers to "which Python does this support". Settle on 3.11 everywhere: pyproject (requires-python, classifiers, black targets), install.sh's MIN_VERSION, check-system-deps.sh, the distro package map, the CI matrix (now 3.11-3.14, matching the classifiers), the release and nightly workflows, and the docs. mypy now targets the floor instead of 3.12, so type checking covers what we promise; numpy 2.x ships stubs in 3.12 syntax that a 3.11 target cannot parse, so its imports are skipped. (mypy has 71 pre-existing errors either way; no CI job gates on it.) uv.lock and the requirements/* exports are regenerated — dropping 3.9/3.10 removes most of the version-conditional resolution branches. tests/test_python_version_policy.py pins the invariant: install.sh's floor, requires-python, the classifiers and the CI matrix must agree. * ci: run lint and tests from uv.lock The lock file and the hash-pinned exports were not enforced anywhere: CI still built a venv by hand and installed unpinned `PyGObject` plus `-e ".[dev,vad]"`, so the tool versions it checked against had nothing to do with the ones `just lint` uses locally. Both Python jobs now use astral-sh/setup-uv and run through `uv sync --locked` / `uv run --locked`, which also fails the build when uv.lock drifts from pyproject.toml. Partially covers phase 5 of #701 (tests install from the lock, lock freshness gate); trusted publishing, artifact checksums and action SHA pinning are still open there. * ci: lint from a dedicated dependency group The lint job failed on this branch: `uv run --extra dev` syncs the whole project, so it tried to build pyaudio from source on a runner that installs no system dependencies. src/pyaudio/device_api.c:9:10: fatal error: portaudio.h: No such file or directory Move black/isort/flake8 out of the `dev` extra into a `lint` dependency group. CI runs `uv run --locked --only-group lint`, which installs the three pure-Python tools and skips the project entirely — no portaudio or girepository headers needed. `just deps` and DEV_EXTRAS request the group alongside the dev extras, so the local environment still carries test and lint tooling at once and `just lint` matches CI version for version. pre-commit is unaffected: its hooks pin their own tool versions upstream. * fix(install): never configure an engine the venv cannot import vosk became an optional extra in #705, but the installer still writes `"engine": "vosk"` into config.json on the whisper.cpp fallback path even when installing the extra only produced a warning. config.json also survives reinstalls — every writer guards on "file does not exist" — so an engine picked by an earlier attempt outlives the venv that supported it. Either way Vocalinux dies at startup: ModuleNotFoundError: No module named 'vosk' - the fallback now writes the vosk config only when `import vosk` actually succeeds, and otherwise leaves the engine configuration alone - a new verify_configured_engine() runs near the end of the install: if config.json selects vosk and the venv cannot import it, it says so and prints both fixes instead of leaving a broken install behind * feat(models): verify every model download against a pinned digest Pins a sha256/md5 per downloadable speech model in src/vocalinux/utils/model_checksums.txt and verifies against it in both install.sh and the runtime downloaders, before the file is moved into place. Verification fails closed. Covers phase 2.5 of #701; see the PR for details. * docs(agents): rebase AGENTS.md onto the #727 rewrite * fix(install): hash models that are already on disk instead of trusting them * refactor(models): one download path per engine, and fix Whisper's * docs(install): drop distros that cannot meet the 3.11 floor * docs: retire the distros and Python versions the 3.11 floor rules out * fix(install): abort instead of warning when Python is below the floor * fix(install): fall back to the system Python, not the one on PATH * fix(install): match an existing venv by installation, not by X.Y * fix(install): repair a config naming an engine the venv cannot import * fix(models): pin VOSK by the sha256 of bytes we fetched, not upstream's md5 * fix(justfile): request the dev set in every recipe that syncs * test(version): scan the docs and website trees for a stale Python floor * docs: correct the stale model-checksum and distro claims * fix(models): stamp the VOSK tree the app extracts, as the installer does * fix(install): replace an unverified VOSK model only once its successor is ready * docs(install): align the Fedora floor with the rest of the tree * test(install): drop an f-string with no placeholders * test(models): stub the downloader probe the VOSK installer test relies on * docs: drop the long dashes from two model-checksum comments * fix(install): gate on the interpreter, not on the distro release label * fix(justfile): export the lint group into requirements/dev.txt * fix(models): unpack the VOSK tree into staging and stamp it before the swap * fix(whisper): adopt a checkpoint an earlier release stored under the catalog name * docs(settings): state what a stray Whisper copy really means for deletion * fix(models): hash a whisper.cpp model found on disk before it reaches ctypes * docs(contributing): stop telling readers to uninstall their linters * fix(install): stop warning off distros the project documents as supported * docs(distros): file the supported derivatives under supported
247 lines
8.9 KiB
Python
247 lines
8.9 KiB
Python
"""
|
|
Configuration file for pytest.
|
|
This file makes sure that the 'src' module can be imported in tests.
|
|
"""
|
|
|
|
import atexit
|
|
import os
|
|
import shutil
|
|
import subprocess
|
|
import sys
|
|
import tempfile
|
|
import threading
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
# Set PYTEST_RUNNING early so audio_feedback module can detect it
|
|
os.environ["PYTEST_RUNNING"] = "1"
|
|
|
|
# Isolate the whole test process from the developer's real desktop session
|
|
# and Vocalinux state, mirroring a fresh CI runner:
|
|
# * XDG base dirs point at a throwaway directory, so locally downloaded
|
|
# models (~/.local/share/vocalinux/models) and the real config file
|
|
# never leak into tests. This must happen at conftest import time:
|
|
# vocalinux modules freeze paths like MODELS_DIR at first import during
|
|
# collection, before any fixture could run. The directory is shared for
|
|
# the whole session on purpose — some tests rely on directories that
|
|
# earlier tests created, exactly as they do on CI with the runner's HOME.
|
|
# * Desktop session variables are cleared: a developer's GNOME/Wayland
|
|
# session flips IBus/keyboard code paths (issue #478) that CI never sees.
|
|
# Tests that need specific values set them via patch.dict/monkeypatch, which
|
|
# layer on top of this.
|
|
_XDG_ISOLATION_DIR = tempfile.mkdtemp(prefix="vocalinux-pytest-xdg-")
|
|
os.environ["XDG_DATA_HOME"] = os.path.join(_XDG_ISOLATION_DIR, "data")
|
|
os.environ["XDG_CONFIG_HOME"] = os.path.join(_XDG_ISOLATION_DIR, "config")
|
|
os.environ["XDG_CACHE_HOME"] = os.path.join(_XDG_ISOLATION_DIR, "cache")
|
|
for _var in (
|
|
"XDG_CURRENT_DESKTOP",
|
|
"XDG_SESSION_TYPE",
|
|
"XDG_SESSION_DESKTOP",
|
|
"DESKTOP_SESSION",
|
|
"WAYLAND_DISPLAY",
|
|
):
|
|
os.environ.pop(_var, None)
|
|
atexit.register(shutil.rmtree, _XDG_ISOLATION_DIR, ignore_errors=True)
|
|
|
|
# Several legacy tests replace sys.modules["numpy"] with MagicMock at module
|
|
# import time. Preserve the real module once so newer tests can restore it
|
|
# without unloading/re-importing NumPy's compiled extensions.
|
|
try:
|
|
import numpy as _real_numpy
|
|
except ImportError:
|
|
_real_numpy = None
|
|
else:
|
|
sys._vocalinux_real_numpy = _real_numpy
|
|
|
|
# And the same for zipfile: test_recognition_manager.py and
|
|
# test_recognition_manager_download_buffer.py assign a MagicMock to
|
|
# sys.modules["zipfile"] at import time and never put it back, so any later test
|
|
# that extracts a real archive gets a silent no-op. Keep the genuine module
|
|
# reachable for the ones that need it.
|
|
import zipfile as _real_zipfile # noqa: E402
|
|
|
|
sys._vocalinux_real_zipfile = _real_zipfile
|
|
|
|
# Prevent specific known-blocking daemon threads from starting during tests.
|
|
# Source code in ibus_engine.py and evdev_backend.py spawns daemon threads
|
|
# (socket server, device monitor) that block on socket.accept() or
|
|
# select.select(). These threads cannot be interrupted by pytest-timeout
|
|
# and cause CI jobs to hang/timeout.
|
|
#
|
|
# We only block threads whose target function matches known blockers;
|
|
# test-created daemon threads (e.g. for mock socket servers) are allowed.
|
|
_real_thread_start = threading.Thread.start
|
|
_BLOCKED_THREAD_TARGETS = {"server_thread", "_monitor_devices"}
|
|
|
|
|
|
_real_thread_join = threading.Thread.join
|
|
|
|
|
|
def _safe_thread_start(self):
|
|
"""Skip known-blocking daemon threads to prevent CI hangs."""
|
|
if self.daemon and hasattr(self, "_target") and self._target is not None:
|
|
target_name = getattr(self._target, "__name__", "")
|
|
if target_name in _BLOCKED_THREAD_TARGETS:
|
|
# Mark this thread so join() can recognise it was never started.
|
|
self._skipped_by_conftest = True
|
|
return
|
|
_real_thread_start(self)
|
|
|
|
|
|
def _safe_thread_join(self, timeout=None):
|
|
"""Handle join() for threads that were skipped by _safe_thread_start."""
|
|
if getattr(self, "_skipped_by_conftest", False):
|
|
return # Thread was never started; nothing to join
|
|
_real_thread_join(self, timeout)
|
|
|
|
|
|
threading.Thread.start = _safe_thread_start
|
|
threading.Thread.join = _safe_thread_join
|
|
|
|
# Add the parent directory to sys.path so that 'src' can be imported
|
|
sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), "..")))
|
|
|
|
# Always mock GI/GTK modules before any test files are collected.
|
|
# On CI, real gi (PyGObject) is installed via "pip install PyGObject" and
|
|
# module-level imports in vocalinux source files (ibus_engine, tray_indicator,
|
|
# settings_dialog, etc.) will trigger GTK initialization or IBus daemon
|
|
# connections that hang indefinitely in headless environments.
|
|
# pytest-timeout cannot interrupt these C-level blocking calls.
|
|
#
|
|
# We unconditionally replace gi with a mock — even if the real package is
|
|
# already imported — because the real gi causes hangs on headless CI runners.
|
|
# The previous "if 'gi' not in sys.modules" guard was ineffective on CI
|
|
# precisely because PyGObject was installed and already loaded.
|
|
_mock_gi = MagicMock()
|
|
_mock_gi_repository = MagicMock()
|
|
_mock_gi_repository.Notify = MagicMock()
|
|
sys.modules["gi"] = _mock_gi
|
|
sys.modules["gi.repository"] = _mock_gi_repository
|
|
|
|
# Create and export the mock_audio_feedback module for tests that need it
|
|
# This mock is used by test_recognition_manager.py and test_speech_recognition.py
|
|
mock_audio_feedback = MagicMock()
|
|
mock_audio_feedback.play_start_sound = MagicMock()
|
|
mock_audio_feedback.play_stop_sound = MagicMock()
|
|
mock_audio_feedback.play_error_sound = MagicMock()
|
|
|
|
# Inject the mock into sys.modules so imports resolve correctly
|
|
sys.modules["vocalinux.ui.audio_feedback"] = mock_audio_feedback
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _suppress_desktop_notifications(request):
|
|
"""Patch _show_notification for all tests except those testing it directly."""
|
|
if "show_notification" in request.node.nodeid:
|
|
yield
|
|
return
|
|
with patch("vocalinux.speech_recognition.recognition_manager._show_notification"):
|
|
yield
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _clear_hardware_detection_cache():
|
|
"""Clear lru_cache on hardware-detection helpers between tests.
|
|
|
|
Hardware detection results are cached for the lifetime of the process
|
|
in production, but tests mock subprocess.run and call these helpers
|
|
multiple times with different mock return values; without clearing
|
|
the cache, later assertions would see the first call's cached result.
|
|
"""
|
|
try:
|
|
from vocalinux.utils import whispercpp_model_info as _wmi
|
|
|
|
for fn_name in (
|
|
"detect_vulkan_support",
|
|
"detect_cuda_support",
|
|
"detect_compute_backend",
|
|
"detect_cpu_info",
|
|
):
|
|
fn = getattr(_wmi, fn_name, None)
|
|
if fn is not None and hasattr(fn, "cache_clear"):
|
|
fn.cache_clear()
|
|
except Exception:
|
|
pass
|
|
yield
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _cleanup_ibus_server():
|
|
"""Stop any leftover IBus socket server threads after each test.
|
|
|
|
Some tests trigger VocalinuxEngine._start_socket_server() which spawns
|
|
a daemon thread blocking on socket.accept(). If the test doesn't call
|
|
stop_socket_server(), the thread keeps running and eventually causes
|
|
pytest-timeout to kill the whole process.
|
|
"""
|
|
yield
|
|
|
|
try:
|
|
from vocalinux.text_injection.ibus_engine import VocalinuxEngine
|
|
|
|
if getattr(VocalinuxEngine, "_server_running", False):
|
|
VocalinuxEngine._server_running = False
|
|
sock = getattr(VocalinuxEngine, "_server_socket", None)
|
|
if sock is not None:
|
|
try:
|
|
sock.close()
|
|
except Exception:
|
|
pass
|
|
VocalinuxEngine._server_socket = None
|
|
except Exception:
|
|
pass
|
|
|
|
|
|
def pytest_addoption(parser):
|
|
"""Add custom command line options for pytest."""
|
|
parser.addoption(
|
|
"--run-tray-tests",
|
|
action="store_true",
|
|
default=False,
|
|
help="Run tray indicator tests (may hang in headless environments)",
|
|
)
|
|
parser.addoption(
|
|
"--run-audio-tests",
|
|
action="store_true",
|
|
default=False,
|
|
help="Run audio feedback tests (may fail in CI environments without audio)",
|
|
)
|
|
|
|
|
|
def pytest_configure(config):
|
|
"""Configure pytest markers."""
|
|
config.addinivalue_line("markers", "tray: marks tests as tray indicator tests")
|
|
config.addinivalue_line("markers", "audio: marks tests as audio feedback tests")
|
|
|
|
|
|
@pytest.fixture
|
|
def mock_gi():
|
|
"""Fixture to mock GTK/GI modules for tests that need it."""
|
|
mock_gtk = MagicMock()
|
|
mock_glib = MagicMock()
|
|
mock_gobject = MagicMock()
|
|
mock_gdkpixbuf = MagicMock()
|
|
mock_appindicator = MagicMock()
|
|
|
|
# Make idle_add execute the function directly
|
|
mock_glib.idle_add.side_effect = lambda func, *args: func(*args) or False
|
|
|
|
return {
|
|
"Gtk": mock_gtk,
|
|
"GLib": mock_glib,
|
|
"GObject": mock_gobject,
|
|
"GdkPixbuf": mock_gdkpixbuf,
|
|
"AppIndicator3": mock_appindicator,
|
|
}
|
|
|
|
|
|
@pytest.fixture
|
|
def mock_audio_player():
|
|
"""Fixture to mock audio player detection."""
|
|
return MagicMock()
|
|
|
|
|
|
# This will help pytest discover all test files correctly
|
|
pytest_plugins = []
|