Compare commits

...
27 Commits
Author SHA1 Message Date
xavierk ef9e7fa7a8 fix: satisfy semgrep on constant-column SQL; use injectable clock for baseline entry_date
CI / security (pull_request) Successful in 20s
CI / lint (pull_request) Successful in 39s
CI / ai-review (pull_request) Successful in 8m44s
2026-10-06 13:01:34 +05:30
xavierk 670671cb25 chore: prepare v0.7.0 release
Release / release (push) Successful in 1m28s
CI / security (pull_request) Failing after 21s
CI / lint (pull_request) Successful in 36s
CI / ai-review (pull_request) Successful in 2m52s
Bump pyproject.toml to 0.7.0 and move the Unreleased section under
[0.7.0] - 2026-10-06.
2026-10-06 10:14:35 +05:30
xavierk 8c8710fe5a Merge origin/main into main
Reconcile the staged-projection and Diagnostics feature work with the CI
quality-gate changes from origin/main. The origin side of every conflict was
lint-only, so the feature imports were kept and the ruff fixes re-applied:

- keep the branch's added imports (timefmt, activity_readout, projection
  ladder helpers) and drop the unused ones ruff reported
- restore `noqa: E402` on the post-bootstrap imports in fenris-monitor and
  keep the `noqa: F401` re-exports in the TUI that tests assert on
- make the TUI monitoring-glyph test clock-relative instead of pinned to a
  fixed date
2026-10-06 10:14:09 +05:30
xavierk ab1d894adc feat(collector): capture additional smartctl diagnostics
Record host read and write commands, controller busy time, error log
entries, warning and critical temperature time, and thermal management
transitions from the existing smartctl -a -j acquisition. Schema 7 adds
nullable columns to samples so legacy rows read as unknown, and the
Diagnostics panel shows each counter with its change.
2026-10-05 21:12:25 +05:30
xavierk 948e097952 feat(tui): add Diagnostics panel for stored evidence
Toggle a Diagnostics panel with i, built on the Activity readout. It swaps
in for the Drive pane and shows the decoded critical_warning, power-on
hours, power cycles, unsafe shutdowns, media errors and available spare
with their change over the selection, and per-hour (Day) or per-day
(History) temperature min/avg/max, active/idle/powered-off/unknown split
and coverage. History bars draw reads beside writes while it is open, and a
set critical_warning shows as a badge in the endurance outlook without
affecting the projection. Counter deltas are withheld across a controller
segment change.
2026-10-05 21:05:44 +05:30
xavierk 6c517e4ecb feat(tui): unify keyboard and mouse navigation
Declare every dashboard key as a Binding on the widget that owns it, and
generate the footer, activity tool chips and help screen from those
bindings so they cannot drift. The footer collapses to "? help · q quit"
under 80x24.

Add Home/End and PgUp/PgDn (one week) navigation, mouse-wheel selection on
the graphs, click-to-focus on every panel, and clickable footer chips.
Tab and Shift+Tab now visit only the dashboard panels.
2026-10-05 20:42:04 +05:30
xavierk 79ebb10dea refactor(tui): extract Activity readout and show local time
Move activity data assembly out of tui.py into activity_readout, behind
readout(conn, selection, now). Dashboard and fenris-monitor enable now show
local time with a timezone label, inspected points keep a secondary UTC line,
and the legacy UTC-relabelled day and hour branches are gone. Time formatting
(including freshness_age_human) lives in timefmt. Hour offsets now render as
+05:30 to match day labels.
2026-10-05 20:21:22 +05:30
xavierk ef61ececc1 feat(tui): enter rated TBW from the dashboard
Add a b key and a no-baseline banner that open a form for rated TBW and an
optional source URL. The value is persisted as an unverified override through
fenris-monitor baseline set under the existing polkit action, and the outcome
is reported synchronously. Verified overrides stay CLI-only (ADR 0012 section 7).
2026-10-05 20:01:32 +05:30
xavierk e26a851115 feat(projection): show staged projection with evidence ladder
Report a projection stage, an evidence ladder and the sustained-regime
write rate from compute_projection, per ADR 0012. A provisional lifespan
appears after 3 observed hours and carries the hours observed and a
short-horizon spread; the complete-local-day condition becomes a fact
instead of a gate, and the write rate replaces the lifespan when no
baseline applies. The TUI and CLI render the stage, ladder count and
full ladder, and drop their own two-sample pre-gates.
2026-10-05 19:57:46 +05:30
xavierk 96fd1702fa fix(projection): align projection with ADR 0002
Use lifetime written bytes from the current segment's newest published
sample in the headline formula, select the Percentage-Used-implied
baseline after two increments in the segment (otherwise show the
too-coarse fact), and judge horizon agreement across existing horizons.
Make the vacuous projection tests assert unconditionally and add
coverage for implied-baseline gating and single-horizon agreement.
2026-10-05 19:45:38 +05:30
xavierk cd053cf125 Merge pull request 'ci: add quality-gate workflow (semgrep, ruff, jscpd, advisory PR-Agent)' (#112) from ci/quality-gates into main
CI / lint (push) Successful in 29s
CI / security (push) Successful in 19s
CI / ai-review (push) Skipped
Release / release (push) Failing after 6s
Reviewed-on: #112
2026-10-05 14:14:59 +00:00
soubarna e3b6f89ebb chore: annotate release.yml semgrep warnings
CI / security (pull_request) Successful in 22s
CI / lint (pull_request) Successful in 33s
CI / ai-review (pull_request) Successful in 2s
2026-10-05 17:29:31 +05:30
soubarna 412cbd51c6 fix: triage semgrep SQL findings 2026-10-05 17:29:31 +05:30
soubarna 3355c20202 fix: ruff findings 2026-10-05 17:28:15 +05:30
soubarna 2c93874799 ci: add quality-gate workflow 2026-10-05 17:21:50 +05:30
xavierk 117082af8c docs: record staged projection decisions (#105)
Add ADR 0012 amending ADR 0002 and ADR 0003: projection stages,
provisional lifespan after 3 observed hours, short scenario horizons,
evidence ladder, and TUI unverified TBW entry. Add Projection stage,
Provisional projection, Evidence ladder and Activity readout to the
glossary.
2026-10-03 08:13:12 +05:30
xavierk 3c07f37c78 fix(release): refresh published XBPS assets 2026-09-29 04:38:58 +05:30
xavierk b098132595 fix(ci): authenticate XBPS repository publish
Set the existing Fenris commit identity and pass the Gitea publish token to Git without storing credentials on the runner.
2026-09-29 04:32:54 +05:30
xavierk 1dbe372714 fix(ci): honor XBPS dispatch input
Handle Gitea boolean inputs in the publish condition. Mark Void available only after the repository publish step succeeds.
2026-09-29 04:27:57 +05:30
xavierk 1063fa4dae test(signing): align key storage contract with Gitea
Release / release (push) Successful in 2m3s
2026-09-29 04:19:23 +05:30
xavierk 3f2dd6a5a1 fix(release): retain XBPS key through publication
The optional XBPS publisher signs repository metadata after package signing. Remove the runner key only after publication and release asset upload.
2026-09-29 04:06:45 +05:30
xavierk a5b84f7566 docs: align signing ceremony with Gitea workflow 2026-09-29 03:57:24 +05:30
xavierk 917c94fd65 chore: prepare v0.6.0 release 2026-09-29 03:51:35 +05:30
xavierk a49808a247 docs: preserve session style instructions 2026-09-29 03:51:24 +05:30
xavierk 87c5dcdac6 test: fix runit missing-script fixture 2026-09-29 03:51:20 +05:30
xavierk 511905f519 docs: record observation history decisions 2026-09-29 03:51:17 +05:30
xavierk e22b99442e fix: validate complete-day monitoring coverage 2026-09-29 03:34:17 +05:30
81 changed files with 4856 additions and 1542 deletions
+92
View File
@@ -0,0 +1,92 @@
name: CI
on:
pull_request:
push:
branches: [main]
schedule:
- cron: '0 3 * * 1'
workflow_dispatch:
permissions:
contents: read
jobs:
security:
runs-on: bongbetic-ci
timeout-minutes: 15
container:
image: docker.io/semgrep/semgrep:1.178.0
steps:
- name: Checkout
env:
GIT_TOKEN: ${{ gitea.token }}
run: |
set -euo pipefail
git init -q .
git remote add origin "${{ gitea.server_url }}/${{ gitea.repository }}.git"
git -c http.extraheader="Authorization: token ${GIT_TOKEN}" fetch -q --depth=1 origin "${{ gitea.sha }}"
git checkout -q FETCH_HEAD
- name: Semgrep
run: semgrep scan --config p/default --config p/owasp-top-ten --metrics off --error
lint:
if: gitea.event_name != 'schedule'
runs-on: bongbetic-ci
timeout-minutes: 20
steps:
- name: Checkout
env:
GIT_TOKEN: ${{ gitea.token }}
run: |
set -euo pipefail
git init -q .
git remote add origin "${{ gitea.server_url }}/${{ gitea.repository }}.git"
git -c http.extraheader="Authorization: token ${GIT_TOKEN}" fetch -q --depth=1 origin "${{ gitea.sha }}"
git checkout -q FETCH_HEAD
# node:24-bookworm ships python3 without ensurepip, so python3-venv comes from apt.
- name: Install ruff
run: |
set -euo pipefail
apt-get update -qq
apt-get install -y -qq --no-install-recommends python3-venv
python3 -m venv /tmp/lint-venv
/tmp/lint-venv/bin/pip install -q ruff==0.16.10
- name: Ruff
run: /tmp/lint-venv/bin/ruff check src/ tests/
- name: Duplicate code (jscpd)
run: npx --yes jscpd@4.3.0 --config .jscpd.json .
ai-review:
if: gitea.event_name == 'pull_request'
runs-on: bongbetic-ci
timeout-minutes: 10
continue-on-error: true
container:
image: docker.io/pragent/pr-agent:0.47.0
env:
config__git_provider: gitea
gitea__url: https://git.bongbetic.com
gitea__personal_access_token: ${{ secrets.PR_AGENT_GITEA_TOKEN }}
openrouter__key: ${{ secrets.OPENROUTER_API_KEY }}
config__model: ${{ vars.PR_AGENT_MODEL || 'openrouter/anthropic/claude-sonnet-5' }}
config__fallback_models: "[\"${{ vars.PR_AGENT_MODEL || 'openrouter/anthropic/claude-sonnet-5' }}\"]"
config__custom_model_max_tokens: '200000'
steps:
# Advisory only: posts a review comment, never pushes code. Skips when secrets are absent
# (for example PRs from forks, where Gitea withholds secrets).
- name: PR-Agent review
env:
PR_URL: ${{ gitea.event.pull_request.html_url }}
run: |
set -euo pipefail
if [ -z "${gitea__personal_access_token}" ] || [ -z "${openrouter__key}" ]; then
echo "::notice::PR_AGENT_GITEA_TOKEN or OPENROUTER_API_KEY not set; skipping AI review"
exit 0
fi
cd /app
pr-agent --pr_url="${PR_URL}" review
+41 -14
View File
@@ -25,7 +25,7 @@ jobs:
release: release:
runs-on: [self-hosted] runs-on: [self-hosted]
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v4 # nosemgrep: github-actions-mutable-action-tag -- release path unchanged, tag pinned by major version
- name: Validate release tag and notes - name: Validate release tag and notes
run: | run: |
@@ -47,7 +47,7 @@ jobs:
--footer packaging/release-footer.md > "${RUNNER_TEMP}/release-body.md" --footer packaging/release-footer.md > "${RUNNER_TEMP}/release-body.md"
- name: Set up Python - name: Set up Python
uses: actions/setup-python@v5 uses: actions/setup-python@v5 # nosemgrep: github-actions-mutable-action-tag -- release path unchanged, tag pinned by major version
with: with:
python-version: '3.12' python-version: '3.12'
@@ -159,7 +159,6 @@ jobs:
gpg --batch --yes --delete-secret-keys "${FINGERPRINT}" gpg --batch --yes --delete-secret-keys "${FINGERPRINT}"
gpg --batch --yes --delete-keys "${FINGERPRINT}" gpg --batch --yes --delete-keys "${FINGERPRINT}"
fi fi
rm -f ~/.ssh/id_xbps
- name: Determine version - name: Determine version
id: version id: version
@@ -204,9 +203,21 @@ jobs:
esac esac
- name: Publish XBPS to distribution repository - name: Publish XBPS to distribution repository
if: github.event.inputs.publish_xbps == 'true' id: publish-xbps
if: ${{ github.event.inputs.publish_xbps == true || github.event.inputs.publish_xbps == 'true' }}
env:
GITEA_PUBLISH_TOKEN: ${{ secrets.GITEAPACKAGETOKEN }}
run: | run: |
set -euo pipefail set -euo pipefail
if [ -z "${GITEA_PUBLISH_TOKEN}" ]; then
echo "::error::GITEAPACKAGETOKEN repository secret is not configured"
exit 1
fi
git config user.name "xavierk"
git config user.email "xavierk@bongbetic.com"
export GIT_CONFIG_COUNT=1
export GIT_CONFIG_KEY_0='http.https://git.bongbetic.com/.extraheader'
export GIT_CONFIG_VALUE_0="Authorization: token ${GITEA_PUBLISH_TOKEN}"
VERSION=${{ steps.version.outputs.version }} VERSION=${{ steps.version.outputs.version }}
XBPS_FILE="fenris-${VERSION}_1.x86_64.xbps" XBPS_FILE="fenris-${VERSION}_1.x86_64.xbps"
if [ ! -f "${XBPS_FILE}" ]; then if [ ! -f "${XBPS_FILE}" ]; then
@@ -218,6 +229,7 @@ jobs:
exit 1 exit 1
fi fi
bash scripts/xbps-publish.sh --publish bash scripts/xbps-publish.sh --publish
echo "xbps_published=true" >> "$GITHUB_OUTPUT"
- name: Track format availability - name: Track format availability
id: formats id: formats
@@ -227,7 +239,7 @@ jobs:
DEB_EXISTS=$([ -f "dist/fenris_${VERSION}_amd64.deb" ] && echo "true" || echo "false") DEB_EXISTS=$([ -f "dist/fenris_${VERSION}_amd64.deb" ] && echo "true" || echo "false")
RPM_EXISTS=$([ -f "dist/fenris-${VERSION}-1.x86_64.rpm" ] && echo "true" || echo "false") RPM_EXISTS=$([ -f "dist/fenris-${VERSION}-1.x86_64.rpm" ] && echo "true" || echo "false")
XBPS_EXISTS=$([ -f "fenris-${VERSION}_1.x86_64.xbps" ] && echo "true" || echo "false") XBPS_EXISTS=$([ -f "fenris-${VERSION}_1.x86_64.xbps" ] && echo "true" || echo "false")
XBPS_PUBLISHED=$([ "${{ github.event.inputs.publish_xbps }}" = "true" ] && echo "true" || echo "false") XBPS_PUBLISHED=$([ "${{ steps.publish-xbps.outputs.xbps_published }}" = "true" ] && echo "true" || echo "false")
echo "deb_available=${DEB_EXISTS}" >> "$GITHUB_OUTPUT" echo "deb_available=${DEB_EXISTS}" >> "$GITHUB_OUTPUT"
echo "rpm_available=${RPM_EXISTS}" >> "$GITHUB_OUTPUT" echo "rpm_available=${RPM_EXISTS}" >> "$GITHUB_OUTPUT"
echo "xbps_available=${XBPS_EXISTS}" >> "$GITHUB_OUTPUT" echo "xbps_available=${XBPS_EXISTS}" >> "$GITHUB_OUTPUT"
@@ -318,7 +330,8 @@ jobs:
"https://git.bongbetic.com/api/v1/repos/xavierk/Fenris/releases/tags/v${VERSION}") "https://git.bongbetic.com/api/v1/repos/xavierk/Fenris/releases/tags/v${VERSION}")
RELEASE_ID=$(printf '%s' "${RELEASE_JSON}" \ RELEASE_ID=$(printf '%s' "${RELEASE_JSON}" \
| python3 -c "import sys,json; print(json.load(sys.stdin)['id'])") | python3 -c "import sys,json; print(json.load(sys.stdin)['id'])")
# Attach deb, rpm, clearsigned checksums, and XBPS artifacts once. PUBLISH_XBPS="${{ steps.formats.outputs.xbps_published }}"
# Attach package artifacts; refresh XBPS assets after publication.
ARTIFACTS=( ARTIFACTS=(
"dist/fenris_${VERSION}_amd64.deb" "dist/fenris_${VERSION}_amd64.deb"
"dist/fenris-${VERSION}-1.x86_64.rpm" "dist/fenris-${VERSION}-1.x86_64.rpm"
@@ -327,19 +340,33 @@ jobs:
# Add XBPS artifacts if they exist # Add XBPS artifacts if they exist
XBPS_FILE="fenris-${VERSION}_1.x86_64.xbps" XBPS_FILE="fenris-${VERSION}_1.x86_64.xbps"
if [ -f "${XBPS_FILE}" ]; then if [ -f "${XBPS_FILE}" ]; then
ARTIFACTS+=("${XBPS_FILE}")
if [ -f "${XBPS_FILE}.sig2" ]; then if [ -f "${XBPS_FILE}.sig2" ]; then
ARTIFACTS+=("${XBPS_FILE}")
ARTIFACTS+=("${XBPS_FILE}.sig2") ARTIFACTS+=("${XBPS_FILE}.sig2")
else
echo "::warning::Unsigned XBPS artifact omitted from release assets"
fi fi
fi fi
for FILE in "${ARTIFACTS[@]}"; do for FILE in "${ARTIFACTS[@]}"; do
ASSET_NAME="${FILE##*/}" ASSET_NAME="${FILE##*/}"
if python3 -c 'import json,sys; name=sys.argv[1]; sys.exit(0 if any(a.get("name") == name for a in json.load(sys.stdin).get("assets", [])) else 1)' "${ASSET_NAME}" <<<"${RELEASE_JSON}"; then EXISTING_ASSET_ID=$(python3 -c 'import json,sys; name=sys.argv[1]; print(next((a["id"] for a in json.load(sys.stdin).get("assets", []) if a.get("name") == name), ""))' \
echo "${ASSET_NAME}: already attached" "${ASSET_NAME}" <<<"${RELEASE_JSON}")
else if [ -n "${EXISTING_ASSET_ID}" ]; then
curl --fail --silent --show-error -X POST \ if [ "${PUBLISH_XBPS}" = "true" ] && [[ "${ASSET_NAME}" = "${XBPS_FILE}" || "${ASSET_NAME}" = "${XBPS_FILE}.sig2" ]]; then
-H "Authorization: token ${GITEA_PUBLISH_TOKEN}" \ curl --fail --silent --show-error -X DELETE \
-F "attachment=@${FILE}" \ -H "Authorization: token ${GITEA_PUBLISH_TOKEN}" \
"https://git.bongbetic.com/api/v1/repos/xavierk/Fenris/releases/${RELEASE_ID}/assets" "https://git.bongbetic.com/api/v1/repos/xavierk/Fenris/releases/${RELEASE_ID}/assets/${EXISTING_ASSET_ID}"
else
echo "${ASSET_NAME}: already attached"
continue
fi
fi fi
curl --fail --silent --show-error -X POST \
-H "Authorization: token ${GITEA_PUBLISH_TOKEN}" \
-F "attachment=@${FILE}" \
"https://git.bongbetic.com/api/v1/repos/xavierk/Fenris/releases/${RELEASE_ID}/assets"
done done
- name: Remove XBPS signing key
if: always()
run: rm -f ~/.ssh/id_xbps
+18
View File
@@ -0,0 +1,18 @@
{
"threshold": 8,
"minLines": 5,
"minTokens": 50,
"reporters": ["console"],
"gitignore": true,
"ignore": [
"**/node_modules/**",
"**/.git/**",
"**/dist/**",
"**/docs/**",
"**/packaging/**",
"**/*.lock",
"**/package-lock.json",
"**/requirements.txt",
"**/*.md"
]
}
+4
View File
@@ -1,3 +1,7 @@
## Session style
After the first user message in each session, load the global `caveman` skill and activate `ultra` mode. Keep `ultra` mode active until the user changes or stops it.
## Agent skills ## Agent skills
## Commit messages ## Commit messages
+33
View File
@@ -9,6 +9,39 @@ backfill releases from before this changelog.
## [Unreleased] ## [Unreleased]
## [0.7.0] - 2026-10-06
### Added
- Show a provisional usage-adjusted theoretical lifespan after 3 observed hours, with the hours observed and a short-horizon spread, instead of waiting for a full local day.
- Show the projection stage and an evidence ladder of Supported conditions, each met or unmet with its reason, so confidence visibly strengthens with each collection run.
- Show the sustained-regime write rate when no endurance baseline applies.
- Enter a rated TBW from the dashboard with `b`, saved as an unverified override, so the lifespan appears without the CLI.
- Jump to the first or last point with Home and End on every graph, and a week at a time with PgUp and PgDn in the Day and History views.
- Move through graph points with the mouse wheel, focus any panel by clicking it, and click the footer and activity tool chips to run their actions.
- Open a Diagnostics panel with `i`: the decoded critical warning, power-on hours, power cycles, unsafe shutdowns, media errors and available spare with their change over the selection, plus hourly or daily temperature, active/idle/powered-off/unknown split and coverage. History bars draw reads beside writes while it is open, and a set critical warning shows as a badge in the endurance outlook.
- Record more drive evidence from each collection run (host read and write commands, controller busy time, error log entries, warning and critical temperature time, and thermal management transitions where the drive reports them) and show it in the Diagnostics panel. Existing stores migrate automatically; earlier samples show n/a for the new counters.
### Changed
- Generate the footer and help screen from the dashboard's key bindings so they always agree, and collapse the footer to "? help · q quit" under 80x24.
- Make Tab and Shift+Tab visit only the dashboard panels.
- Show every dashboard time in local time with its timezone, keep a secondary UTC line when a point is inspected, and report the monitoring period start in local time from `fenris-monitor enable`.
- Treat the complete-local-day requirement as a contributing fact rather than a gate, and stop the TUI and CLI from deciding when a projection can be shown.
## [0.6.0] - 2026-09-29
### Added
- Preserve local-day read and write evidence separately, including ambiguous midnight-spanning volume as shared evidence instead of assigning it to either day.
- Keep valid observations pending when publication fails, and recover them without exposing partial history or counting activity twice.
- Preserve live-point inspection and historical activity selection through graph refresh.
### Changed
- Prune old detail only after durable summaries and required boundary evidence are published.
- Require a complete local day to fit within one monitoring period before it can open the endurance outlook.
## [0.5.0] - 2026-09-19 ## [0.5.0] - 2026-09-19
### Changed ### Changed
+48
View File
@@ -0,0 +1,48 @@
# CI quality gates
Workflow: `.gitea/workflows/ci.yml` (runner label `bongbetic-ci`, no third-party `uses:` actions; code is checked out with shell git).
Status contexts: `CI / security (pull_request)`, `CI / lint (pull_request)`, `CI / ai-review (pull_request)`.
| Job | Runs on | Blocks merge? | What it does |
|-----|---------|---------------|--------------|
| `security` | PR, push to main, weekly schedule, manual | Yes | Semgrep 1.178.0, `p/default` + `p/owasp-top-ten`, `--error` |
| `lint` | PR, push to main, manual | Yes | `ruff check src/ tests/` (ruff 0.16.10, rules E4/E7/E9/F) and jscpd 4.3.0 duplicate-code threshold 8% |
| `ai-review` | PR only | No (advisory) | PR-Agent `review`, comment-only, `continue-on-error: true` |
There is no `e2e` (no web UI) and no `deploy` job (not a Coolify app). The weekly schedule (`0 3 * * 1`) runs only `security`.
## Run locally
```sh
# security (same command as CI)
podman run --rm -v "$PWD:/src:Z" docker.io/semgrep/semgrep:1.178.0 \
semgrep scan --config p/default --config p/owasp-top-ten --metrics off --error
# lint (needs `pip install -e '.[dev]'` or `pip install ruff==0.16.10`)
make lint
# duplicate code
npx --yes jscpd@4.3.0 --config .jscpd.json .
```
Notes:
- The semgrep container needs no extra flags. `:Z` is only for SELinux hosts; its working directory is `/src`.
- The `lint` job installs `python3-venv` from apt because `node:24-bookworm` has no `ensurepip`; ruff itself is pinned.
- `.jscpd.json` threshold is 8%, just above the 7.15% baseline, so duplication cannot grow. Lower it as duplication is removed.
- Semgrep prints some non-fatal `PartialParsing` errors; they do not fail the job.
## PR-Agent (advisory)
`ai-review` posts a review comment on the PR through the Gitea API. It never pushes code and never blocks. It exits 0 with a notice when its secrets are empty (for example on fork PRs).
Required repository secrets: `OPENROUTER_API_KEY`, `PR_AGENT_GITEA_TOKEN` (Gitea token of the bot account, scopes to comment on PRs).
Optional repository variable: `PR_AGENT_MODEL` (default `openrouter/anthropic/claude-sonnet-5`). The workflow sets `config__custom_model_max_tokens` to 200000, so adjust it if you pick a model with a different context window.
## Caveats
- Semgrep registry rules (`p/default`, `p/owasp-top-ten`) are fetched at runtime and are not pinned, so a new rule can turn a green main red. The weekly scheduled `security` run catches this early.
- Intentional findings are suppressed with a narrow `# nosemgrep: <rule-id> -- <reason>` on the line. Do not use `.semgrepignore` for source files.
## Rollback
Revert the PR that added `ci.yml` (and its follow-up commits). If branch protection requires `CI / security`, `CI / lint` or `CI / ai-review`, relax it first, otherwise merges stay blocked on checks that no longer run.
+33 -1
View File
@@ -20,6 +20,18 @@ _Avoid_: Future life, actual lifespan, failure date
The degree to which the observation history is sufficiently long, complete, and stable to support the usage-adjusted theoretical lifespan. The degree to which the observation history is sufficiently long, complete, and stable to support the usage-adjusted theoretical lifespan.
_Avoid_: Accuracy percentage, certainty _Avoid_: Accuracy percentage, certainty
**Projection stage**:
Where a usage-adjusted theoretical lifespan stands on its way to support: no observations yet, provisional, warming, limited, supported, or unavailable. Each stage is shown with the facts that place it there.
_Avoid_: Loading state, progress percentage
**Provisional projection**:
A lifespan shown from only a few hours of observation history, before a full daily cycle has been seen; it is labelled with the hours observed and its spread, and is expected to move.
_Avoid_: Estimate, preview, guess
**Evidence ladder**:
The conditions that supported projection confidence requires, each shown as met or unmet with its reason, so confidence visibly strengthens as each collection run adds evidence.
_Avoid_: Confidence score, accuracy meter
**Monitoring period**: **Monitoring period**:
A span during which Fenris monitoring is enabled; powered-off time remains part of the usage habit, while deliberately disabled time does not. A span during which Fenris monitoring is enabled; powered-off time remains part of the usage habit, while deliberately disabled time does not.
_Avoid_: Daemon uptime, calibration window _Avoid_: Daemon uptime, calibration window
@@ -28,6 +40,10 @@ _Avoid_: Daemon uptime, calibration window
The single SQLite database at `/var/lib/fenris/observations.db` that persists the observation history, monitoring periods, hour observations, day aggregates, and endurance baseline. The single SQLite database at `/var/lib/fenris/observations.db` that persists the observation history, monitoring periods, hour observations, day aggregates, and endurance baseline.
_Avoid_: Data directory, history.jsonl, the database (generic) _Avoid_: Data directory, history.jsonl, the database (generic)
**Pending publication**:
The condition where valid acquired observations are retained for recovery but their dependent evidence has not yet been published consistently. Those observations are not part of the reader-visible observation history until publication succeeds; readers retain the last consistent evidence with the pending condition made explicit.
_Avoid_: Successful collection, fresh published evidence
**Store fault**: **Store fault**:
The condition where the observation store is present but cannot be read or trusted — unreadable, corrupt, or written by a newer Fenris — degrading every view that depends on it rather than crashing or guessing. The condition where the observation store is present but cannot be read or trusted — unreadable, corrupt, or written by a newer Fenris — degrading every view that depends on it rather than crashing or guessing.
_Avoid_: Database error, corruption, broken data _Avoid_: Database error, corruption, broken data
@@ -40,6 +56,22 @@ _Avoid_: Hourly record, hourly.jsonl entry
One row per UTC day derived from hour observations; the grain at which usage-habit evidence is judged. One row per UTC day derived from hour observations; the grain at which usage-habit evidence is judged.
_Avoid_: Daily summary, daily stats _Avoid_: Daily summary, daily stats
**Local-day evidence**:
Measured read and write activity attributable to a local calendar day with its recorded timezone and midnight boundaries. Known volumes remain incomplete when gaps or shared local-day evidence prevent an exact total; they are not estimates of the missing activity.
_Avoid_: Estimated daily total, localised UTC day aggregate
**Shared local-day evidence**:
Measured read or write volume spanning a local midnight that cannot honestly be allocated to either adjacent day. It is retained once, separately from either day's known volume, rather than prorated or counted in both days.
_Avoid_: Missing bytes, estimated midnight split
**Activity selection**:
The read/write measurement, date and point being inspected in live or historical drive activity. Live activity follows the newest point until deliberate inspection pins a point; historical selection survives refresh, while an expired live pin is explained before following resumes.
_Avoid_: Projection window, current usage habit
**Activity readout**:
The ready-to-read account of an activity selection: measured read and write volume, thermal evidence, usage-habit split, coverage and drive warnings for the selected live interval, local hour or local day, expressed in local time with its timezone.
_Avoid_: Graph data, view model
**Usage-history window**: **Usage-history window**:
An exact consecutive span of UTC calendar days ending today, shown from day aggregates; a day without trustworthy evidence remains an explicit gap rather than disappearing or being estimated. An exact consecutive span of UTC calendar days ending today, shown from day aggregates; a day without trustworthy evidence remains an explicit gap rather than disappearing or being estimated.
_Avoid_: Available records, dataset range _Avoid_: Available records, dataset range
@@ -77,7 +109,7 @@ A sustained divergence between recent and earlier daily write rates that starts
_Avoid_: Spike, anomaly _Avoid_: Spike, anomaly
**Scenario range**: **Scenario range**:
The spread of lifespan projections computed from the 7-, 28-, and 90-day horizons of the observation history, shown in place of a statistical interval. The spread of lifespan projections computed from the horizons the observation history covers — 24-hour and 3-day horizons until a 7-day horizon exists, then 7-, 28-, and 90-day horizons — shown in place of a statistical interval.
_Avoid_: Confidence interval, error bar _Avoid_: Confidence interval, error bar
**Coverage**: **Coverage**:
+19 -7
View File
@@ -22,7 +22,7 @@ The Gitea instance Debian registry signs metadata with its own key. Verify the
instance key fingerprint (TOFU hardening): instance key fingerprint (TOFU hardening):
```text ```text
Fingerprint: <print after first release — paste beside the curl one-liner> Fingerprint: F937E81D2FB0736B15BC611884BEBD586DFAC010
``` ```
Add the instance key and repository: Add the instance key and repository:
@@ -257,8 +257,9 @@ is retried at the next interval; it never fabricates missing observations.
Preview uses synthetic observations, not measurements from a real drive. Preview uses synthetic observations, not measurements from a real drive.
The Chalktone dashboard opens with a large **Live** activity plot. **Day** shows The Chalktone dashboard opens with a large **Live** activity plot. **Day** shows
hourly evidence for a selected date, labelled UTC, and **History** shows daily hourly evidence for a selected date, and **History** shows daily evidence. Every
evidence. Local-day totals keep their recorded timezone. Dotted traces show time is local, labelled with its timezone, and the selected-point readout adds
a secondary UTC line. Local-day totals keep their recorded timezone. Dotted traces show
measured read/write volumes, not transfer speed; missing evidence breaks the measured read/write volumes, not transfer speed; missing evidence breaks the
trace. `?` marks a gap, `~` a partial total, and `u` unallocated daily volume. trace. `?` marks a gap, `~` a partial total, and `u` unallocated daily volume.
Use the selected-point readout for exact values and evidence state. Use the selected-point readout for exact values and evidence state.
@@ -270,16 +271,27 @@ shows incomplete or unavailable dates without treating them as zero. Older
UTC-only summaries cannot establish exact local-day totals. UTC-only summaries cannot establish exact local-day totals.
- `v` cycles Live / Day / History; the tabs are also clickable. - `v` cycles Live / Day / History; the tabs are also clickable.
- `←` / `→` inspect points; `w` switches read/write volume in every view. - `←` / `→` inspect points, `Home` / `End` jump to the first or last point, and
`PgUp` / `PgDn` jump a week in Day and History (the live window is three
hours); the mouse wheel moves the selection too. `w`
switches read/write volume in every view.
- `i` swaps the Drive pane for a Diagnostics panel built from the stored
evidence: the decoded `critical_warning`, power-on hours, power cycles,
unsafe shutdowns, media errors and available spare with their change over the
selection, and per-hour (Day) or per-day (History) temperature min/avg/max,
active / idle / powered-off / unknown split and coverage. History bars then
draw reads beside writes. A set `critical_warning` also shows as a badge in
the endurance outlook; it never changes the projection.
- `[` / `]` browse dates, `g` enters a date, and `t` returns to today/live. - `[` / `]` browse dates, `g` enters a date, and `t` returns to today/live.
- `Tab` / `Shift+Tab` move focus; `z` expands the focused panel, and `z` or - `Tab` / `Shift+Tab` move focus between panels (clicking a panel focuses it);
`Esc` restores it. Monitoring status and controls remain visible. `z` expands the focused panel, and `z` or `Esc` restores it. Monitoring status and controls remain visible.
- `s` cycles Chalktone, Amber, Nord, and High Contrast; saved theme preferences - `s` cycles Chalktone, Amber, Nord, and High Contrast; saved theme preferences
survive upgrades. `m` toggles reduced motion. survive upgrades. `m` toggles reduced motion.
On smaller terminals, textual summaries and scrollable panels keep evidence On smaller terminals, textual summaries and scrollable panels keep evidence
accessible. Pause, resume, collect, disclosures, help, and quit remain available accessible. Pause, resume, collect, disclosures, help, and quit remain available
in the fixed control row. in the fixed control row, which collapses to `? help · q quit` under 80×24. `?`
lists every key; the footer and help are generated from the same bindings.
Run `fenris` as your normal user to open the TUI dashboard. The dashboard does Run `fenris` as your normal user to open the TUI dashboard. The dashboard does
not need `sudo`. Use `sudo` for package installation and system configuration; not need `sudo`. Use `sudo` for package installation and system configuration;
@@ -0,0 +1,20 @@
# 11. Preserve valid unpublished observations without exposing partial history
Status: Accepted; implemented on `main` for the planned v0.6.0 release (commit `e22b994`).
A non-invariant derivation failure must not discard valid acquired observations or report a successful collection: retain the observations as pending publication in the existing observation store and retry through the normal scheduled collection path. Readers continue to see the last consistent published evidence, with an explicit pending-publication explanation, rather than combining newly acquired counters with older derived totals. This trades recovery bookkeeping for preservation of measured evidence and consistent read views; neither discarding every valid acquisition on derivation failure nor exposing partially derived history satisfies both requirements.
## Constraints
- The publication distinction applies to every dependent reader, including activity, freshness, controller-segment interpretation and projection inputs, not just the graph. ADR 0001's freshest-sample signal means the freshest published sample; an unpublished observation must not make published evidence appear fresh.
- Pending-work bookkeeping qualifies ADR 0005's recovery-without-new-state wording: it records unfinished evidence publication, not a new health grade or escalation mechanism. Last-collection outcomes still come from the existing native monitoring and logging paths.
- Invariant violations retain [ADR 0005](0005-failure-detection-and-recovery.md)'s write-nothing rule; retaining recoverable work is not permission to persist invalid observations. Actual store faults retain their existing refusal and degradation behavior.
- Recovery and retention remain collector-owned. Repeated recovery must not duplicate measured volume, and required source evidence cannot be pruned before trustworthy derived evidence is durable.
- This extends [ADR 0001](0001-observation-store-sqlite.md)'s consistent read model and [ADR 0010](0010-local-day-activity-history.md)'s preservation rule without another observation store, sampler, background process or retry cadence. Pending-work metadata is not a persisted projection or a replacement for journalled collection outcomes.
- Pending observations use private staging separate from published samples and derived evidence inside the same observation store. This makes exclusion from ordinary reader and projection queries structural, rather than requiring each query to remember a publication filter; the exact table layout remains an implementation detail.
## Bounded pending work
Pending publication has a fixed initial admission capacity of 6,720 observations, equivalent to 14 days at the default three-minute cadence. This is a count limit, not an expiry rule: older pending observations are never discarded merely to admit newer ones.
The collection module attempts recovery and checks capacity before invoking acquisition. If capacity remains exhausted, the collection is unsuccessful and visibly explains why no new observation was acquired; normal scheduled recovery attempts continue. This deliberately accepts a gap in new observations rather than unlimited pending growth or loss of already retained evidence. It is not a deliberate disable, changes no monitoring intent, and never permits fabricated activity across the gap.
@@ -0,0 +1,29 @@
# 12. Staged projection with an evidence ladder
Status: Accepted. Amends [ADR 0002](0002-projection-model-sustained-regime.md) §2, §6, §8 and §11, and [ADR 0003](0003-service-lifecycle-and-sanctioned-toggle.md) §4 and §8 for the TUI baseline entry.
## Context
Under ADR 0002 as implemented, a fresh install showed no usage-adjusted theoretical lifespan until a manual baseline existed and a complete local observation day had passed. Confidence then stayed Limited until two scenario horizons existed, about 28 days. Users read this as Fenris being slow and its confidence never moving. The architecture review of 2026-10-02 also found that the TUI and CLI each pre-gated the projection with rules the projection itself does not use.
## Decision
1. **Projection stages.** The projection reports one projection stage: no observations yet, provisional, warming, limited, supported, or unavailable. Provisional and warming add to ADR 0002's three confidence states, which remain the categorical judgement once warm-up ends. Callers render the stage. They never pre-gate.
2. **First number after 3 observed hours.** A provisional projection appears once at least 3 hours of hour observations with samples exist. Until 24 hours are observed, it carries the fact "daily cycle not yet seen". From 24 hours until ADR 0002's 14-qualifying-day warm-up completes, the stage is warming. The complete-local-day condition is a contributing fact, not a gate. The rate formula is unchanged; only the evidence span is shorter.
3. **Short horizons.** Until a 7-day horizon is covered, the scenario range uses 24-hour and 3-day horizons, each shown only once covered. They drop out when the 7-day horizon exists. The scenario range remains the only spread shown, and still no statistical interval appears.
4. **Horizon agreement over existing horizons.** As ADR 0002 §8 already says, agreement is judged across the horizons that exist. A single 7-day horizon passes, so Supported is reachable at 14 qualifying days when every other condition holds.
5. **Evidence ladder.** Each Supported condition from ADR 0002 §8 is reported as met or unmet with its reason. The headline shows a count of conditions met, and the outlook shows the full ladder. Confidence is never a percentage.
6. **Write rate without a baseline.** When no endurance baseline applies, the sustained-regime write rate is shown in place of a lifespan. No baseline is synthesized.
7. **TUI baseline entry.** The TUI offers an unverified-override entry: rated TBW plus an optional source URL. It is persisted through `fenris-monitor baseline set` under the existing polkit action. Verified overrides with full provenance stay CLI-only.
## Considered options
- **Numeric confidence percentage.** Rejected: it implies precision the evidence cannot support, and ADR 0002 §8 already rejected it.
- **Capacity-based default baseline.** Rejected: ADR 0002 dropped `capacity × 600`, and a fabricated baseline would mislabel the lifespan.
- **Keep the complete-local-day gate.** Rejected: it delays the first number by up to 34 hours while adding nothing the provisional label and spread do not already disclose.
## Consequences
- Early lifespans swing widely. The provisional label, the hours observed and the short-horizon spread carry that honestly.
- The projection module's interface becomes the single test surface for every gating rule.
- ADR 0002 §10's implied baseline still needs two Percentage Used increments. Entering a rated TBW remains the fast path to a lifespan.
+43 -42
View File
@@ -12,7 +12,7 @@ and destruction.
| UID | `Fenris Packaging <packaging@bongbetic.com>` | | UID | `Fenris Packaging <packaging@bongbetic.com>` |
| Expiry | 2 years from creation | | Expiry | 2 years from creation |
| Hierarchy | Single key — no master/subkey split (single maintainer, manual builds) | | Hierarchy | Single key — no master/subkey split (single maintainer, manual builds) |
| Private key storage | Password manager only | | Private key storage | Gitea repository Actions secret `GPG_PRIVATE_KEY` |
| Public key storage | `packaging/keys/fenris-packaging.asc` in-repo, release notes, docs | | Public key storage | `packaging/keys/fenris-packaging.asc` in-repo, release notes, docs |
| Keyservers | Never — TOFU-over-TLS via raw URL | | Keyservers | Never — TOFU-over-TLS via raw URL |
@@ -37,71 +37,72 @@ gpg --armor --export packaging@bongbetic.com > packaging/keys/fenris-packaging.a
gpg --fingerprint packaging@bongbetic.com gpg --fingerprint packaging@bongbetic.com
``` ```
Save the **private key** to the password manager immediately: Provision the **private key** as the repository Actions secret `GPG_PRIVATE_KEY`.
Run the export on the trusted key-generation machine, then enter its output in
the Gitea repository's Actions secret settings. Do not save it in the checkout,
logs, or a runner directory. The release workflow checks its fingerprint
against the committed public key before signing.
```bash ```bash
gpg --armor --export-secret-keys packaging@bongbetic.com gpg --armor --export-secret-keys packaging@bongbetic.com
``` ```
Then **delete the private key from the local keyring** — it must never persist After provisioning the secret, delete the private key from the key-generation
on any build host: keyring:
```bash ```bash
gpg --delete-secret-keys packaging@bongbetic.com gpg --batch --yes --delete-secret-keys packaging@bongbetic.com
gpg --delete-keys packaging@bongbetic.com gpg --batch --yes --delete-keys packaging@bongbetic.com
``` ```
The committed `fenris-packaging.asc` must contain the real public key (replace The committed `fenris-packaging.asc` must contain the real public key (replace
the placeholder comments). the placeholder comments).
## XBPS signing key
XBPS uses a separate RSA 3072 key. Its private half is stored as the Gitea
repository Actions secret `XBPS_SIGNING_KEY`. The corresponding public key is
published at
`https://git.bongbetic.com/xavierk/Fenris-xbps/raw/branch/stable/keys/fenris-xbps-signing.pub`,
with fingerprint `SHA256:AvPMRlKMikPg75u0iKr8AUkxlfU/Ad4k/S4o2M9W4/w`.
The secret must match that public key.
The release workflow writes the key to `~/.ssh/id_xbps` to sign the XBPS
package. A requested XBPS publication also uses the key to sign repository
metadata. A final `always()` cleanup removes the runner copy after publication
and release asset upload, including when an earlier step fails.
## Per-release signing flow ## Per-release signing flow
Each release performs: **import → sign → delete**. The private key is never Each tagged release performs: **import → verify → sign → delete** on the
stored on disk longer than the release takes. repository-scoped Gitea Actions runner. The Gitea secret remains configured;
the runner's keyring copy is removed after the job.
### Step 1: Import the private key ### Step 1: Push the release tag
Retrieve the private key from the password manager and import it: After updating the version and dated changelog section, push the matching tag:
```bash ```bash
gpg --import /tmp/packaging-key-private.asc git push origin v<version>
rm /f /tmp/packaging-key-private.asc # Shred if possible
``` ```
### Step 2: Build and sign packages ### Step 2: Build, verify, and sign packages
The Makefile target `make release` handles signing automatically when the The release workflow imports `GPG_PRIVATE_KEY`, checks it against
key is in the keyring: `packaging/keys/fenris-packaging.asc`, builds packages, signs the RPM and
clearsigned checksum manifest, validates both, and publishes the release. The
workflow imports `XBPS_SIGNING_KEY` separately and signs the XBPS package.
XBPS publication is optional and also signs repository metadata; it requires
host acceptance and explicit selection during workflow dispatch.
```bash ### Step 3: Verify runner cleanup
make release # builds, signs RPM, clearsigns SHA256SUMS, prints upload steps
```
Under the hood: The workflow's `always()` cleanup removes the GPG key from the runner's keyring
and deletes `~/.ssh/id_xbps`, including after a failed job. Confirm no signing
key remains on the runner after the release job.
1. `rpmsign --addsign` signs the RPM payload with the packaging key The Gitea Actions secret remains the approved signing source. Do not copy it to
(invoked by `make sign-rpm`). the runner or repository outside the workflow.
2. `sha256sum` generates the checksum manifest.
3. `gpg --clearsign` produces `SHA256SUMS.asc` with the packaging key.
### Step 3: Delete the private key
Immediately after signing:
```bash
gpg --delete-secret-keys packaging@bongbetic.com
gpg --delete-keys packaging@bongbetic.com
```
Verify the key is gone:
```bash
gpg --list-keys packaging@bongbetic.com
# Should produce: gpg: keyblock resource ...: No such file or directory
```
The entire import → sign → delete cycle should take minutes. The private key
must never be left in any keyring between releases.
## Key rotation (outline) ## Key rotation (outline)
+4 -3
View File
@@ -95,9 +95,10 @@ finance, email, or gallery features.
reference does not require squeezing its entire density into small terminals. reference does not require squeezing its entire density into small terminals.
These defaults implement the confirmed choices. Date entry and inspection These defaults implement the confirmed choices. Date entry and inspection
retain existing evidence precision: hourly/daily UTC evidence is labelled UTC, retain existing evidence precision: every time is shown in local time with its
while local-day totals keep their recorded timezone. This visual redesign does timezone label and a secondary UTC line on inspection, daily bars read
not manufacture finer or local-hour precision from coarse UTC evidence. local-day evidence, and local-day totals keep their recorded timezone. This
visual redesign does not manufacture finer precision than the evidence holds.
## Smallest sufficient implementation proof ## Smallest sufficient implementation proof
+117
View File
@@ -0,0 +1,117 @@
## Problem Statement
Fenris users cannot readily understand how much data their monitored drive reads and writes each day, inspect recent activity as it arrives, or select historical dates from the keyboard. Existing graph shortcuts depend on focus, date navigation is limited, collection and screen refresh default to five minutes, and the graph reads hourly/daily summaries rather than three-minute activity. Source inspection also identified derivation and rendering paths that can leave displayed history incomplete or stale despite newly stored readings.
Users want daily data volume as the primary measurement because writes contribute to drive endurance. They also want an understandable end-of-life outlook even with limited history, without presenting an unsupported hardware-failure prediction or a misleading numerical confidence score.
## Solution
Show both local-day read and write totals, updating from background collection targeted every three minutes. Open on a live last-three-hours graph of written data volume, provide a read/write toggle, and support selected-day and longer-history views. Make date navigation discoverable through visible keyboard hints and clickable equivalents.
Retain three-minute detail for 14 days, followed by durable hourly/daily summaries. Preserve the timezone and boundaries of historical local-day summaries, identify incomplete evidence, and never invent missing activity or divide midnight-spanning measurements by assumption.
Show the usage-adjusted theoretical lifespan after one full local calendar day of observations, provided an applicable endurance baseline and usable write rate exist. Explain that this estimates remaining write endurance if observed habits continue, not a physical failure date. Present categorical projection confidence with contributing facts, including limited-history reasons.
## User Stories
1. As a drive owner, I want to see the amount of data written each local day, so that I can understand the activity that contributes to write endurance.
2. As a drive owner, I want to see the amount of data read each local day, so that I can understand the drive's broader activity.
3. As a drive owner, I want read and write totals shown separately, so that reads are not mistaken for writes consuming the endurance allowance.
4. As a TUI user, I want data-volume units rather than transfer speed as the primary graph measurement, so that the graph answers how much data was transferred.
5. As a TUI user, I want today's totals labelled as totals so far, so that a partial day is not presented as a completed day's usage.
6. As a TUI user, I want the opening graph to show written volume over the last three hours, so that recent activity is visible immediately.
7. As a TUI user, I want to switch the graph between writes and reads while both daily totals remain visible, so that I can inspect either measurement without losing context.
8. As a TUI user, I want each new activity point to include transfers between readings, so that brief bursts between collection runs contribute to the graph.
9. As a TUI user, I want new measurements approximately every three minutes, so that the recent-activity view stays useful while I work.
10. As a user who closes the TUI, I want collection to continue in the background, so that reopening it shows activity gathered while I was away.
11. As a user who reboots, I want observation history and the established monitoring lifecycle preserved, so that restarting does not erase activity or confuse monitoring state.
12. As a keyboard user, I want `[` and `]` to select the previous and next day, so that browsing nearby dates takes one action.
13. As a keyboard user, I want `g` to open a date field, so that I can jump directly to a historical date.
14. As a keyboard user, I want `t` to return to today and the live view, so that I can leave historical browsing immediately.
15. As a keyboard user, I want arrows to inspect graph points, so that I can read the volume, time, and evidence state behind a point.
16. As a new TUI user, I want visible shortcut hints that work from normal launch, so that I do not have to discover an invisible graph-focus prerequisite.
17. As a mouse user, I want clickable equivalents for navigation and the read/write toggle, so that I can use the same features without memorizing shortcuts.
18. As a user entering a date, I want typing and cancelling to remain within the date-entry workflow, so that graph or monitoring shortcuts do not fire accidentally.
19. As a user browsing history, I want background refresh to preserve my selected date and measurement, so that new activity does not interrupt inspection.
20. As a user inspecting daily totals, I want to switch between recent detail, a selected day, and longer history, so that I can understand both short bursts and daily habits.
21. As a user outside UTC, I want calendar navigation and timestamps expressed in labelled local time, so that the displayed day matches my calendar.
22. As a user in a timezone with a half-hour offset, I want local-day totals based on the correct midnight boundary, so that relabelled UTC totals do not misrepresent my day.
23. As a user experiencing a daylight-saving transition, I want real local-day boundaries respected, so that a 23-hour or 25-hour day remains understandable.
24. As a user who changes system timezone, I want historical summaries to retain their recorded timezone and boundaries, so that old totals do not silently change meaning.
25. As a user reviewing recent history, I want three-minute detail available for 14 days, so that I can investigate recent usage.
26. As a user reviewing older history, I want durable hourly/daily summaries after detailed readings expire, so that long-term activity remains available.
27. As a user with legacy history, I want dates that cannot be reconstructed at local-day precision labelled incomplete or unavailable, so that old summaries are not presented with invented precision.
28. As a user whose readings straddle midnight, I want the measured volume preserved once and its uncertain day allocation explained, so that it is neither lost nor counted twice.
29. As a new user with only one reading, I want an awaiting-another-reading state, so that a missing interval is not shown as zero activity.
30. As a user with a measured zero-activity interval, I want zero distinguished from missing evidence, so that a quiet drive is not confused with a collection failure.
31. As a user with missed collection runs, I want gaps, actual timestamps, and freshness facts, so that the graph does not imply measurements that never occurred.
32. As a user who deliberately pauses monitoring, I want paused time excluded according to monitoring-period rules, so that the pause does not distort the observed usage habit.
33. As a user whose controller resets or changes, I want counter and identity boundaries respected, so that unrelated readings do not create invalid activity or lifespan estimates.
34. As a user with a store fault, I want a clear explanation instead of guessed history, so that I know which information cannot be trusted.
35. As a drive owner, I want an estimate of the time until remaining write endurance is consumed, so that I can plan around my observed usage habit.
36. As a new user, I want that estimate withheld until one full local calendar day has been observed, so that a few minutes of activity do not immediately produce a lifespan number.
37. As a user who starts monitoring at noon, I want the partial first day excluded from the full-day gate, so that 24 hours since launch is not mistaken for a complete calendar day.
38. As a user with one complete day but limited history, I want an estimate when the other inputs support it, so that I do not have to wait for high confidence before seeing an outlook.
39. As a user with limited evidence, I want a confidence category and concrete reasons, so that I understand why an estimate may change without being shown an unjustified percentage.
40. As a user without an applicable endurance baseline or usable write rate, I want the missing prerequisite explained, so that unavailable evidence is not disguised as merely low confidence.
41. As a drive owner, I want the endurance estimate distinguished from a physical failure date, so that I do not treat a write-endurance projection as a hardware guarantee.
42. As a CLI user, I want status and the TUI to agree on forecast eligibility and confidence, so that choosing a different interface does not change the facts.
43. As a user on a narrow terminal, I want daily totals, dates, evidence labels, and controls to remain accessible, so that terminal size does not hide the information I need.
44. As a user of existing themes and reduced-motion settings, I want those features preserved when navigation shortcuts change, so that better date controls do not remove accessibility or preferences.
45. As a user upgrading Fenris, I want migration, repair, refresh, and pruning to preserve measured evidence without duplication, so that the new graph can be trusted across restarts and upgrades.
## Implementation Decisions
- Extend the existing collector, observation store, derivation, shared status/projection, service scheduling, and TUI responsibilities. The privileged collector remains the single device-acquisition and store-write owner; the TUI remains an unprivileged reader. Do not add another sampler, service, export layer, or generic plotting abstraction.
- Set the default background collection target to three minutes on both systemd and runit. Update shared cadence/freshness semantics, scheduler definitions, user documentation, and relevant acceptance contracts together. Use actual observation timestamps: delayed runs must not be represented as perfectly spaced measurements or synthetic catch-up points.
- Derive interval read/write volumes from compatible cumulative counters. A first reading is an anchor, not an interval. Preserve controller-segment and monitoring-period boundaries, measured zero, unknown time, deliberate disables, and unsupported evidence. Do not compute deltas across a controller identity or counter discontinuity.
- Make successful collection publish consistent data for dependent read views, using the existing transactional and migration patterns. Ensure raw samples, affected summaries, and retained boundary evidence cannot disagree through partial publication. Validate source-level derivation gaps before implementing fixes; this spec does not claim a runtime diagnosis.
- Keep daily read and write totals separate. The write graph is the default; a read/write toggle changes only the displayed measurement. Each live point represents measured interval volume, not instantaneous speed. Daily totals remain visible independently of graph mode, and graph selection must not redefine the projection's evidence window.
- Open on the latest three hours. Offer selected-day and longer-history views at the precision supported by retained evidence. Selected-point readouts expose time, labelled timezone, data-volume units, and incomplete/gap state. Do not imply that a partial current day or an incompletely allocated day is a known full-day total.
- Use `[` / `]` for previous/next day, `g` for date entry, `t` for today/live, and arrows for point inspection, with visible hints and clickable equivalents. Date entry must handle invalid or unavailable dates visibly and must not leak keystrokes into unrelated actions. Cancelling returns to the prior selection; refresh preserves historical selection until the user changes it.
- Resolve the existing `t` theme binding in favor of the accepted today/live action. Preserve theme selection through a discoverable non-conflicting control and update help consistently. Preserve pause, resume, collect-now, disclosures, quit, and reduced-motion behavior; quitting still does not pause monitoring. No exact replacement theme shortcut was selected in the interview.
- Preserve UTC timestamps and the established UTC hour/day evidence used by endurance calculations. Local-day activity is a separate presentation aggregate using the actual local midnight boundaries, including non-whole-hour offsets and daylight-saving transitions. Timestamp relabelling alone is insufficient.
- Extend the existing versioned observation store to retain local-day read/write summaries with their controller identity/segment context, recorded timezone, local date, UTC boundaries, evidence state, and the information needed to explain unallocated boundary volume. These are required semantics, not prescribed table names or a finalized column layout. The collector derives durable summaries before source evidence is eligible for pruning.
- Retain three-minute detail for 14 days and hourly/daily summaries indefinitely. Keep the boundary evidence and anchors necessary for honest derivation. Do not introduce unbounded retention of all fine-grained intervals solely to support arbitrary historical timezone reinterpretation, and do not delete existing durable evidence merely to simplify migration.
- Preserve the timezone and boundaries recorded for historical summaries when the system timezone changes. New observations follow the current local timezone without rewriting old days; labels must make historical timezone context explicit. Do not blend differently bounded summaries into an apparently exact daily total.
- Allocate a measured interval to a local day only when evidence supports that allocation. Preserve an ambiguous midnight-spanning delta once as shared/unallocated boundary evidence; neither prorate it nor copy its full value into both days. If only coarse legacy UTC summaries survive, show them at their actual precision and mark unreconstructable local-day totals incomplete/unavailable. Repeated derivation and repair must be idempotent.
- Use the existing usage-adjusted theoretical lifespan model and categorical projection confidence. Forecast remaining write endurance from an applicable endurance baseline and a usable observed write rate. Lifetime-written counters consume the endurance allowance; observation-window deltas determine the usage rate. Read volume is not included in endurance consumption.
- Add the agreed complete-observation-day gate to the shared projection contract. A completed local midnight-to-midnight day within a monitoring period with usable evidence is required; a partial first day, deliberately disabled span, or day with no usable evidence cannot independently qualify. Monday-noon setup can first qualify at Wednesday 00:00 after observing Tuesday. Real daylight-saving day boundaries apply; do not replace this with a fixed 24-hour timer.
- Before that gate, explain that Fenris is waiting for a full local observation day. Afterward, allow an estimate with Limited confidence when the existing baseline, rate, identity, and evidence-validity rules permit it; preserve the longer warm-up and Supported-confidence requirements. Missing evidence is still evaluated under the existing validity/coverage rules: completing a date does not turn unknown measurements into known data.
- Show confidence as a category plus contributing facts, never a numeric confidence percentage. Explain missing baseline, unusable/zero rate, stale evidence, and controller changes through their applicable states. Do not fabricate a baseline, suppress a missing prerequisite behind a generic confidence warning, or label the output as a predicted hardware-failure date. Preserve the existing baseline setup path and zero-rate explanation.
- Preserve visible freshness, last-collection outcome, paused state, and store-fault behavior. On constrained terminals retain the existing textual fallback/reflow approach so both daily totals, the selected date, evidence state, confidence, and navigation remain accessible; colour alone must not carry meaning.
- Migrate through the existing ordered, versioned, transactional store mechanism. Preserve observation history, refuse unknown newer schemas, establish new durable evidence before pruning, and keep readers consistent while the collector writes. Migration cannot manufacture local precision from historical data that lacks it.
- This design amends ADR 0003's five-minute default on both native service backends under ADR 0008, adds a first-full-local-day eligibility gate to ADR 0002 while retaining its forecasting and confidence model, and extends ADR 0001 with the local-history decision recorded as ADR 0010. ADR 0005's no-fabrication/store-fault contract remains authoritative. Existing historical design documents are not evidence that the current runtime already implements these amendments.
## Testing Decisions
- Prefer one primary acceptance path: controlled acquisition fixtures and an injected clock enter the existing public collection operation; it writes a real temporary observation store; the normal read path supplies the TUI and CLI. Assert resulting displayed volumes, evidence states, selections, forecast eligibility, and public outcomes. Do not mock the internal derivation or query results under test. A good test would continue passing after an internal refactor and fail when a user's observed result becomes incorrect.
- Reuse existing collector tracer and collector-history tracer fixtures, including SMART JSON, a temporary sysfs tree, the injected clock, and a real SQLite store. Compose these with the existing status reader, projection fixtures, and headless TUI driver rather than creating a new production testing interface. Fix defects that this path reproduces; do not make tests reproduce incorrect implementation arithmetic.
- Exercise normal launch, previous/next date, direct date entry, invalid input, cancel, today/live, arrow inspection, read/write switching, refresh during historical browsing, and hourly/day navigation through user actions. Assert visible graph/readout results, not only private selection indices or row counts. In particular, do not manually force graph focus to make the advertised shortcuts work. Existing headless graph, help, theme, motion, and constrained-terminal tests provide prior art.
- Drive known successive read/write counter changes through collection and verify exact interval volumes and aggregate totals. Cover first reading, first compatible pair, measured zero, repeated collection, repeated read/refresh, restart, same-hour accumulation, and a day-boundary crossing. Preserve each measured byte once: attributable totals plus separately retained unallocated evidence must account for the measured delta without duplication.
- Use the same public path for local midnight, Asia/Kolkata's half-hour boundary, a 23-hour local day, a 25-hour local day, repeated local clock labels, and a system-timezone change. Verify historical labels and boundaries remain stable and ambiguous intervals are not silently divided. Add direct derivation cases only when they prove an invariant that the primary path cannot isolate clearly.
- Advance controlled time beyond the 14-day detail window, invoke normal pruning, restart readers, and verify recent detail expiry with durable summary/boundary preservation. Use existing pruning, repair, legacy-migration, and store-migration tests for focused persistence cases that the main path cannot prove, including interruption, reruns, concurrent readers, unknown newer schema, and inability to reconstruct legacy local-day precision.
- Test the forecast gate at concrete local times: Monday noon setup; Tuesday noon with 24 elapsed hours but no complete observed calendar day; and Wednesday 00:00 after a usable Tuesday. Include partial/disabled/unknown days and daylight-saving dates. After eligibility, verify Limited confidence with reasons and a correct estimate where inputs support one; no baseline, invalid counters, zero rate, stale evidence, and segment changes must preserve the relevant unavailable/degraded behavior. Reuse existing projection and status-parity tests.
- Independently calculate an expected endurance result from known lifetime-written counters, a known applicable baseline, and known observed-window deltas. This guards against confusing lifetime consumption with writes inside the rate window. Rendering, browsing another day, and switching to reads must not change that accounting.
- Add focused checks at the existing native scheduler boundary for the three-minute defaults, serialization, failures, and freshness calculations. Reuse systemd/runit control and packaging tests; use only necessary controlled platform probes to verify actual scheduled/background behavior. No live-system scheduling, pause, install, or reboot action is authorized merely by writing this spec. Report any unavailable platform verification during implementation.
- Verify at 80×24 and below that visible totals, date entry, navigation, confidence, and evidence states remain accessible and that theme/reduced-motion controls still work. Avoid pixel-perfect snapshots and assertions about private widget layout when visible text and action results express the contract.
- The affected modules are collection/derivation, observation-store migration and retention, shared projection/status, native service scheduling, and the TUI. Most acceptance coverage should remain at the single collection-to-visible-result path; targeted persistence and scheduler checks are supporting boundaries, not a new layer of test-only architecture.
## Out of Scope
- Adding SATA/HDD acquisition, another monitored device, or multi-drive management; the selected existing NVMe drive remains the source.
- Reporting occupied/free filesystem capacity, making transfer speed the primary measurement, or treating read bytes as write-endurance consumption.
- Forecasting today's final data volume or future daily activity; the selected forecast is the usage-adjusted theoretical lifespan.
- Predicting a physical hardware-failure date, adding numeric confidence percentages, fabricating endurance baselines, or introducing a new forecasting algorithm when the existing model fits.
- Interpolating missing samples, zero-filling unknown activity, prorating ambiguous midnight intervals, or retroactively rewriting historical timezone boundaries.
- Requiring all historical dates to retain three-minute detail forever or to support arbitrary later timezone regrouping.
- A new web UI, plotting service, generic graph framework, notifications, telemetry, theme redesign, or unrelated dashboard rework.
- Package publication, release creation, installation, host-monitoring changes, or runtime diagnosis of the user's deployed observation store as part of this specification task.
## Further Notes
- This spec synthesizes the completed design conversation. The user accepted daily volume, a live three-hour opening view, the specified keyboard date workflow, local dates, 14-day detail retention, a writes-first graph with read toggle and both totals, an endurance forecast, categorical confidence, one full local observation day before forecasting, and historically labelled timezone boundaries with honest incomplete evidence.
- Related prior issue: [Implement Fenris TUI polish and hourly history](https://git.bongbetic.com/xavierk/Fenris/issues/72). This newer accepted design supersedes its conflicting requirements for the opening graph, writes-only presentation, the `t` theme shortcut, unrestricted historical timezone regrouping, indefinite fine-grained interval retention, and the earlier projection-eligibility presentation. Preserve unrelated requirements for identity, status, themes, motion, accessibility, collector publication, evidence conservation, and CLI parity. Do not treat the older issue as a reason to undo these newly agreed choices.
- ADR 0010 records the deliberate trade-off: retain labelled local summaries and necessary boundary evidence before detailed readings expire, rather than retaining every fine-grained interval for arbitrary future timezone reinterpretation. The design adds durable local activity evidence while retaining UTC projection evidence and the existing collector/reader ownership boundary.
- Source inspection identified normal collection paths that do not consistently rebuild daily totals, existing-hour updates that omit read deltas, cross-day deltas added to both dates, and drill-down rendering overwritten by a loading placeholder. These are concrete investigation/regression targets, not claims of executed reproductions or deployed-store corruption.
- The user confirmed the existing collector-to-store-to-TUI/CLI test boundary, with focused migration/pruning and scheduler checks where needed. Publication is an implementation handoff; no application behavior or test result is claimed solely by creating this issue.
+4 -3
View File
@@ -44,7 +44,8 @@
- **RPM payload: signed.** rpmsign with the dedicated packaging key, invoked by `make sign-rpm` after the package is built. This is required, not optional: it is the only working dnf-native verification path. - **RPM payload: signed.** rpmsign with the dedicated packaging key, invoked by `make sign-rpm` after the package is built. This is required, not optional: it is the only working dnf-native verification path.
- **deb: unsigned.** apt never verifies payload signatures; trust = instance-signed `InRelease` (signed-by keyring) + TLS + Acquire-By-Hash. Manual-download integrity is covered by SHA256SUMS. - **deb: unsigned.** apt never verifies payload signatures; trust = instance-signed `InRelease` (signed-by keyring) + TLS + Acquire-By-Hash. Manual-download integrity is covered by SHA256SUMS.
- **SHA256SUMS: clearsigned** with the packaging key — the trust anchor for manually downloaded release assets, independent of TLS. - **SHA256SUMS: clearsigned** with the packaging key — the trust anchor for manually downloaded release assets, independent of TLS.
- **Packaging key:** single dedicated key, RSA 3072, UID `Fenris Packaging <packaging@bongbetic.com>`, 2-year expiry, no master/subkey hierarchy (single maintainer, manual builds). Private key lives in the password manager only; each release does import → sign → delete — nothing permanent on any build host. The full ceremony is documented in `docs/install/signing-key-ceremony.md`. - **Packaging key:** single dedicated key, RSA 3072, UID `Fenris Packaging <packaging@bongbetic.com>`, 2-year expiry, no master/subkey hierarchy. The private key is stored as the repository Actions secret `GPG_PRIVATE_KEY`. The release workflow imports it on the self-hosted runner, verifies it against the in-repo public key, signs the RPM and SHA256SUMS, then deletes the runner's keyring copy in an `always()` cleanup step. The full ceremony is documented in `docs/install/signing-key-ceremony.md`.
- **XBPS key:** separate RSA 3072 key stored as the repository Actions secret `XBPS_SIGNING_KEY`; its public key and fingerprint are published in `Fenris-xbps`. The release workflow uses it for the XBPS package and, when publication is explicitly requested, the repository index. A final `always()` cleanup deletes its runner copy after publication and release asset upload.
- **Public key publication:** in-repo `packaging/keys/fenris-packaging.asc` (raw URL doubles as the `.repo` gpgkey target), release notes, docs page. No keyservers — TOFU-over-TLS. - **Public key publication:** in-repo `packaging/keys/fenris-packaging.asc` (raw URL doubles as the `.repo` gpgkey target), release notes, docs page. No keyservers — TOFU-over-TLS.
- **Rotation (outline):** new key published alongside old; rpm signed with the new key; `fenris.repo` gpgkey lists both URLs (dnf accepts multiple); old key dropped after one release cycle. Procedure details stay in map fog. - **Rotation (outline):** new key published alongside old; rpm signed with the new key; `fenris.repo` gpgkey lists both URLs (dnf accepts multiple); old key dropped after one release cycle. Procedure details stay in map fog.
@@ -53,9 +54,9 @@
- **A Release is:** a version tag, its packages in the channel, a Gitea release entry with notes, and a clearsigned SHA256SUMS — all together. **Bare tags are forbidden** (tag without packages + release entry is not a Release). - **A Release is:** a version tag, its packages in the channel, a Gitea release entry with notes, and a clearsigned SHA256SUMS — all together. **Bare tags are forbidden** (tag without packages + release entry is not a Release).
- **Cadence: on-demand.** Tag when user-visible changes or fixes accumulate; no calendar, no empty releases, no frequency SLA, no RC ceremony — fixes ship as a revision bump of the current version. - **Cadence: on-demand.** Tag when user-visible changes or fixes accumulate; no calendar, no empty releases, no frequency SLA, no RC ceremony — fixes ship as a revision bump of the current version.
- **Versioning: plain semver.** Major = breaking CLI/config/unit change; store schema changes ride the natural bump (the forward-only refusal handles old-reader/new-store). - **Versioning: plain semver.** Major = breaking CLI/config/unit change; store schema changes ride the natural bump (the forward-only refusal handles old-reader/new-store).
- **Promotion flow:** tag → `make release` (automated: `make package` → RPM signing via nfpm → SHA256SUMS generation → clearsign → prints registry PUTs + Gitea release steps). The ceremony is documented in `docs/install/signing-key-ceremony.md`. - **Promotion flow:** bump `pyproject.toml` and the matching dated `CHANGELOG.md` section, then push tag `v<version>`. The repository-scoped Gitea Actions workflow builds and validates the deb, rpm, checksums, and release entry. XBPS publication remains a manual dispatch option after host acceptance. `make release` is for local artifact preparation and does not replace the tag workflow as the supported publication path. The ceremony is documented in `docs/install/signing-key-ceremony.md`.
- **Rollback:** installing an older package over a newer store is **unsupported** — the store's forward-only version refusal fails it by design. Documented rollback = restore the observation-store snapshot, then install the old Release. No automatic downgrade machinery exists or will be built. - **Rollback:** installing an older package over a newer store is **unsupported** — the store's forward-only version refusal fails it by design. Documented rollback = restore the observation-store snapshot, then install the old Release. No automatic downgrade machinery exists or will be built.
- **CI:** no runners are registered on the instance today ([Actions runner research](https://git.bongbetic.com/xavierk/Fenris/issues/37)), so the manual flow above is primary. A dormant `.gitea/workflows/release.yml` (`on: push: tags: ['v*']`, single job, host-mode runner) is committed alongside; if it fires, it replicates `make release`. Cheapest future upgrade: one `act_runner` static binary in host-label mode on the existing Gitea host. - **CI:** a repository-scoped self-hosted runner is registered and online (checked 2026-09-29). `.gitea/workflows/release.yml` is the tag-triggered release path; maintainers must confirm runner availability and required Gitea secrets before tagging. The workflow publishes deb/rpm packages and release assets; Void publication is withheld unless the signed XBPS host-release step is explicitly requested.
## 6. Package layout and ownership ## 6. Package layout and ownership
+5 -1
View File
@@ -1,6 +1,6 @@
[project] [project]
name = "fenris" name = "fenris"
version = "0.5.0" version = "0.7.0"
description = "NVMe wear monitor with persistent TUI" description = "NVMe wear monitor with persistent TUI"
requires-python = ">=3.10" requires-python = ">=3.10"
license = {file = "LICENSE"} license = {file = "LICENSE"}
@@ -13,8 +13,12 @@ dev = [
"pytest>=7.0.0", "pytest>=7.0.0",
"pytest-cov>=4.0.0", "pytest-cov>=4.0.0",
"pytest-asyncio>=0.20.0", "pytest-asyncio>=0.20.0",
"ruff==0.16.10",
] ]
[tool.ruff.lint]
select = ["E4", "E7", "E9", "F"]
[tool.pytest.ini_options] [tool.pytest.ini_options]
testpaths = ["tests"] testpaths = ["tests"]
python_files = ["test_*.py"] python_files = ["test_*.py"]
+35 -8
View File
@@ -21,13 +21,19 @@ class VolumePoint:
def volume_plot( def volume_plot(
points: Sequence[VolumePoint], width: int, height: int, points: Sequence[VolumePoint], width: int, height: int,
selected: int, colors: Mapping[str, str], selected: int, colors: Mapping[str, str],
secondary: Sequence[VolumePoint] | None = None,
) -> tuple[Text, list[int], str]: ) -> tuple[Text, list[int], str]:
"""Render bounded axes and a dotted trace, without resampling evidence.""" """Render bounded axes and a dotted trace, without resampling evidence.
*secondary* is a second series over the same time axis (reads beside
writes); it shares the volume scale and draws in its own colour.
"""
width, height = max(12, width), max(4, height) width, height = max(12, width), max(4, height)
axis_width = 8 axis_width = 8
columns, rows = width - axis_width, height - 2 columns, rows = width - axis_width, height - 2
pixel_width, pixel_height = columns * 2, rows * 4 pixel_width, pixel_height = columns * 2, rows * 4
maximum = max((p.volume or 0 for p in points), default=0) maximum = max(
(p.volume or 0 for p in (*points, *(secondary or ()))), default=0)
scale, unit = (1e12, "TB") if maximum >= 1e12 else ( scale, unit = (1e12, "TB") if maximum >= 1e12 else (
(1e9, "GB") if maximum >= 1e9 else (1e9, "GB") if maximum >= 1e9 else
(1e6, "MB") if maximum >= 1e6 else (1e6, "MB") if maximum >= 1e6 else
@@ -39,11 +45,16 @@ def volume_plot(
xs = [round((p.time - start) / span * (pixel_width - 1)) if span else 0 xs = [round((p.time - start) / span * (pixel_width - 1)) if span else 0
for p in points] for p in points]
cells = [[0] * columns for _ in range(rows)] cells = [[0] * columns for _ in range(rows)]
second = [[0] * columns for _ in range(rows)]
# Unicode braille dot numbering, indexed by y within cell and then x. # Unicode braille dot numbering, indexed by y within cell and then x.
bits = ((1, 8), (2, 16), (4, 32), (64, 128)) bits = ((1, 8), (2, 16), (4, 32), (64, 128))
def dot(x: int, y: int) -> None: def dot(x: int, y: int, grid: list[list[int]] = cells) -> None:
cells[y // 4][x // 2] |= bits[y % 4][x % 2] grid[y // 4][x // 2] |= bits[y % 4][x % 2]
def y_of(volume: int) -> int:
y = round((1 - volume / ceiling) * (pixel_height - 1))
return min(pixel_height - 1, max(0, y))
previous = None previous = None
markers = {} markers = {}
@@ -53,8 +64,7 @@ def volume_plot(
if point.state != "future": if point.state != "future":
markers[x // 2] = "?" markers[x // 2] = "?"
continue continue
y = round((1 - point.volume / ceiling) * (pixel_height - 1)) y = y_of(point.volume)
y = min(pixel_height - 1, max(0, y))
if previous is not None and point.state == "measured": if previous is not None and point.state == "measured":
px, py = previous px, py = previous
steps = max(abs(x - px), abs(y - py), 1) steps = max(abs(x - px), abs(y - py), 1)
@@ -68,6 +78,21 @@ def volume_plot(
elif point.volume == 0: elif point.volume == 0:
markers.setdefault(x // 2, "·") markers.setdefault(x // 2, "·")
previous = None
for point, x in zip(secondary or (), xs):
if point.volume is None:
previous = None
continue
y = y_of(point.volume)
if previous is not None and point.state == "measured":
px, py = previous
steps = max(abs(x - px), abs(y - py), 1)
for step in range(steps + 1):
dot(round(px + (x - px) * step / steps),
round(py + (y - py) * step / steps), second)
dot(x, y, second)
previous = (x, y) if point.state == "measured" else None
selected_column = xs[selected] // 2 if 0 <= selected < len(xs) else -1 selected_column = xs[selected] // 2 if 0 <= selected < len(xs) else -1
result = Text(no_wrap=True, overflow="crop") result = Text(no_wrap=True, overflow="crop")
ticks = {0, rows // 2, rows - 1} ticks = {0, rows // 2, rows - 1}
@@ -76,8 +101,10 @@ def volume_plot(
label = f"{value:6.2f}"[-6:] if row in ticks else " " label = f"{value:6.2f}"[-6:] if row in ticks else " "
result.append(label + " │", style=colors["muted"]) result.append(label + " │", style=colors["muted"])
for col, value in enumerate(values): for col, value in enumerate(values):
char = chr(0x2800 + value) if value else " " extra = second[row][col]
style = colors["allocated"] char = chr(0x2800 + (value | extra)) if value | extra else " "
style = colors["allocated"] if value or not extra else colors["secondary"]
value |= extra
if col == selected_column: if col == selected_column:
style = "bold " + colors["selection"] style = "bold " + colors["selection"]
if not value: if not value:
File diff suppressed because it is too large Load Diff
+8
View File
@@ -3,6 +3,8 @@ from collections.abc import Sequence
from dataclasses import dataclass from dataclasses import dataclass
HISTORY_RANGE_DEFAULT = 14 HISTORY_RANGE_DEFAULT = 14
HISTORY_RANGE_OPTIONS = (7, 14, 30, 90)
HISTORY_RANGE_MAX = max(HISTORY_RANGE_OPTIONS)
@dataclass(frozen=True) @dataclass(frozen=True)
@@ -33,6 +35,7 @@ class ActivitySelection:
self.selected_history_hour: str | None = None self.selected_history_hour: str | None = None
self.history_range_days = HISTORY_RANGE_DEFAULT self.history_range_days = HISTORY_RANGE_DEFAULT
self.measure = "written" self.measure = "written"
self.diagnostics = False
self.following_live = True self.following_live = True
self.selected_live_interval: IntervalIdentity | None = None self.selected_live_interval: IntervalIdentity | None = None
self.live_interval_expired = False self.live_interval_expired = False
@@ -72,6 +75,11 @@ class ActivitySelection:
self.measure = "read" if self.measure == "written" else "written" self.measure = "read" if self.measure == "written" else "written"
return self.measure return self.measure
def toggle_diagnostics(self) -> bool:
"""Show or hide the Diagnostics panel and read-beside-write bars."""
self.diagnostics = not self.diagnostics
return self.diagnostics
def follow_live(self) -> None: def follow_live(self) -> None:
"""Resume following the newest interval and clear stale-pin notices.""" """Resume following the newest interval and clear stale-pin notices."""
self.view = "live" self.view = "live"
+1 -1
View File
@@ -27,7 +27,7 @@ if VENV_DIR.exists():
if site_packages: if site_packages:
sys.path.insert(0, str(site_packages)) sys.path.insert(0, str(site_packages))
from fenris.collector import run_collection from fenris.collector import run_collection # noqa: E402 -- must follow the sys.path bootstrap above
CONFIG_PATH = Path("/etc/fenris/fenris.conf") CONFIG_PATH = Path("/etc/fenris/fenris.conf")
+11 -4
View File
@@ -19,7 +19,7 @@ from typing import Any, Dict, Optional
from .derive import derive_hours_from_interval, find_previous_sample from .derive import derive_hours_from_interval, find_previous_sample
from .monitoring_periods import ensure_period_open from .monitoring_periods import ensure_period_open
from .store import init_store, get_store_path from .store import DIAGNOSTIC_SAMPLE_COLUMNS, init_store, get_store_path
class AcquisitionError(Exception): class AcquisitionError(Exception):
@@ -103,6 +103,8 @@ def acquire_from_smartctl(smartctl_data: Dict[str, Any]) -> Dict[str, Any]:
"bytes_written": log["data_units_written"] * 512000, "bytes_written": log["data_units_written"] * 512000,
"bytes_read": log["data_units_read"] * 512000, "bytes_read": log["data_units_read"] * 512000,
"critical_warning": log.get("critical_warning", 0), "critical_warning": log.get("critical_warning", 0),
# Diagnostic counters (issue #111); absent keys stay None, never zero.
**{column: log.get(column) for column in DIAGNOSTIC_SAMPLE_COLUMNS},
} }
@@ -252,6 +254,7 @@ def write_sample(
segment_id = current_segment["id"] if current_segment else None segment_id = current_segment["id"] if current_segment else None
# Insert sample with segment_id # Insert sample with segment_id
# nosemgrep: python.sqlalchemy.security.sqlalchemy-execute-raw-query.sqlalchemy-execute-raw-query -- columns come from module constants, values are bound
cursor = conn.execute( cursor = conn.execute(
""" """
INSERT INTO samples ( INSERT INTO samples (
@@ -259,9 +262,10 @@ def write_sample(
percentage_used, available_spare, media_errors, power_on_hours, percentage_used, available_spare, media_errors, power_on_hours,
power_cycles, unsafe_shutdowns, temperature_c, power_cycles, unsafe_shutdowns, temperature_c,
data_units_written, data_units_read, bytes_written, bytes_read, data_units_written, data_units_read, bytes_written, bytes_read,
critical_warning, segment_id, local_tz critical_warning, segment_id, local_tz, %s
) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, %s)
""", """ % (", ".join(DIAGNOSTIC_SAMPLE_COLUMNS),
", ".join("?" * len(DIAGNOSTIC_SAMPLE_COLUMNS))),
( (
sample["ts"], sample["ts"],
sample["device"], sample["device"],
@@ -284,6 +288,8 @@ def write_sample(
sample["critical_warning"], sample["critical_warning"],
segment_id, segment_id,
sample.get("local_tz"), sample.get("local_tz"),
# Samples staged by an earlier version lack these keys.
*(sample.get(column) for column in DIAGNOSTIC_SAMPLE_COLUMNS),
), ),
) )
@@ -382,6 +388,7 @@ def _stage_observation(
separators=(",", ":"), separators=(",", ":"),
sort_keys=True, sort_keys=True,
) )
# nosemgrep: python.sqlalchemy.security.sqlalchemy-execute-raw-query.sqlalchemy-execute-raw-query -- columns come from module constants, values are bound
cursor = conn.execute( cursor = conn.execute(
"INSERT INTO pending_publications (sample_ts, payload) VALUES (?, ?)", "INSERT INTO pending_publications (sample_ts, payload) VALUES (?, ?)",
(sample["ts"], payload), (sample["ts"], payload),
+1 -1
View File
@@ -9,7 +9,7 @@ usage-habit classification is known rather than unknown (§5.3).
""" """
import sqlite3 import sqlite3
from dataclasses import dataclass from dataclasses import dataclass
from datetime import datetime, timedelta, timezone from datetime import datetime, timedelta
@dataclass(frozen=True) @dataclass(frozen=True)
+1 -1
View File
@@ -12,7 +12,7 @@ No proportional allocation, endpoint assignment, or double counting.
""" """
import sqlite3 import sqlite3
from datetime import datetime, timedelta, timezone from datetime import datetime, timedelta, timezone
from typing import Any, Dict, List, Optional, Tuple from typing import Any, Dict, List, Optional
from .hour_classify import classify_hour, HourSplit from .hour_classify import classify_hour, HourSplit
-1
View File
@@ -26,7 +26,6 @@ Runit guarantees:
Spec: §8.4, §8.5, §8.6, §8.7, §8.8, ADR 0008 Spec: §8.4, §8.5, §8.6, §8.7, §8.8, ADR 0008
""" """
import os import os
import shutil
import subprocess import subprocess
import sys import sys
from enum import Enum from enum import Enum
+2 -3
View File
@@ -18,11 +18,10 @@ import logging
import sqlite3 import sqlite3
from datetime import datetime, timezone from datetime import datetime, timezone
from pathlib import Path from pathlib import Path
from typing import Any, Dict, List, Optional, Tuple from typing import Any, Dict, List, Optional
from .hour_classify import classify_hour from .hour_classify import classify_hour
from .segment import open_segment, normalize_identity from .segment import open_segment
from .monitoring_periods import close_period
logger = logging.getLogger(__name__) logger = logging.getLogger(__name__)
+24 -33
View File
@@ -33,6 +33,11 @@ from itertools import pairwise
from typing import Any from typing import Any
from zoneinfo import ZoneInfo from zoneinfo import ZoneInfo
from .monitoring_periods import (
as_utc_datetime,
interval_within_one_monitoring_period,
)
@dataclass(frozen=True) @dataclass(frozen=True)
class LocalDaySummary: class LocalDaySummary:
@@ -308,27 +313,13 @@ def persist_local_day(
return created return created
def _utc_datetime(value: str | datetime) -> datetime:
parsed = value if isinstance(value, datetime) else datetime.fromisoformat(value)
if parsed.tzinfo is None:
parsed = parsed.replace(tzinfo=timezone.utc)
return parsed.astimezone(timezone.utc)
def _same_monitoring_period( def _same_monitoring_period(
conn: sqlite3.Connection, conn: sqlite3.Connection,
start: datetime, start: datetime,
end: datetime, end: datetime,
) -> bool: ) -> bool:
"""Return whether one recorded monitoring period contains the interval.""" """Return whether one recorded monitoring period contains the interval."""
for started_at, ended_at in conn.execute( return interval_within_one_monitoring_period(conn, start, end)
"SELECT started_at, ended_at FROM monitoring_periods"
):
period_start = _utc_datetime(started_at)
period_end = _utc_datetime(ended_at) if ended_at else None
if period_start <= start and (period_end is None or end <= period_end):
return True
return False
def repair_legacy_local_day_evidence(conn: sqlite3.Connection) -> int: def repair_legacy_local_day_evidence(conn: sqlite3.Connection) -> int:
@@ -365,13 +356,13 @@ def repair_legacy_local_day_evidence(conn: sqlite3.Connection) -> int:
segment_windows = {} segment_windows = {}
if {"monitoring_periods", "controller_segments"}.issubset(tables): if {"monitoring_periods", "controller_segments"}.issubset(tables):
periods = [ periods = [
(_utc_datetime(start), _utc_datetime(end) if end else None) (as_utc_datetime(start), as_utc_datetime(end) if end else None)
for start, end in conn.execute( for start, end in conn.execute(
"SELECT started_at, ended_at FROM monitoring_periods" "SELECT started_at, ended_at FROM monitoring_periods"
) )
] ]
segment_boundaries = [ segment_boundaries = [
(segment_id, _utc_datetime(opened_at)) (segment_id, as_utc_datetime(opened_at))
for segment_id, opened_at in conn.execute( for segment_id, opened_at in conn.execute(
"SELECT id, opened_at FROM controller_segments ORDER BY opened_at, id" "SELECT id, opened_at FROM controller_segments ORDER BY opened_at, id"
) )
@@ -399,11 +390,11 @@ def repair_legacy_local_day_evidence(conn: sqlite3.Connection) -> int:
) )
samples = [ samples = [
{ {
"id": row[0], "ts": _utc_datetime(row[1]), "id": row[0], "ts": as_utc_datetime(row[1]),
"bytes_written": row[2], "bytes_read": row[3], "bytes_written": row[2], "bytes_read": row[3],
"segment_id": row[4], "local_tz": row[5], "segment_id": row[4], "local_tz": row[5],
} }
for row in conn.execute(sample_select) for row in conn.execute(sample_select) # nosemgrep: sqlalchemy-execute-raw-query -- query text is built from constant fragments only; no external input
] ]
for previous, current in pairwise(samples): for previous, current in pairwise(samples):
start = previous["ts"] start = previous["ts"]
@@ -453,8 +444,8 @@ def repair_legacy_local_day_evidence(conn: sqlite3.Connection) -> int:
"id": row[0], "id": row[0],
"local_date": row[1], "local_date": row[1],
"tz_name": row[2], "tz_name": row[2],
"start": _utc_datetime(row[3]), "start": as_utc_datetime(row[3]),
"end": _utc_datetime(row[4]), "end": as_utc_datetime(row[4]),
"precision": row[6], "precision": row[6],
} }
for row in recorded_days for row in recorded_days
@@ -482,8 +473,8 @@ def repair_legacy_local_day_evidence(conn: sqlite3.Connection) -> int:
local_day_id, local_date, tz_name, utc_start, utc_end, local_day_id, local_date, tz_name, utc_start, utc_end,
prior_incomplete, prior_incomplete,
) = row ) = row
start = _utc_datetime(utc_start) start = as_utc_datetime(utc_start)
end = _utc_datetime(utc_end) end = as_utc_datetime(utc_end)
matching = matching_by_day[local_day_id] matching = matching_by_day[local_day_id]
if not matching: if not matching:
@@ -595,8 +586,8 @@ def _record_reconstructed_shared_intervals(
day_rows = [ day_rows = [
{ {
"id": row[0], "local_date": row[1], "tz_name": row[2], "id": row[0], "local_date": row[1], "tz_name": row[2],
"utc_start": _utc_datetime(row[3]), "utc_start": as_utc_datetime(row[3]),
"utc_end": _utc_datetime(row[4]), "utc_end": as_utc_datetime(row[4]),
"precision": row[6], "precision": row[6],
} }
for row in recorded_days for row in recorded_days
@@ -685,7 +676,7 @@ def _coarse_local_day_activity(
full_hours: dict[datetime, tuple] = {} full_hours: dict[datetime, tuple] = {}
boundary_hour_found = False boundary_hour_found = False
other_day_bounds = [ other_day_bounds = [
(_utc_datetime(row[0]), _utc_datetime(row[1])) (as_utc_datetime(row[0]), as_utc_datetime(row[1]))
for row in conn.execute( for row in conn.execute(
"SELECT utc_start, utc_end FROM local_days WHERE id != ?", "SELECT utc_start, utc_end FROM local_days WHERE id != ?",
(local_day_id,), (local_day_id,),
@@ -698,7 +689,7 @@ def _coarse_local_day_activity(
"FROM hour_observations WHERE hour >= ? AND hour < ? ORDER BY hour", "FROM hour_observations WHERE hour >= ? AND hour < ? ORDER BY hour",
(first_hour.isoformat(), day_end.isoformat()), (first_hour.isoformat(), day_end.isoformat()),
): ):
hour_start = _utc_datetime(row[0]) hour_start = as_utc_datetime(row[0])
hour_end = hour_start + hour hour_end = hour_start + hour
if hour_start >= day_end or hour_end <= day_start: if hour_start >= day_end or hour_end <= day_start:
continue continue
@@ -856,8 +847,8 @@ def record_local_activity_interval(
both samples share one monitoring period, and the interval stays inside one both samples share one monitoring period, and the interval stays inside one
recorded local date. Every other valid difference remains one unallocated row. recorded local date. Every other valid difference remains one unallocated row.
""" """
start = _utc_datetime(previous["ts"]) start = as_utc_datetime(previous["ts"])
end = _utc_datetime(current["ts"]) end = as_utc_datetime(current["ts"])
if end <= start: if end <= start:
return None return None
@@ -1004,12 +995,12 @@ def mark_local_activity_gap(
previous: dict | None = None, previous: dict | None = None,
) -> None: ) -> None:
"""Mark dates around a controller boundary as missing local activity.""" """Mark dates around a controller boundary as missing local activity."""
current = _utc_datetime(current_ts) current = as_utc_datetime(current_ts)
current_date = current.astimezone(ZoneInfo(current_tz)).date().isoformat() current_date = current.astimezone(ZoneInfo(current_tz)).date().isoformat()
_upsert_activity_day(conn, current_date, current_tz, incomplete=True) _upsert_activity_day(conn, current_date, current_tz, incomplete=True)
if previous is None or not previous.get("local_tz"): if previous is None or not previous.get("local_tz"):
return return
previous_at = _utc_datetime(previous["ts"]) previous_at = as_utc_datetime(previous["ts"])
previous_tz = previous["local_tz"] previous_tz = previous["local_tz"]
previous_date = previous_at.astimezone(ZoneInfo(previous_tz)).date().isoformat() previous_date = previous_at.astimezone(ZoneInfo(previous_tz)).date().isoformat()
_upsert_activity_day(conn, previous_date, previous_tz, incomplete=True) _upsert_activity_day(conn, previous_date, previous_tz, incomplete=True)
@@ -1027,7 +1018,7 @@ def query_local_day_summary(
""" """
tz_filter = " AND tz_name = ?" if tz_name else "" tz_filter = " AND tz_name = ?" if tz_name else ""
params = (local_date, tz_name) if tz_name else (local_date,) params = (local_date, tz_name) if tz_name else (local_date,)
row = conn.execute( row = conn.execute( # nosemgrep: sqlalchemy-execute-raw-query -- only constant fragments are concatenated; values are bound via ? placeholders
"SELECT local_date, tz_name, tz_offset, utc_start, utc_end, " "SELECT local_date, tz_name, tz_offset, utc_start, utc_end, "
" bytes_written, bytes_read, coverage, sample_count, complete, " " bytes_written, bytes_read, coverage, sample_count, complete, "
" activity_seconds, activity_intervals, activity_incomplete, " " activity_seconds, activity_intervals, activity_incomplete, "
@@ -1127,7 +1118,7 @@ def query_local_day_summary(
== recorded_date == recorded_date
) )
day_seconds = int( day_seconds = int(
(_utc_datetime(utc_end) - _utc_datetime(utc_start)).total_seconds() (as_utc_datetime(utc_end) - as_utc_datetime(utc_start)).total_seconds()
) )
interval_seconds = activity_seconds or 0 interval_seconds = activity_seconds or 0
full_activity_day = interval_seconds >= day_seconds or ( full_activity_day = interval_seconds >= day_seconds or (
+5 -4
View File
@@ -31,13 +31,14 @@ if VENV_DIR.exists():
if site_packages: if site_packages:
sys.path.insert(0, str(site_packages)) sys.path.insert(0, str(site_packages))
from fenris.store import init_store, get_store_path from fenris.store import init_store # noqa: E402 -- must follow the sys.path bootstrap above
from fenris.monitoring_periods import ( from fenris.timefmt import local_timestamp, local_zone_name # noqa: E402 -- sys.path bootstrap above
from fenris.monitoring_periods import ( # noqa: E402 -- sys.path bootstrap above
ensure_period_open, ensure_period_open,
close_period, close_period,
get_open_period, get_open_period,
) )
from fenris.init_system import ( from fenris.init_system import ( # noqa: E402 -- sys.path bootstrap above
enable_timer, enable_timer,
disable_timer, disable_timer,
collect_now, collect_now,
@@ -70,7 +71,7 @@ def cmd_enable(args: argparse.Namespace) -> None:
if open_period is None: if open_period is None:
ensure_period_open(conn, now) ensure_period_open(conn, now)
conn.commit() conn.commit()
print("Monitoring period opened at", now.isoformat()) print("Monitoring period opened at", local_timestamp(now, local_zone_name()))
else: else:
print("Monitoring period already open (id=%d)" % open_period["id"]) print("Monitoring period already open (id=%d)" % open_period["id"])
+41 -1
View File
@@ -9,7 +9,7 @@ Key contracts:
- End causes: user_disabled, migrated, unknown_gap - End causes: user_disabled, migrated, unknown_gap
""" """
import sqlite3 import sqlite3
from datetime import datetime from datetime import datetime, timezone
def ensure_period_open(conn: sqlite3.Connection, run_time: datetime) -> None: def ensure_period_open(conn: sqlite3.Connection, run_time: datetime) -> None:
@@ -82,6 +82,46 @@ def is_inside_period(conn: sqlite3.Connection, ts: datetime) -> bool:
return cursor.fetchone() is not None return cursor.fetchone() is not None
def interval_within_one_monitoring_period(
conn: sqlite3.Connection,
start: str | datetime,
end: str | datetime,
) -> bool:
"""Return whether one monitoring period contains the full interval.
Compare timestamps as UTC instants. Malformed timestamps fail closed.
"""
try:
interval_start = as_utc_datetime(start)
interval_end = as_utc_datetime(end)
except (TypeError, ValueError, OverflowError):
return False
if interval_end <= interval_start:
return False
for started_at, ended_at in conn.execute(
"SELECT started_at, ended_at FROM monitoring_periods"
):
try:
period_start = as_utc_datetime(started_at)
period_end = as_utc_datetime(ended_at) if ended_at is not None else None
except (TypeError, ValueError, OverflowError):
continue
if period_start <= interval_start and (
period_end is None or interval_end <= period_end
):
return True
return False
def as_utc_datetime(value: str | datetime) -> datetime:
"""Parse a timestamp and normalize it to an aware UTC datetime."""
parsed = value if isinstance(value, datetime) else datetime.fromisoformat(value)
if parsed.tzinfo is None:
parsed = parsed.replace(tzinfo=timezone.utc)
return parsed.astimezone(timezone.utc)
def wall_clock_in_periods( def wall_clock_in_periods(
conn: sqlite3.Connection, conn: sqlite3.Connection,
start: datetime, start: datetime,
+261 -121
View File
@@ -20,20 +20,29 @@ Arithmetic (§6.3):
E_rated = entered_TBW × 10¹² bytes E_rated = entered_TBW × 10¹² bytes
E_implied = 100 · W_t / p (1 ≤ p ≤ 254) E_implied = 100 · W_t / p (1 ≤ p ≤ 254)
Staging (ADR 0012): the result carries a projection stage, the evidence
ladder (each Supported condition met or unmet with its reason) and the
sustained-regime write rate, so callers render the stage and never
pre-gate the projection themselves.
Criteria: PR-1–PR-17, CI-4. Criteria: PR-1–PR-17, CI-4.
""" """
import sqlite3 import sqlite3
from dataclasses import dataclass, field from dataclasses import dataclass, field
from datetime import datetime, timedelta, timezone from datetime import datetime, timedelta
from enum import Enum from enum import Enum
from typing import Any, Dict, List, Optional, Tuple from typing import Any, Dict, List, Optional
from .monitoring_periods import interval_within_one_monitoring_period
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
# Constants (spec §6) # Constants (spec §6)
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
HORIZON_DAYS = (7, 28, 90) HORIZON_DAYS = (7, 28, 90)
SHORT_HORIZON_DAYS = (1, 3)
PROVISIONAL_MIN_HOURS = 3
DAILY_CYCLE_HOURS = 24
TBW_TO_BYTES = 10 ** 12 TBW_TO_BYTES = 10 ** 12
IMPLIED_P_MIN = 1 IMPLIED_P_MIN = 1
IMPLIED_P_MAX = 254 IMPLIED_P_MAX = 254
@@ -61,6 +70,15 @@ class ConfidenceState(Enum):
SUPPORTED = "Supported" SUPPORTED = "Supported"
class ProjectionStage(Enum):
NO_OBSERVATIONS = "No observations yet"
PROVISIONAL = "Provisional"
WARMING = "Warming"
LIMITED = "Limited"
SUPPORTED = "Supported"
UNAVAILABLE = "Unavailable"
class BaselineTier(Enum): class BaselineTier(Enum):
VERIFIED = "verified_override" VERIFIED = "verified_override"
UNVERIFIED = "unverified_override" UNVERIFIED = "unverified_override"
@@ -76,6 +94,14 @@ class ScenarioRange:
horizon_reasons: Dict[int, str] = field(default_factory=dict) horizon_reasons: Dict[int, str] = field(default_factory=dict)
@dataclass(frozen=True)
class LadderCondition:
"""One Supported condition from ADR 0002 §8, met or unmet with its reason."""
name: str
met: bool
reason: str
@dataclass(frozen=True) @dataclass(frozen=True)
class ProjectionResult: class ProjectionResult:
confidence_state: ConfidenceState confidence_state: ConfidenceState
@@ -93,6 +119,25 @@ class ProjectionResult:
degraded_identity_fact: Optional[str] degraded_identity_fact: Optional[str]
zero_rate_fact: Optional[str] zero_rate_fact: Optional[str]
qualifying_days_progress: Optional[str] = None # Issue #77: honest qualifying-day progress qualifying_days_progress: Optional[str] = None # Issue #77: honest qualifying-day progress
stage: ProjectionStage = ProjectionStage.NO_OBSERVATIONS
evidence_ladder: List[LadderCondition] = field(default_factory=list)
write_rate: Optional[float] = None # sustained-regime rate, bytes per second
hours_observed: int = 0
@property
def stage_label(self) -> str:
"""Display wording; observations that are too few are not "none"."""
if self.stage == ProjectionStage.NO_OBSERVATIONS and self.hours_observed > 0:
return "Collecting observations"
return self.stage.value
@property
def ladder_met(self) -> int:
return sum(1 for c in self.evidence_ladder if c.met)
@property
def ladder_total(self) -> int:
return len(self.evidence_ladder)
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
@@ -149,16 +194,40 @@ def _get_all_days(conn):
for r in cursor.fetchall()] for r in cursor.fetchall()]
def _get_latest_published_sample(conn, segment_id):
"""Newest published sample in the segment: (lifetime bytes written, PU).
W_t is the lifetime counter, not a regime delta. Pending staging lives
in a separate table (ADR 0011), so only published samples are seen here.
bytes_written is DUW x 512000 as stored by the collector; fall back to
that conversion if only the raw counter is present.
"""
if segment_id is not None:
cursor = conn.execute(
"SELECT COALESCE(bytes_written, data_units_written * 512000), percentage_used "
"FROM samples WHERE segment_id = ? ORDER BY id DESC LIMIT 1",
(segment_id,),
)
else:
cursor = conn.execute(
"SELECT COALESCE(bytes_written, data_units_written * 512000), percentage_used "
"FROM samples ORDER BY id DESC LIMIT 1"
)
row = cursor.fetchone()
return (row[0], row[1]) if row else (None, None)
def _get_latest_pu(conn): def _get_latest_pu(conn):
cursor = conn.execute("SELECT percentage_used FROM samples ORDER BY id DESC LIMIT 1") cursor = conn.execute("SELECT percentage_used FROM samples ORDER BY id DESC LIMIT 1")
row = cursor.fetchone() row = cursor.fetchone()
return row[0] if row else None return row[0] if row else None
def _get_pu_increments_in_segment(conn, segment_opened_at): def _get_pu_increments_in_segment(conn, segment_id):
cursor = conn.execute( cursor = conn.execute(
"SELECT COUNT(DISTINCT percentage_used) FROM samples WHERE ts >= ?", "SELECT COUNT(DISTINCT percentage_used) FROM samples "
(segment_opened_at,), "WHERE segment_id = ? AND percentage_used IS NOT NULL",
(segment_id,),
) )
row = cursor.fetchone() row = cursor.fetchone()
return max(0, (row[0] if row else 0) - 1) return max(0, (row[0] if row else 0) - 1)
@@ -181,15 +250,50 @@ def _wall_clock_in_range(conn, start, end):
return total return total
def _get_hours_observed(conn, segment_opened_at, days):
"""Hours of sampled evidence in the current segment.
Counted from hour observations. A day aggregate without any hour rows
(imported or pruned history) stands for a whole observed day.
"""
hour_floor = segment_opened_at[:13] if segment_opened_at else ""
cursor = conn.execute(
"SELECT substr(hour, 1, 10), COUNT(*) FROM hour_observations "
"WHERE sample_count > 0 AND hour >= ? GROUP BY 1",
(hour_floor,),
)
by_day = dict(cursor.fetchall())
total = 0
for d in days:
if d["day"] in by_day:
total += by_day.pop(d["day"])
elif d["sample_count"] > 0:
total += DAILY_CYCLE_HOURS
return total + sum(by_day.values())
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
# Baseline resolution (§6.1, §6.2) # Baseline resolution (§6.1, §6.2)
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
def _resolve_implied_baseline(conn, current_segment, facts):
"""No override exists: Percentage-Used-implied tier, or unavailable (§10)."""
if current_segment is not None:
_, p = _get_latest_published_sample(conn, current_segment["id"])
increments = _get_pu_increments_in_segment(conn, current_segment["id"])
if (increments >= IMPLIED_MIN_PU_INCREMENTS and p is not None
and IMPLIED_P_MIN <= p <= IMPLIED_P_MAX):
return (BaselineTier.IMPLIED, None,
"implied from vendor wear (%d%% used) — coarse" % p, facts)
facts.append("vendor wear estimate too coarse to imply endurance")
return BaselineTier.NONE, None, "no baseline", facts
def _resolve_baseline(conn, current_segment): def _resolve_baseline(conn, current_segment):
baseline = _get_baseline(conn) baseline = _get_baseline(conn)
facts: list[str] = [] facts: list[str] = []
if baseline is None: if baseline is None:
return BaselineTier.NONE, None, "no baseline", facts return _resolve_implied_baseline(conn, current_segment, facts)
mandatory = [baseline["source_url"], baseline["document_revision"], mandatory = [baseline["source_url"], baseline["document_revision"],
baseline["entry_date"], baseline["model_string"], baseline["entry_date"], baseline["model_string"],
@@ -340,84 +444,88 @@ def _detect_habit_change(days):
# Confidence rule table (§6.7) # Confidence rule table (§6.7)
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
def _evaluate_confidence(tier, rate, regime_days, days, current_segment, DEGRADED_IDENTITY_FACT = "controller identity unavailable — replacement detection relies on write-counter continuity only"
clock_now, warming_days, warming_low_coverage,
habit_change, staleness_hours, scenario_range):
facts = []
if tier == BaselineTier.NONE:
facts.append("no applicable endurance baseline")
return ConfidenceState.UNSUPPORTED, facts
if rate is None or rate <= 0: def _build_evidence_ladder(tier, regime_days, days, current_segment,
facts.append("no finite projection from this history") staleness_hours, scenario_range):
return ConfidenceState.UNSUPPORTED, facts """The eight Supported conditions of ADR 0002 §8, each met or unmet."""
ladder = []
supported_facts = [] def add(name, met, met_reason, unmet_reason):
failing = False ladder.append(LadderCondition(name, met, met_reason if met else unmet_reason))
# 1. Verified baseline add("verified baseline", tier == BaselineTier.VERIFIED,
if tier != BaselineTier.VERIFIED: "verified manufacturer TBW",
failing = True {BaselineTier.UNVERIFIED: "baseline is unverified (user-supplied)",
else: BaselineTier.IMPLIED: "baseline is implied from vendor wear — coarse"}.get(
supported_facts.append("verified manufacturer TBW") tier, "no applicable endurance baseline"))
# 2. >= 14 qualifying days qualifying = sum(1 for d in days
qualifying = sum(1 for d in days if d["coverage"] >= WARMING_COVERAGE_FLOOR and d["sample_count"] > 0) if d["coverage"] >= WARMING_COVERAGE_FLOOR and d["sample_count"] > 0)
if qualifying < WARMING_MIN_DAYS: add("14 qualifying days", qualifying >= WARMING_MIN_DAYS,
failing = True "%d calendar days" % qualifying,
else: "%d of %d qualifying days" % (qualifying, WARMING_MIN_DAYS))
supported_facts.append("%d calendar days" % qualifying)
# 3. Coverage >= 80%
total_wc = len(days) * 86400 total_wc = len(days) * 86400
total_known = sum(int(d["coverage"] * 86400) for d in days) total_known = sum(int(d["coverage"] * 86400) for d in days)
avg_cov = total_known / total_wc if total_wc > 0 else 0.0 avg_cov = total_known / total_wc if total_wc > 0 else 0.0
if avg_cov < SUPPORTED_COVERAGE_FLOOR: add("coverage at least 80%", avg_cov >= SUPPORTED_COVERAGE_FLOOR,
failing = True "%d%% interval coverage" % int(avg_cov * 100),
"interval coverage %d%% (≥%d%% required)"
% (int(avg_cov * 100), int(SUPPORTED_COVERAGE_FLOOR * 100)))
if staleness_hours is None:
add("fresh data", False, "", "no observation days yet")
else: else:
supported_facts.append("%d%% interval coverage" % int(avg_cov * 100)) add("fresh data", staleness_hours <= STALENESS_HOURS, "recent data",
"newest data %dh old (≥%dh)" % (staleness_hours, STALENESS_HOURS))
# 4. Fresh (< 48h) if scenario_range is None or not scenario_range.rates:
if staleness_hours is not None and staleness_hours > STALENESS_HOURS: add("horizons agree", False, "", "no scenario horizon covered yet")
failing = True else:
elif staleness_hours is not None:
supported_facts.append("recent data")
# 5. Horizon agreement
if scenario_range is not None and len(scenario_range.rates) >= 2:
rl = list(scenario_range.rates.values()) rl = list(scenario_range.rates.values())
if min(rl) > 0 and max(rl) / min(rl) > HORIZON_AGREEMENT_FACTOR: spread = max(rl) / min(rl) if min(rl) > 0 else None
failing = True agree = spread is None or spread <= HORIZON_AGREEMENT_FACTOR
else: add("horizons agree", agree, "%d weekly cycles" % len(rl),
supported_facts.append("%d weekly cycles" % len(scenario_range.rates)) "horizon rates differ by %.1f× (≤%d× required)"
else: % (spread or 0.0, HORIZON_AGREEMENT_FACTOR))
failing = True
# 6. Burst guard recent = days[-BURST_GUARD_LOOKBACK:]
if not failing and len(days) >= BURST_GUARD_LOOKBACK: t28 = sum(d["bytes_written"] for d in recent)
t28 = sum(d["bytes_written"] for d in days[-BURST_GUARD_LOOKBACK:]) burst = t28 > 0 and any(d["bytes_written"] >= BURST_GUARD_FRACTION * t28 for d in recent)
for d in days[-BURST_GUARD_LOOKBACK:]: add("no burst day", bool(recent) and not burst, "no burst days",
if t28 > 0 and d["bytes_written"] >= BURST_GUARD_FRACTION * t28: "one day carries ≥%d%% of trailing writes" % int(BURST_GUARD_FRACTION * 100)
failing = True if burst else "no observation days yet")
break
if not failing:
supported_facts.append("no burst days")
# 7. Regime >= 7 days add("regime at least 7 days", regime_days >= YOUNG_REGIME_DAYS,
if regime_days < YOUNG_REGIME_DAYS: "regime %d days" % regime_days,
failing = True "regime only %d days old (≥%d required)" % (regime_days, YOUNG_REGIME_DAYS))
# 8. Degraded identity degraded = bool(current_segment and current_segment.get("identity_degraded"))
if current_segment and current_segment.get("identity_degraded"): add("controller identity", not degraded, "controller identity available",
failing = True DEGRADED_IDENTITY_FACT)
facts.append("controller identity unavailable — replacement detection relies on write-counter continuity only") return ladder
if not failing:
return ConfidenceState.SUPPORTED, supported_facts
# Limited def _evaluate_confidence(tier, rate, regime_days, days, current_segment,
limited_facts = list(supported_facts) habit_change, staleness_hours, scenario_range):
"""Return (confidence state, facts, evidence ladder)."""
ladder = _build_evidence_ladder(tier, regime_days, days, current_segment,
staleness_hours, scenario_range)
if tier == BaselineTier.NONE:
return ConfidenceState.UNSUPPORTED, ["no applicable endurance baseline"], ladder
if rate is None or rate <= 0:
return ConfidenceState.UNSUPPORTED, ["no finite projection from this history"], ladder
met_facts = [c.reason for c in ladder if c.met]
if all(c.met for c in ladder):
return ConfidenceState.SUPPORTED, met_facts, ladder
# Limited: met facts plus the contributing failures
limited_facts = list(met_facts)
if staleness_hours is not None and staleness_hours > STALENESS_HOURS: if staleness_hours is not None and staleness_hours > STALENESS_HOURS:
limited_facts.append("newest data %dh old (≥48h)" % staleness_hours) limited_facts.append("newest data %dh old (≥48h)" % staleness_hours)
if habit_change is not None: if habit_change is not None:
@@ -425,11 +533,27 @@ def _evaluate_confidence(tier, rate, regime_days, days, current_segment,
if regime_days < YOUNG_REGIME_DAYS: if regime_days < YOUNG_REGIME_DAYS:
limited_facts.append("regime only %d days old (≥7 required)" % regime_days) limited_facts.append("regime only %d days old (≥7 required)" % regime_days)
if current_segment and current_segment.get("identity_degraded"): if current_segment and current_segment.get("identity_degraded"):
degraded_fact = "controller identity unavailable — replacement detection relies on write-counter continuity only" if DEGRADED_IDENTITY_FACT not in limited_facts:
if degraded_fact not in limited_facts: limited_facts.append(DEGRADED_IDENTITY_FACT)
limited_facts.append(degraded_fact) return ConfidenceState.LIMITED, limited_facts, ladder
return ConfidenceState.LIMITED, limited_facts
def ladder_count_text(result):
"""Headline form of the evidence ladder: how many conditions are met."""
return "%d of %d conditions met" % (result.ladder_met, result.ladder_total)
def ladder_lines(result):
"""Full evidence ladder for the outlook, one line per condition."""
return ["[%s] %s — %s" % ("x" if c.met else " ", c.name, c.reason)
for c in result.evidence_ladder]
def write_rate_gb_day(result):
"""The sustained-regime write rate in GB/day, or None when not yet known."""
if result.write_rate is None:
return None
return result.write_rate * 86400 / 1e9
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
@@ -494,24 +618,37 @@ def _has_complete_local_day(conn):
within a monitoring period that has usable observation evidence. within a monitoring period that has usable observation evidence.
This is the prerequisite for showing an endurance outlook. This is the prerequisite for showing an endurance outlook.
""" """
return _count_complete_local_days(conn) > 0 local_days = conn.execute(
"SELECT utc_start, utc_end FROM local_days "
def _count_complete_local_days(conn):
"""Count the number of complete local observation days."""
row = conn.execute(
"SELECT COUNT(*) FROM local_days "
"WHERE complete = 1 " "WHERE complete = 1 "
"AND activity_precision IN ('measured', 'coarse') " "AND activity_precision IN ('measured', 'coarse') "
"AND activity_intervals > 0" "AND activity_intervals > 0 ORDER BY id"
).fetchone() ).fetchall()
return row[0] if row else 0 return any(
interval_within_one_monitoring_period(conn, utc_start, utc_end)
for utc_start, utc_end in local_days
)
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
# Main projection function # Main projection function
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
def _determine_stage(state, hours_observed, total_days, days_below_coverage):
"""Where the projection stands on its way to support (ADR 0012 §1, §2)."""
if hours_observed < PROVISIONAL_MIN_HOURS:
return ProjectionStage.NO_OBSERVATIONS
if state == ConfidenceState.UNSUPPORTED:
return ProjectionStage.UNAVAILABLE
if hours_observed < DAILY_CYCLE_HOURS:
return ProjectionStage.PROVISIONAL
if total_days < WARMING_MIN_DAYS or days_below_coverage > WARMING_MAX_LOW_COVERAGE:
return ProjectionStage.WARMING
if state == ConfidenceState.SUPPORTED:
return ProjectionStage.SUPPORTED
return ProjectionStage.LIMITED
def compute_projection(conn, clock_now): def compute_projection(conn, clock_now):
facts = [] facts = []
habit_change_fact = None habit_change_fact = None
@@ -524,32 +661,14 @@ def compute_projection(conn, clock_now):
tier, baseline, baseline_label, baseline_facts = _resolve_baseline(conn, current_segment) tier, baseline, baseline_label, baseline_facts = _resolve_baseline(conn, current_segment)
facts.extend(baseline_facts) facts.extend(baseline_facts)
# --- Complete observation day gate (issue #94) --- # The complete-local-day condition is a fact, not a gate (ADR 0012 §2).
# An endurance outlook requires at least one complete local if not _has_complete_local_day(conn):
# midnight-to-midnight calendar day with usable observation evidence.
has_complete_day = _has_complete_local_day(conn)
if not has_complete_day:
facts.append("waiting for a full local observation day") facts.append("waiting for a full local observation day")
return ProjectionResult(
confidence_state=ConfidenceState.UNSUPPORTED,
contributing_facts=facts,
headline_remaining_seconds=None,
scenario_range=None,
pu_context_line="Percentage Used: unknown" if _get_latest_pu(conn) is None else "Percentage Used: %d%%" % (_get_latest_pu(conn) or 0),
disclosure_text=list(DISCLOSURES),
baseline_tier=tier,
baseline_label=baseline_label,
regime_days=None,
habit_change_fact=None,
warming_fact=None,
staleness_fact=None,
degraded_identity_fact=None,
zero_rate_fact=None,
qualifying_days_progress=None,
)
segment_days = _get_days_in_segment(conn, current_segment["opened_at"]) if current_segment else _get_all_days(conn) segment_days = _get_days_in_segment(conn, current_segment["opened_at"]) if current_segment else _get_all_days(conn)
all_days = _get_all_days(conn) all_days = _get_all_days(conn)
hours_observed = _get_hours_observed(
conn, current_segment["opened_at"] if current_segment else None, segment_days)
regime_start_day = None regime_start_day = None
habit_change = None habit_change = None
@@ -579,12 +698,15 @@ def compute_projection(conn, clock_now):
scenario = None scenario = None
horizon_rates = {} horizon_rates = {}
horizon_reasons = {} horizon_reasons = {}
for h in HORIZON_DAYS: for h in SHORT_HORIZON_DAYS + HORIZON_DAYS:
hr, reason = _compute_horizon_rate(all_days, conn, h, clock_now) hr, reason = _compute_horizon_rate(all_days, conn, h, clock_now)
if hr is not None: if hr is not None:
horizon_rates[h] = hr horizon_rates[h] = hr
else: elif h in HORIZON_DAYS:
horizon_reasons[h] = reason horizon_reasons[h] = reason
if HORIZON_DAYS[0] in horizon_rates:
for h in SHORT_HORIZON_DAYS:
horizon_rates.pop(h, None)
if horizon_rates: if horizon_rates:
scenario = ScenarioRange( scenario = ScenarioRange(
rates=horizon_rates, rates=horizon_rates,
@@ -620,33 +742,47 @@ def compute_projection(conn, clock_now):
facts.append(staleness_fact) facts.append(staleness_fact)
if current_segment and current_segment.get("identity_degraded"): if current_segment and current_segment.get("identity_degraded"):
degraded_identity_fact = "controller identity unavailable — replacement detection relies on write-counter continuity only" degraded_identity_fact = DEGRADED_IDENTITY_FACT
facts.append(degraded_identity_fact) facts.append(degraded_identity_fact)
state, conf_facts = _evaluate_confidence( state, conf_facts, ladder = _evaluate_confidence(
tier, rate, regime_days_count, segment_days, current_segment, clock_now, tier, rate, regime_days_count, segment_days, current_segment,
qualifying, 0, habit_change, staleness_hours, scenario, habit_change, staleness_hours, scenario,
) )
stage = _determine_stage(state, hours_observed, total_days_count, days_below_coverage)
if stage == ProjectionStage.NO_OBSERVATIONS:
# Too little evidence for any number: no rate, no lifespan.
state = ConfidenceState.UNSUPPORTED
rate = None
scenario = None
if hours_observed > 0:
facts.insert(0, "%d of %d hours observed before the first projection"
% (hours_observed, PROVISIONAL_MIN_HOURS))
elif stage == ProjectionStage.PROVISIONAL:
# Short-horizon spread: the rate over the hours observed so far.
scenario = ScenarioRange(rates={SHORT_HORIZON_DAYS[0]: rate},
min_days=SHORT_HORIZON_DAYS[0],
max_days=SHORT_HORIZON_DAYS[0])
facts[:0] = ["%d hours observed" % hours_observed, "daily cycle not yet seen"]
all_facts = list(facts) all_facts = list(facts)
for cf in conf_facts: for cf in conf_facts:
if cf not in all_facts: if cf not in all_facts:
all_facts.append(cf) all_facts.append(cf)
headline_seconds = None headline_seconds = None
if state != ConfidenceState.UNSUPPORTED and rate is not None and rate > 0 and baseline is not None: if state != ConfidenceState.UNSUPPORTED and rate is not None and rate > 0:
if tier in (BaselineTier.VERIFIED, BaselineTier.UNVERIFIED): W_t, p = _get_latest_published_sample(
conn, current_segment["id"] if current_segment else None)
E_baseline = None
if tier in (BaselineTier.VERIFIED, BaselineTier.UNVERIFIED) and baseline is not None:
E_baseline = baseline["tbw_terabytes"] * TBW_TO_BYTES E_baseline = baseline["tbw_terabytes"] * TBW_TO_BYTES
elif tier == BaselineTier.IMPLIED: elif (tier == BaselineTier.IMPLIED and W_t is not None and p is not None
p = _get_latest_pu(conn) and IMPLIED_P_MIN <= p <= IMPLIED_P_MAX):
if p is not None and IMPLIED_P_MIN <= p <= IMPLIED_P_MAX: E_baseline = 100 * W_t / p
E_baseline = 100 * regime_bytes / p if E_baseline is not None and W_t is not None:
else: headline_seconds = max(E_baseline - W_t, 0) / rate
E_baseline = None
else:
E_baseline = None
if E_baseline is not None:
headline_seconds = max(E_baseline - regime_bytes, 0) / rate
pu_line = _build_pu_context_line(conn, rate, segment_days, clock_now) pu_line = _build_pu_context_line(conn, rate, segment_days, clock_now)
@@ -666,4 +802,8 @@ def compute_projection(conn, clock_now):
degraded_identity_fact=degraded_identity_fact, degraded_identity_fact=degraded_identity_fact,
zero_rate_fact=zero_rate_fact, zero_rate_fact=zero_rate_fact,
qualifying_days_progress=qualifying_days_progress, qualifying_days_progress=qualifying_days_progress,
stage=stage,
evidence_ladder=ladder,
write_rate=rate,
hours_observed=hours_observed,
) )
+15 -26
View File
@@ -4,25 +4,23 @@ The 14-day cutoff never overrides local-day preservation, shared boundary
evidence, publication recovery, or the newest sample's successor-anchor role. evidence, publication recovery, or the newest sample's successor-anchor role.
""" """
import sqlite3 import sqlite3
from datetime import date, datetime, timedelta, timezone from datetime import date, datetime, timedelta
from .monitoring_periods import (
as_utc_datetime,
interval_within_one_monitoring_period,
)
RAW_SAMPLE_RETENTION_DAYS = 14 RAW_SAMPLE_RETENTION_DAYS = 14
def _utc_datetime(value: datetime) -> datetime:
"""Normalize a clock value to aware UTC."""
if value.tzinfo is None:
value = value.replace(tzinfo=timezone.utc)
return value.astimezone(timezone.utc)
def _parse_sample_time(value: str) -> datetime | None: def _parse_sample_time(value: str) -> datetime | None:
"""Parse old timestamps conservatively; malformed legacy values stay.""" """Parse old timestamps conservatively; malformed legacy values stay."""
try: try:
parsed = datetime.fromisoformat(value) parsed = datetime.fromisoformat(value)
except (TypeError, ValueError): except (TypeError, ValueError):
return None return None
return _utc_datetime(parsed) return as_utc_datetime(parsed)
def _sample_rows(conn: sqlite3.Connection) -> list[tuple]: def _sample_rows(conn: sqlite3.Connection) -> list[tuple]:
@@ -149,16 +147,7 @@ def _monitoring_period_covers(
end: datetime, end: datetime,
) -> bool: ) -> bool:
"""Require continuous monitoring before a local-day total replaces detail.""" """Require continuous monitoring before a local-day total replaces detail."""
for started_at, ended_at in conn.execute( return interval_within_one_monitoring_period(conn, start, end)
"SELECT started_at, ended_at FROM monitoring_periods"
):
period_start = _parse_sample_time(started_at)
period_end = _parse_sample_time(ended_at) if ended_at is not None else None
if period_start is None or period_start > start:
continue
if ended_at is None or (period_end is not None and end <= period_end):
return True
return False
def _has_local_replacement( def _has_local_replacement(
@@ -312,7 +301,7 @@ def needs_boundary_anchor(
) -> bool: ) -> bool:
"""Return whether an old sample still carries unreplaced evidence.""" """Return whether an old sample still carries unreplaced evidence."""
sample_time = _parse_sample_time(sample_ts) sample_time = _parse_sample_time(sample_ts)
cutoff = _utc_datetime(now) - timedelta(days=RAW_SAMPLE_RETENTION_DAYS) cutoff = as_utc_datetime(now) - timedelta(days=RAW_SAMPLE_RETENTION_DAYS)
if sample_time is None: if sample_time is None:
return True return True
if sample_time >= cutoff: if sample_time >= cutoff:
@@ -341,13 +330,13 @@ def prune_old_samples(
neighbour interval, lacks UTC or local-day replacement evidence, or has a neighbour interval, lacks UTC or local-day replacement evidence, or has a
timestamp that cannot be safely interpreted. timestamp that cannot be safely interpreted.
""" """
cutoff = _utc_datetime(now) - timedelta(days=retention_days) cutoff = as_utc_datetime(now) - timedelta(days=retention_days)
owns_transaction = not conn.in_transaction owns_transaction = not conn.in_transaction
savepoint = "fenris_sample_retention" savepoint = "fenris_sample_retention"
if owns_transaction: if owns_transaction:
conn.execute("BEGIN IMMEDIATE") conn.execute("BEGIN IMMEDIATE")
else: else:
conn.execute(f"SAVEPOINT {savepoint}") conn.execute(f"SAVEPOINT {savepoint}") # nosemgrep: sqlalchemy-execute-raw-query, formatted-sql-query -- savepoint name is a function-local constant; SQLite cannot bind identifiers
try: try:
rows = _sample_rows(conn) rows = _sample_rows(conn)
@@ -355,7 +344,7 @@ def prune_old_samples(
if owns_transaction: if owns_transaction:
conn.commit() conn.commit()
else: else:
conn.execute(f"RELEASE SAVEPOINT {savepoint}") conn.execute(f"RELEASE SAVEPOINT {savepoint}") # nosemgrep: sqlalchemy-execute-raw-query, formatted-sql-query -- savepoint name is a function-local constant; SQLite cannot bind identifiers
return 0 return 0
newest_id = rows[-1][0] newest_id = rows[-1][0]
@@ -372,12 +361,12 @@ def prune_old_samples(
if owns_transaction: if owns_transaction:
conn.commit() conn.commit()
else: else:
conn.execute(f"RELEASE SAVEPOINT {savepoint}") conn.execute(f"RELEASE SAVEPOINT {savepoint}") # nosemgrep: sqlalchemy-execute-raw-query, formatted-sql-query -- savepoint name is a function-local constant; SQLite cannot bind identifiers
return len(expired) return len(expired)
except Exception: except Exception:
if owns_transaction: if owns_transaction:
conn.rollback() conn.rollback()
else: else:
conn.execute(f"ROLLBACK TO SAVEPOINT {savepoint}") conn.execute(f"ROLLBACK TO SAVEPOINT {savepoint}") # nosemgrep: sqlalchemy-execute-raw-query, formatted-sql-query -- savepoint name is a function-local constant; SQLite cannot bind identifiers
conn.execute(f"RELEASE SAVEPOINT {savepoint}") conn.execute(f"RELEASE SAVEPOINT {savepoint}") # nosemgrep: sqlalchemy-execute-raw-query, formatted-sql-query -- savepoint name is a function-local constant; SQLite cannot bind identifiers
raise raise
+2 -2
View File
@@ -13,11 +13,11 @@ Contracts:
""" """
import logging import logging
import sqlite3 import sqlite3
from dataclasses import dataclass, field from dataclasses import dataclass
from datetime import datetime, timedelta, timezone from datetime import datetime, timedelta, timezone
from typing import Optional, List, Tuple from typing import Optional, List, Tuple
from .derive import find_previous_sample, derive_hours_from_interval, _parse_ts from .derive import derive_hours_from_interval, _parse_ts
logger = logging.getLogger(__name__) logger = logging.getLogger(__name__)
-1
View File
@@ -17,7 +17,6 @@ import sqlite3
from datetime import datetime from datetime import datetime
from typing import Any, Dict, Optional, Tuple from typing import Any, Dict, Optional, Tuple
from .collector import normalize_identity
def find_current_segment(conn: sqlite3.Connection) -> Optional[Dict[str, Any]]: def find_current_segment(conn: sqlite3.Connection) -> Optional[Dict[str, Any]]:
+20 -31
View File
@@ -15,15 +15,17 @@ Criteria: LC-9, CI-2, CI-4, FL-4, FL-5, FL-7.
""" """
import sqlite3 import sqlite3
from contextlib import contextmanager from contextlib import contextmanager
import sys from datetime import datetime, timezone
from datetime import datetime, timedelta, timezone
from pathlib import Path from pathlib import Path
from typing import Any, Dict, Iterator, List, Optional, Tuple, TYPE_CHECKING from typing import Any, Dict, Iterator, List, Optional, Tuple, TYPE_CHECKING
if TYPE_CHECKING: if TYPE_CHECKING:
from .status_composition import StatusComposition from .status_composition import StatusComposition
from .projection import compute_projection, ConfidenceState, DISCLOSURES from .projection import (
compute_projection, DISCLOSURES, ProjectionStage, ladder_count_text,
ladder_lines, write_rate_gb_day,
)
from .store import SCHEMA_VERSION from .store import SCHEMA_VERSION
from .init_system import ( from .init_system import (
query_service_state as _init_query_service_state, query_service_state as _init_query_service_state,
@@ -180,19 +182,6 @@ def grade_freshness(newest_sample_ts: Optional[str], clock_now: datetime) -> str
return "stale" return "stale"
def freshness_age_human(age_s: Optional[int]) -> str:
"""Human-readable age string for freshness fact."""
if age_s is None:
return "unknown age"
if age_s < 60:
return "%ds ago" % age_s
if age_s < 3600:
return "%dm ago" % (age_s // 60)
if age_s < 86400:
return "%dh %dm ago" % (age_s // 3600, (age_s % 3600) // 60)
return "%dd ago" % (age_s // 86400)
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
# Drive anomalies (§9.7 — FL-7) # Drive anomalies (§9.7 — FL-7)
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
@@ -255,8 +244,7 @@ def check_retired_flag(flag: str) -> Optional[str]:
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
def _format_projection(proj, freshness: str, drive_facts: List[str], def _format_projection(proj, freshness: str, drive_facts: List[str],
config_error: Optional[str], config_error: Optional[str]) -> str:
sample_count: int = 0, day_count: int = 0) -> str:
"""Format projection details; monitoring status has its own renderer.""" """Format projection details; monitoring status has its own renderer."""
lines = [] lines = []
@@ -272,15 +260,6 @@ def _format_projection(proj, freshness: str, drive_facts: List[str],
lines.append("Enable monitoring: fenris monitor resume") lines.append("Enable monitoring: fenris monitor resume")
return "\n".join(lines) return "\n".join(lines)
# --- Single sample: awaiting another sample (issue #73 AC3) ---
# Only show awaiting state when there are no day aggregates (e.g., legacy import
# or hand-crafted stores can have 1 sample but sufficient day data for projection)
if sample_count <= 1 and day_count == 0:
lines.append("awaiting another sample")
lines.append("")
lines.append("Collecting usage data — the first projection requires at least two samples.")
return "\n".join(lines)
if proj is None: if proj is None:
lines.append("no projection available") lines.append("no projection available")
return "\n".join(lines) return "\n".join(lines)
@@ -290,6 +269,9 @@ def _format_projection(proj, freshness: str, drive_facts: List[str],
lines.append(headline) lines.append(headline)
lines.append("") lines.append("")
# --- Stage and ladder count (ADR 0012) ---
lines.append("Projection stage: %s · %s" % (proj.stage_label, ladder_count_text(proj)))
# --- Confidence state + contributing facts (§6.7, §6.11) --- # --- Confidence state + contributing facts (§6.7, §6.11) ---
state_label = proj.confidence_state.value state_label = proj.confidence_state.value
facts_list = list(proj.contributing_facts) if proj.contributing_facts else [] facts_list = list(proj.contributing_facts) if proj.contributing_facts else []
@@ -305,6 +287,11 @@ def _format_projection(proj, freshness: str, drive_facts: List[str],
lines.append("%s evidence" % state_label) lines.append("%s evidence" % state_label)
lines.append("") lines.append("")
# --- Full evidence ladder in the outlook (ADR 0012 §5) ---
lines.append("Evidence ladder")
lines.extend(" " + line for line in ladder_lines(proj))
lines.append("")
# --- Scenario range (§6.5) with horizon reasons --- # --- Scenario range (§6.5) with horizon reasons ---
if proj.scenario_range: if proj.scenario_range:
parts = [] parts = []
@@ -333,8 +320,13 @@ def _format_projection(proj, freshness: str, drive_facts: List[str],
def _format_headline(proj) -> str: def _format_headline(proj) -> str:
"""Format the lifespan headline or its no-projection wording (§6.11).""" """Format the lifespan headline or its no-projection wording (§6.11)."""
if proj.headline_remaining_seconds is None: if proj.headline_remaining_seconds is None:
if proj.stage == ProjectionStage.NO_OBSERVATIONS:
return "no projection yet — collecting observations"
if proj.zero_rate_fact: if proj.zero_rate_fact:
return "no finite projection from this history" return "no finite projection from this history"
rate = write_rate_gb_day(proj)
if rate is not None:
return "write rate: %.2f GB/day · no lifespan without an endurance baseline" % rate
if proj.warming_fact: if proj.warming_fact:
return proj.warming_fact return proj.warming_fact
return "no projection available" return "no projection available"
@@ -507,10 +499,7 @@ def get_status(store_path: Optional[Path] = None, clock_now: Optional[datetime]
proj = compute_projection(conn, clock_now) proj = compute_projection(conn, clock_now)
except (sqlite3.Error, ValueError, TypeError): except (sqlite3.Error, ValueError, TypeError):
pass pass
parts.append(_format_projection( parts.append(_format_projection(proj, comp.freshness, drive_facts, config_error))
proj, comp.freshness, drive_facts, config_error,
comp.sample_count, comp.day_count,
))
if query_journal and ( if query_journal and (
comp.store_fault or comp.last_collect_ok is False comp.store_fault or comp.last_collect_ok is False
or comp.freshness in ("missed", "stale") or comp.freshness in ("missed", "stale")
+5 -10
View File
@@ -11,24 +11,19 @@ Freshness grading uses shared constants from status.py.
import enum import enum
import sqlite3 import sqlite3
from dataclasses import dataclass, field from dataclasses import dataclass, field
from datetime import datetime, timedelta, timezone from datetime import datetime, timezone
from typing import Any, Dict, List, Optional from typing import Any, Dict, List, Optional
# Status poll interval (AC78-6): lightweight 5s systemctl show poll
STATUS_POLL_INTERVAL_S = 5
from .status import ( from .status import (
FRESH_THRESHOLD_S,
STALENESS_THRESHOLD_S,
grade_freshness, grade_freshness,
freshness_age_human,
is_deliberately_paused, is_deliberately_paused,
monitoring_continuity, monitoring_continuity,
deliberate_pause_lines, deliberate_pause_lines,
open_store_readonly,
StoreFault,
NewerSchema,
) )
from .timefmt import freshness_age_human
# Status poll interval (AC78-6): lightweight 5s systemctl show poll
STATUS_POLL_INTERVAL_S = 5
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
+51 -8
View File
@@ -7,11 +7,26 @@ This module handles:
""" """
import sqlite3 import sqlite3
from pathlib import Path from pathlib import Path
from typing import Optional
# Schema version - increment on each migration # Schema version - increment on each migration
SCHEMA_VERSION = 6 SCHEMA_VERSION = 7
# Diagnostic counters added in schema 7 (issue #111), named after the
# NVMe health-log keys they come from. All nullable: legacy rows and drives that
# do not report a counter stay unknown rather than zero.
DIAGNOSTIC_SAMPLE_COLUMNS = (
"host_reads",
"host_writes",
"controller_busy_time",
"num_err_log_entries",
"warning_temp_time",
"critical_comp_time",
"thm_temp1_trans_count",
"thm_temp1_total_time",
"thm_temp2_trans_count",
"thm_temp2_total_time",
)
# Packaged default placement (spec §8.3). The config may override it, but a # Packaged default placement (spec §8.3). The config may override it, but a
@@ -61,7 +76,7 @@ def init_store(store_path: Path) -> sqlite3.Connection:
if current_version == 0: if current_version == 0:
# New database - create schema # New database - create schema
_create_schema(conn) _create_schema(conn)
conn.execute(f"PRAGMA user_version={SCHEMA_VERSION}") conn.execute(f"PRAGMA user_version={SCHEMA_VERSION}") # nosemgrep: sqlalchemy-execute-raw-query, formatted-sql-query -- SCHEMA_VERSION is an int constant; PRAGMA cannot bind parameters
conn.commit() conn.commit()
elif current_version > SCHEMA_VERSION: elif current_version > SCHEMA_VERSION:
# Unknown newer version - refuse # Unknown newer version - refuse
@@ -109,7 +124,17 @@ def _create_schema(conn: sqlite3.Connection):
bytes_read INTEGER, bytes_read INTEGER,
critical_warning INTEGER, critical_warning INTEGER,
segment_id INTEGER, segment_id INTEGER,
local_tz TEXT local_tz TEXT,
host_reads INTEGER,
host_writes INTEGER,
controller_busy_time INTEGER,
num_err_log_entries INTEGER,
warning_temp_time INTEGER,
critical_comp_time INTEGER,
thm_temp1_trans_count INTEGER,
thm_temp1_total_time INTEGER,
thm_temp2_trans_count INTEGER,
thm_temp2_total_time INTEGER
) )
""") """)
@@ -303,6 +328,7 @@ def _apply_migrations(conn: sqlite3.Connection, current_version: int):
4: _migrate_3_to_4, 4: _migrate_3_to_4,
5: _migrate_4_to_5, 5: _migrate_4_to_5,
6: _migrate_5_to_6, 6: _migrate_5_to_6,
7: _migrate_6_to_7,
} }
while current_version < SCHEMA_VERSION: while current_version < SCHEMA_VERSION:
target_version = current_version + 1 target_version = current_version + 1
@@ -312,7 +338,7 @@ def _apply_migrations(conn: sqlite3.Connection, current_version: int):
conn.execute("BEGIN IMMEDIATE") conn.execute("BEGIN IMMEDIATE")
try: try:
migration(conn) migration(conn)
conn.execute(f"PRAGMA user_version={target_version}") conn.execute(f"PRAGMA user_version={target_version}") # nosemgrep: sqlalchemy-execute-raw-query, formatted-sql-query -- target_version is an int key of the static migrations map; PRAGMA cannot bind parameters
conn.commit() conn.commit()
except Exception: except Exception:
conn.rollback() conn.rollback()
@@ -337,7 +363,7 @@ def _migrate_1_to_2(conn: sqlite3.Connection) -> None:
).fetchall()} ).fetchall()}
for column in ("unattributed_bytes_written", "unattributed_bytes_read"): for column in ("unattributed_bytes_written", "unattributed_bytes_read"):
if column not in cols: if column not in cols:
conn.execute( conn.execute( # nosemgrep: sqlalchemy-execute-raw-query, formatted-sql-query -- column comes from a hardcoded tuple; DDL cannot bind identifiers
f"ALTER TABLE day_aggregates ADD COLUMN {column} INTEGER DEFAULT 0" f"ALTER TABLE day_aggregates ADD COLUMN {column} INTEGER DEFAULT 0"
) )
@@ -394,7 +420,7 @@ def _migrate_4_to_5(conn: sqlite3.Connection) -> None:
("last_sample_id", "INTEGER"), ("last_sample_id", "INTEGER"),
): ):
if column not in local_cols: if column not in local_cols:
conn.execute( conn.execute( # nosemgrep: sqlalchemy-execute-raw-query, formatted-sql-query -- column and declaration come from a hardcoded tuple; DDL cannot bind identifiers
f"ALTER TABLE local_days ADD COLUMN {column} {declaration}" f"ALTER TABLE local_days ADD COLUMN {column} {declaration}"
) )
_create_local_day_shared_evidence(conn) _create_local_day_shared_evidence(conn)
@@ -408,6 +434,23 @@ def _migrate_5_to_6(conn: sqlite3.Connection) -> None:
repair_legacy_local_day_evidence(conn) repair_legacy_local_day_evidence(conn)
def _migrate_6_to_7(conn: sqlite3.Connection) -> None:
"""Add nullable diagnostic counters to samples (issue #111).
Additive only: existing rows are untouched and read NULL (unknown).
Rollback (SQLite 3.35+, with the collector stopped): for each column in
DIAGNOSTIC_SAMPLE_COLUMNS run ``ALTER TABLE samples DROP COLUMN <name>``,
then ``PRAGMA user_version=6``. Dropping loses only the new counters.
"""
cols = {row[1] for row in conn.execute("PRAGMA table_info(samples)").fetchall()}
if not cols:
return
for column in DIAGNOSTIC_SAMPLE_COLUMNS:
if column not in cols:
# nosemgrep: python.lang.security.audit.formatted-sql-query.formatted-sql-query, python.sqlalchemy.security.sqlalchemy-execute-raw-query.sqlalchemy-execute-raw-query -- column is from DIAGNOSTIC_SAMPLE_COLUMNS, a constant
conn.execute(f"ALTER TABLE samples ADD COLUMN {column} INTEGER")
def migrate_to_latest(store_path: Path) -> int: def migrate_to_latest(store_path: Path) -> int:
"""Apply forward-only migrations to bring the store to SCHEMA_VERSION. """Apply forward-only migrations to bring the store to SCHEMA_VERSION.
@@ -436,7 +479,7 @@ def migrate_to_latest(store_path: Path) -> int:
# Version 0 means no schema — create fresh (issue #73) # Version 0 means no schema — create fresh (issue #73)
if current_version == 0: if current_version == 0:
_create_schema(conn) _create_schema(conn)
conn.execute(f"PRAGMA user_version={SCHEMA_VERSION}") conn.execute(f"PRAGMA user_version={SCHEMA_VERSION}") # nosemgrep: sqlalchemy-execute-raw-query, formatted-sql-query -- SCHEMA_VERSION is an int constant; PRAGMA cannot bind parameters
conn.commit() conn.commit()
conn.close() conn.close()
return SCHEMA_VERSION return SCHEMA_VERSION
+3 -2
View File
@@ -161,14 +161,15 @@ def get_theme(name: str) -> Theme:
def get_graph_colors(theme_name: str) -> Dict[str, str]: def get_graph_colors(theme_name: str) -> Dict[str, str]:
"""Return the graph colour roles for a theme preset. """Return the graph colour roles for a theme preset.
Returns a dict with keys: allocated, unallocated, gap, zero, partial, Returns a dict with keys: allocated, unallocated, secondary (the second
selection and muted text. Falls back to Chalktone for unknown names. series), gap, zero, partial, selection and muted text. Falls back to Chalktone for unknown names.
""" """
theme = get_theme(theme_name) theme = get_theme(theme_name)
variables = theme.variables or {} variables = theme.variables or {}
return { return {
"allocated": variables.get("graph-allocated", "#d4a017"), "allocated": variables.get("graph-allocated", "#d4a017"),
"unallocated": variables.get("graph-unallocated", "#8b6914"), "unallocated": variables.get("graph-unallocated", "#8b6914"),
"secondary": variables.get("graph-unallocated", "#8b6914"),
"gap": variables.get("graph-gap", "#554422"), "gap": variables.get("graph-gap", "#554422"),
"zero": variables.get("graph-zero", "#665533"), "zero": variables.get("graph-zero", "#665533"),
"partial": variables.get("graph-partial", "#aa8822"), "partial": variables.get("graph-partial", "#aa8822"),
+63
View File
@@ -0,0 +1,63 @@
"""Time formatting for the dashboard and CLI.
One home for every user-facing time string: local clock times labelled with
their timezone, the secondary UTC form shown beside them, and relative ages.
Stored evidence stays UTC; only presentation is localised.
"""
from datetime import datetime, timezone
from typing import Optional
from zoneinfo import ZoneInfo, ZoneInfoNotFoundError
from .tz_util import detect_system_tz, get_tz_offset_str
def local_zone_name() -> str:
"""Return the system timezone name, falling back to UTC when unusable."""
name = detect_system_tz()
try:
ZoneInfo(name)
except (ZoneInfoNotFoundError, ValueError, OSError):
return "UTC"
return name
def tz_label(when: datetime, zone_name: str) -> str:
"""Timezone name with its UTC offset at *when*, e.g. ``Asia/Kolkata +05:30``."""
return "%s %s" % (zone_name, get_tz_offset_str(when, zone_name))
def local_clock(when: datetime, zone_name: str) -> str:
"""Local wall-clock ``HH:MM`` for *when*."""
return when.astimezone(ZoneInfo(zone_name)).strftime("%H:%M")
def local_timestamp(when: datetime, zone_name: str) -> str:
"""Local date, clock time and timezone label for CLI output."""
local = when.astimezone(ZoneInfo(zone_name))
return "%s %s" % (local.strftime("%Y-%m-%d %H:%M"), tz_label(when, zone_name))
def utc_stamp_label(when: datetime) -> str:
"""Secondary UTC form of a single instant."""
return when.astimezone(timezone.utc).strftime("%Y-%m-%d %H:%M UTC")
def utc_range_label(start: datetime, end: datetime) -> str:
"""Secondary UTC form of an interval."""
return "%s → %s UTC" % (
start.astimezone(timezone.utc).strftime("%H:%M"),
end.astimezone(timezone.utc).strftime("%H:%M"),
)
def freshness_age_human(age_s: Optional[int]) -> str:
"""Human-readable age string for freshness fact."""
if age_s is None:
return "unknown age"
if age_s < 60:
return "%ds ago" % age_s
if age_s < 3600:
return "%dm ago" % (age_s // 60)
if age_s < 86400:
return "%dh %dm ago" % (age_s // 3600, (age_s % 3600) // 60)
return "%dd ago" % (age_s // 86400)
+456 -940
View File
File diff suppressed because it is too large Load Diff
+1 -1
View File
@@ -5,7 +5,7 @@ computation used by local-day derivation. All functions are
stateless and safe to call from the collector and TUI reader. stateless and safe to call from the collector and TUI reader.
""" """
import os import os
from datetime import datetime, timezone from datetime import datetime
from pathlib import Path from pathlib import Path
-1
View File
@@ -1,7 +1,6 @@
"""Shared test helpers for Fenris test suite.""" """Shared test helpers for Fenris test suite."""
from pathlib import Path from pathlib import Path
import pytest
REPO_ROOT = Path(__file__).resolve().parent.parent REPO_ROOT = Path(__file__).resolve().parent.parent
VERSION_FILE = REPO_ROOT / "pyproject.toml" VERSION_FILE = REPO_ROOT / "pyproject.toml"
+3 -11
View File
@@ -9,7 +9,6 @@ CI-3 Prohibition set: automated structural checks
CI-4 Required wording and six disclosures in both views CI-4 Required wording and six disclosures in both views
""" """
import re import re
import sqlite3
from datetime import datetime, timedelta, timezone from datetime import datetime, timedelta, timezone
from pathlib import Path from pathlib import Path
from unittest.mock import patch from unittest.mock import patch
@@ -19,16 +18,13 @@ import sys
sys.path.insert(0, str(Path(__file__).parent.parent / "src")) sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
from fenris.store import init_store, SCHEMA_VERSION from fenris.store import init_store
from fenris.monitoring_periods import ensure_period_open from fenris.monitoring_periods import ensure_period_open
from fenris.projection import ( from fenris.projection import (
compute_projection, compute_projection,
ConfidenceState, ConfidenceState,
BaselineTier, BaselineTier,
DISCLOSURES, DISCLOSURES,
STALENESS_HOURS,
WARMING_MIN_DAYS,
YOUNG_REGIME_DAYS,
) )
from fenris.status import ( from fenris.status import (
grade_freshness, grade_freshness,
@@ -36,13 +32,9 @@ from fenris.status import (
render_status, render_status,
format_disclosures, format_disclosures,
FRESH_THRESHOLD_S, FRESH_THRESHOLD_S,
STALENESS_THRESHOLD_S,
CADENCE_DEFAULT_S,
ACCURACY_SEC,
) )
from fenris.tui import ( from fenris.tui import (
FenrisTuiApp, FenrisTuiApp,
_format_remaining,
) )
@@ -98,8 +90,8 @@ def _insert_day(conn, day, bw=1024*1024*100, coverage=0.95, samples=24):
def _insert_sample(conn, ts, pu=5): def _insert_sample(conn, ts, pu=5):
conn.execute( conn.execute(
"INSERT INTO samples (ts, device, data_units_written, data_units_read, " "INSERT INTO samples (ts, device, data_units_written, data_units_read, "
"percentage_used, bytes_written, bytes_read, power_on_hours) " "percentage_used, bytes_written, bytes_read, power_on_hours, segment_id) "
"VALUES (?, ?, ?, ?, ?, ?, ?, ?)", "VALUES (?, ?, ?, ?, ?, ?, ?, ?, 1)",
(ts, "/dev/nvme0n1", 1000000, 500000, pu, 512000000000, 256000000000, 8765), (ts, "/dev/nvme0n1", 1000000, 500000, pu, 512000000000, 256000000000, 8765),
) )
conn.commit() conn.commit()
+22
View File
@@ -50,3 +50,25 @@ def test_many_intervals_and_selection_fit_small_plot_without_losing_points():
assert len(columns) == len(points) assert len(columns) == len(points)
assert text.plain.splitlines()[-2][columns[100]] == "▼" assert text.plain.splitlines()[-2][columns[100]] == "▼"
assert all(len(row) == 32 for row in text.plain.splitlines()) assert all(len(row) == 32 for row in text.plain.splitlines())
def test_secondary_series_shares_the_axis_and_colours_its_own_dots():
colors = get_graph_colors("chalktone")
writes = [VolumePoint(t, v, str(t)) for t, v in ((0, 10), (1, 10), (2, 10))]
reads = [VolumePoint(t, v, str(t)) for t, v in ((0, 100), (1, 100), (2, 100))]
text, columns, unit = volume_plot(
writes, 48, 10, -1, colors, secondary=reads)
assert "100.00" in text.plain # the larger read volume sets the ceiling
styles = {span.style for span in text.spans}
assert colors["allocated"] in styles and colors["secondary"] in styles
def test_secondary_gap_does_not_draw_or_connect():
colors = get_graph_colors("chalktone")
points = [VolumePoint(t, 5, str(t)) for t in range(3)]
reads = [VolumePoint(0, 9, "0"), VolumePoint(1, None, "1", "gap"),
VolumePoint(2, 9, "2")]
text, columns, _ = volume_plot(points, 48, 10, -1, colors, secondary=reads)
rows = text.plain.splitlines()[:-2]
top = next(r for r in rows if any(0x2801 <= ord(c) <= 0x28ff for c in r))
assert all(c == " " for c in top[columns[0] + 1:columns[-1]])
+483
View File
@@ -0,0 +1,483 @@
"""Tests for the Activity readout module (issue #108).
The readout is exercised against SQLite fixtures only; no Textual is involved.
The local timezone is pinned through the TZ environment variable.
"""
from datetime import datetime, timezone
from pathlib import Path
import sys
import pytest
sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
from fenris.activity_readout import (
critical_warning_badge,
decode_critical_warning,
diagnostics_text,
day_readout_text,
hour_readout_text,
local_day_text,
interval_readout_text,
readout,
selected_local_day,
)
from fenris.activity_selection import (
HISTORY_RANGE_MAX,
ActivitySelection,
HistoryDayIdentity,
)
from fenris.store import init_store
from fenris.timefmt import (
freshness_age_human,
local_timestamp,
utc_range_label,
utc_stamp_label,
)
NOW = datetime(2026, 9, 30, 20, 0, tzinfo=timezone.utc) # 01:30 on 10-01 in Kolkata
@pytest.fixture
def kolkata(monkeypatch):
monkeypatch.setenv("TZ", "Asia/Kolkata")
@pytest.fixture
def conn(tmp_path):
connection = init_store(tmp_path / "observations.db")
yield connection
connection.close()
def _local_day(conn, local_date, utc_start, utc_end, tz="Asia/Kolkata",
offset="+05:30", written=1_000_000_000, read=500_000_000,
intervals=1, seconds=86400, incomplete=0, precision="measured"):
conn.execute(
"INSERT INTO local_days (local_date, tz_name, tz_offset, utc_start, "
"utc_end, bytes_written, bytes_read, coverage, sample_count, complete, "
"activity_seconds, activity_intervals, activity_incomplete, "
"activity_precision) VALUES (?,?,?,?,?,?,?,1.0,24,1,?,?,?,?)",
(local_date, tz, offset, utc_start, utc_end, written, read,
seconds, intervals, incomplete, precision),
)
conn.commit()
def _kolkata_day(conn, local_date, **kwargs):
day = datetime.fromisoformat(local_date)
start = datetime(day.year, day.month, day.day, tzinfo=timezone.utc)
start_utc = start.timestamp() - 19800
end_utc = start_utc + 86400
_local_day(
conn, local_date,
datetime.fromtimestamp(start_utc, timezone.utc).isoformat(),
datetime.fromtimestamp(end_utc, timezone.utc).isoformat(),
**kwargs,
)
def _hour(conn, hour, written=0, read=0, active=0, idle=0, off=0, unknown=0,
samples=1, coverage=1.0, tmin=None, tmax=None, tavg=None):
conn.execute(
"INSERT INTO hour_observations (hour, active_seconds, idle_seconds, "
"powered_off_seconds, unknown_seconds, bytes_written_delta, "
"bytes_read_delta, temperature_min, temperature_max, temperature_avg, "
"sample_count, coverage) VALUES (?,?,?,?,?,?,?,?,?,?,?,?)",
(hour, active, idle, off, unknown, written, read, tmin, tmax, tavg,
samples, coverage),
)
conn.commit()
def _sample(conn, ts, written, read, segment=1, temp=35, critical=0):
conn.execute(
"INSERT INTO samples (ts, device, data_units_written, data_units_read, "
"percentage_used, bytes_written, bytes_read, power_on_hours, "
"segment_id, temperature_c, critical_warning) "
"VALUES (?,?,?,?,?,?,?,?,?,?,?)",
(ts, "/dev/nvme0n1", 1, 1, 1, written, read, 100, segment, temp,
critical),
)
conn.commit()
class TestHistoryDays:
def test_daily_bars_use_local_dates_not_utc_aggregates(self, conn, kolkata):
# A UTC aggregate for 09-30 must never be relabelled as a local day.
conn.execute(
"INSERT INTO day_aggregates (day, bytes_written_delta, "
"sample_count, coverage) VALUES ('2026-09-30', 9000000000, 24, 1.0)"
)
conn.commit()
_kolkata_day(conn, "2026-10-01")
result = readout(conn, ActivitySelection(), NOW)
assert result.days[-1]["day"] == "2026-10-01"
assert result.days[-1]["timezone_label"] == "Asia/Kolkata +05:30"
by_day = {d["day"]: d for d in result.days}
assert by_day["2026-09-30"]["is_gap"]
assert by_day["2026-09-30"]["total_written"] is None
def test_window_is_exact_and_missing_days_stay_explicit_gaps(self, conn, kolkata):
_kolkata_day(conn, "2026-09-29")
result = readout(conn, ActivitySelection(), NOW)
assert len(result.days) == HISTORY_RANGE_MAX
gaps = [d for d in result.days if d["is_gap"]]
assert len(gaps) == HISTORY_RANGE_MAX - 1 # only 09-29 has evidence
known = next(d for d in result.days if d["day"] == "2026-09-29")
assert known["activity_state"] == "complete"
assert known["total_written"] == 1_000_000_000
def test_current_local_day_is_partial_and_incomplete_day_is_flagged(self, conn, kolkata):
_kolkata_day(conn, "2026-10-01", written=100)
_kolkata_day(conn, "2026-09-30", written=200, seconds=3600)
by_day = {d["day"]: d for d in readout(conn, ActivitySelection(), NOW).days}
assert by_day["2026-10-01"]["activity_state"] == "so_far"
assert by_day["2026-10-01"]["is_partial"]
assert by_day["2026-09-30"]["activity_state"] == "incomplete"
assert by_day["2026-09-30"]["is_partial"]
def test_shared_local_day_evidence_is_kept_apart_not_prorated(self, conn, kolkata):
_kolkata_day(conn, "2026-09-29", written=7_000_000_000, read=3_000_000_000)
conn.execute(
"INSERT INTO local_day_unallocated_evidence (start_sample_id, "
"end_sample_id, start_local_date, end_local_date, start_tz_name, "
"end_tz_name, started_at, ended_at, bytes_written, bytes_read, "
"reason) VALUES (1,2,'2026-09-29','2026-09-30','Asia/Kolkata',"
"'Asia/Kolkata','2026-09-29T18:00:00+00:00',"
"'2026-09-29T18:40:00+00:00',1000000000,500000000,'local_midnight')"
)
conn.commit()
day = next(
d for d in readout(conn, ActivitySelection(), NOW).days
if d["day"] == "2026-09-29"
)
assert day["total_written"] == 7_000_000_000
assert day["shared_bytes_written"] == 1_000_000_000
assert day["shared_bytes_read"] == 500_000_000
text = day_readout_text(day)
assert "W 7.000 GB known" in text
assert "shared at midnight W 1.000 GB · R 0.500 GB" in text
def test_unrecorded_selected_date_is_an_unavailable_gap(self, conn, kolkata):
selection = ActivitySelection()
selection.select_history_date("2026-06-01")
result = readout(conn, selection, NOW)
assert result.local_date == "2026-06-01"
assert result.local_day is None
picked = [d for d in result.days if d["day"] == "2026-06-01"]
assert picked and picked[0]["is_gap"]
assert "local-day evidence unavailable" in day_readout_text(picked[0])
class TestLocalDayStrip:
def test_current_day_text_has_zone_state_and_habit(self, conn, kolkata):
_kolkata_day(conn, "2026-10-01", written=2_000_000_000, read=1_000_000_000)
_hour(conn, "2026-09-30T19:00:00+00:00", active=3600, tmin=30, tmax=44)
local_date, local = selected_local_day(conn, ActivitySelection(), NOW)
text = local_day_text(local_date, local)
assert "2026-10-01" in text and "Asia/Kolkata +05:30" in text
assert "totals so far" in text
assert "W 2.000 GB known · R 1.000 GB known" in text
assert "active 1h 00m" in text and "30–44°C" in text
def test_missing_day_text_is_unavailable(self, conn, kolkata):
local_date, local = selected_local_day(conn, ActivitySelection(), NOW)
assert local is None
assert "local-day evidence unavailable" in local_day_text(local_date, local)
class TestHours:
def _selected_day(self, conn):
_kolkata_day(conn, "2026-09-29")
selection = ActivitySelection()
selection.select_history_date(
"2026-09-29",
HistoryDayIdentity(
"2026-09-29", "Asia/Kolkata",
"2026-09-28T18:30:00+00:00", "2026-09-29T18:30:00+00:00",
),
)
selection.set_view("day")
return selection
def test_hours_only_in_day_view_with_local_and_secondary_utc_labels(self, conn, kolkata):
selection = self._selected_day(conn)
_hour(conn, "2026-09-28T19:00:00+00:00", written=4_000_000_000,
active=600, idle=2400, off=0, unknown=600, tmin=31, tmax=40,
coverage=0.8)
result = readout(conn, selection, NOW)
first = result.hours[0]
assert first["local_label"] == "00:30"
assert first["timezone_label"] == "Asia/Kolkata +05:30"
assert first["utc_label"] == "2026-09-28 19:00 UTC"
assert first["bytes_written"] == 4_000_000_000
text = hour_readout_text(first, "2026-09-29")
assert "00:30 Asia/Kolkata +05:30" in text
assert text.splitlines()[-1] == "2026-09-28 19:00 UTC"
assert "active 10m · idle 40m · off 0m · unknown 10m" in text
assert "31–40°C" in text
def test_live_view_has_no_hours(self, conn, kolkata):
_kolkata_day(conn, "2026-09-29")
assert readout(conn, ActivitySelection(), NOW).hours == ()
def test_missing_hour_is_gap_and_future_hour_is_not(self, conn, kolkata):
_kolkata_day(conn, "2026-10-01")
selection = ActivitySelection()
selection.select_history_date("2026-10-01")
selection.set_view("day")
result = readout(conn, selection, NOW)
past = next(h for h in result.hours if h["local_label"] == "00:30")
future = next(h for h in result.hours if h["local_label"] == "06:30")
assert past["is_gap"] and not past["is_future"]
assert future["is_future"] and not future["is_gap"]
assert "W unavailable · R unavailable" in hour_readout_text(past, "2026-10-01")
class TestLiveIntervals:
def test_interval_labels_are_local_with_secondary_utc_line(self, conn, kolkata):
_sample(conn, "2026-09-30T19:30:00+00:00", 1000, 500)
_sample(conn, "2026-09-30T19:33:00+00:00", 3000, 900, temp=41)
result = readout(conn, ActivitySelection(), NOW)
point = result.live[0]
assert point["start_label"] == "01:00"
assert point["end_label"] == "01:03"
assert point["timezone_label"] == "Asia/Kolkata +05:30"
assert point["bytes_written"] == 2000
assert point["temperature_c"] == 41
text = interval_readout_text(point)
assert "01:00 → 01:03 Asia/Kolkata +05:30" in text
assert text.splitlines()[-1] == "19:30 → 19:33 UTC"
assert "41°C" in text
def test_drive_warning_is_part_of_the_readout(self, conn, kolkata):
_sample(conn, "2026-09-30T19:30:00+00:00", 1000, 500)
_sample(conn, "2026-09-30T19:33:00+00:00", 3000, 900, critical=4)
point = readout(conn, ActivitySelection(), NOW).live[0]
assert "critical warning" in interval_readout_text(point)
def test_segment_boundary_is_unavailable(self, conn, kolkata):
_sample(conn, "2026-09-30T19:30:00+00:00", 1000, 500, segment=1)
_sample(conn, "2026-09-30T19:33:00+00:00", 5, 5, segment=2)
point = readout(conn, ActivitySelection(), NOW).live[0]
assert "segment boundary" in interval_readout_text(point)
assert "W unavailable · R unavailable" in interval_readout_text(point)
class TestTimezone:
def test_utc_zone_still_carries_a_label(self, conn, monkeypatch):
monkeypatch.setenv("TZ", "UTC")
_sample(conn, "2026-09-30T19:30:00+00:00", 1000, 500)
_sample(conn, "2026-09-30T19:33:00+00:00", 3000, 900)
result = readout(conn, ActivitySelection(), NOW)
assert result.timezone_name == "UTC"
assert result.timezone_label == "UTC +00:00"
assert result.live[0]["start_label"] == "19:30"
assert result.live[0]["timezone_label"] == "UTC +00:00"
def test_unknown_zone_falls_back_to_utc(self, conn, monkeypatch):
monkeypatch.setenv("TZ", "Not/AZone")
assert readout(conn, ActivitySelection(), NOW).timezone_name == "UTC"
def test_health_comes_from_the_latest_sample(self, conn, kolkata):
assert readout(conn, ActivitySelection(), NOW).health["model"] == "unknown"
_sample(conn, "2026-09-30T19:30:00+00:00", 1000, 500, temp=38)
assert readout(conn, ActivitySelection(), NOW).health["temp"] == 38
class TestTimeFormatting:
def test_freshness_age_human_lives_here(self):
assert freshness_age_human(30) == "30s ago"
assert freshness_age_human(None) == "unknown age"
def test_local_timestamp_names_the_zone(self):
when = datetime(2026, 9, 30, 20, 0, tzinfo=timezone.utc)
assert local_timestamp(when, "Asia/Kolkata") == (
"2026-10-01 01:30 Asia/Kolkata +05:30"
)
def test_utc_labels(self):
a = datetime(2026, 9, 30, 19, 30, tzinfo=timezone.utc)
b = datetime(2026, 9, 30, 19, 33, tzinfo=timezone.utc)
assert utc_range_label(a, b) == "19:30 → 19:33 UTC"
assert utc_stamp_label(a) == "2026-09-30 19:30 UTC"
def _counters(conn, ts, poh, cycles, unsafe, media, spare, critical=0):
conn.execute(
"INSERT INTO samples (ts, device, data_units_written, data_units_read, "
"percentage_used, bytes_written, bytes_read, power_on_hours, "
"power_cycles, unsafe_shutdowns, media_errors, available_spare, "
"segment_id, temperature_c, critical_warning) "
"VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)",
(ts, "/dev/nvme0n1", 1, 1, 1, 1, 1, poh, cycles, unsafe, media, spare,
1, 35, critical),
)
conn.commit()
class TestCriticalWarning:
def test_zero_decodes_to_nothing_and_each_bit_to_its_meaning(self):
assert decode_critical_warning(0) == ()
assert decode_critical_warning(None) == ()
assert decode_critical_warning(0x01) == ("available spare below threshold",)
assert decode_critical_warning(0x05) == (
"available spare below threshold", "reliability degraded",
)
assert "temperature outside threshold" in decode_critical_warning(0x02)
assert "media in read-only mode" in decode_critical_warning(0x08)
assert "volatile memory backup failed" in decode_critical_warning(0x10)
assert "persistent memory region read-only" in decode_critical_warning(0x20)
assert decode_critical_warning(0x40) == ("unrecognised bits 0x40",)
def test_health_carries_latest_critical_warning_and_badge_follows_it(self, conn, kolkata):
_counters(conn, "2026-09-30T19:00:00+00:00", 10, 1, 0, 0, 100, critical=0)
assert critical_warning_badge(
readout(conn, ActivitySelection(), NOW).health) == ""
_counters(conn, "2026-09-30T19:30:00+00:00", 11, 1, 0, 0, 100, critical=0x04)
health = readout(conn, ActivitySelection(), NOW).health
assert health["critical_warning"] == 0x04
badge = critical_warning_badge(health)
assert "0x04" in badge and "reliability degraded" in badge
def test_no_samples_means_no_badge(self, conn, kolkata):
assert critical_warning_badge(
readout(conn, ActivitySelection(), NOW).health) == ""
class TestDiagnosticsReadout:
def test_diagnostics_are_absent_until_selected(self, conn, kolkata):
assert readout(conn, ActivitySelection(), NOW).diagnostics is None
selection = ActivitySelection()
selection.toggle_diagnostics()
assert selection.diagnostics
assert readout(conn, selection, NOW).diagnostics is not None
selection.toggle_diagnostics()
assert not selection.diagnostics
def test_live_counters_have_deltas_over_the_live_window(self, conn, kolkata):
_counters(conn, "2026-09-30T16:00:00+00:00", 90, 5, 1, 0, 100) # before window
_counters(conn, "2026-09-30T18:00:00+00:00", 100, 6, 1, 0, 100)
_counters(conn, "2026-09-30T19:50:00+00:00", 103, 8, 3, 2, 98, critical=0x02)
selection = ActivitySelection()
selection.toggle_diagnostics()
diag = readout(conn, selection, NOW).diagnostics
assert diag["window_label"] == "last 3h"
assert diag["critical_warning"] == 0x02
assert diag["critical_warning_flags"] == ("temperature outside threshold",)
counters = diag["counters"]
assert counters["power_on_hours"] == {"value": 103, "delta": 13}
assert counters["power_cycles"] == {"value": 8, "delta": 3}
assert counters["unsafe_shutdowns"] == {"value": 3, "delta": 2}
assert counters["media_errors"] == {"value": 2, "delta": 2}
assert counters["available_spare"] == {"value": 98, "delta": -2}
def test_no_delta_across_a_controller_segment_change(self, conn, kolkata):
_counters(conn, "2026-09-30T18:00:00+00:00", 100, 6, 1, 0, 100)
_counters(conn, "2026-09-30T19:50:00+00:00", 5, 1, 0, 0, 100)
conn.execute("UPDATE samples SET segment_id = 2 WHERE ts > '2026-09-30T19'")
conn.commit()
selection = ActivitySelection()
selection.toggle_diagnostics()
counters = readout(conn, selection, NOW).diagnostics["counters"]
assert counters["power_on_hours"] == {"value": 5, "delta": None}
def test_single_sample_has_no_delta(self, conn, kolkata):
_counters(conn, "2026-09-30T19:50:00+00:00", 103, 8, 3, 2, 98)
selection = ActivitySelection()
selection.toggle_diagnostics()
counters = readout(conn, selection, NOW).diagnostics["counters"]
assert counters["power_on_hours"] == {"value": 103, "delta": None}
def test_day_selection_measures_deltas_across_that_local_day(self, conn, kolkata):
selection = TestHours()._selected_day(conn)
_counters(conn, "2026-09-28T18:00:00+00:00", 50, 2, 0, 0, 100)
_counters(conn, "2026-09-29T06:00:00+00:00", 56, 2, 1, 0, 100)
_counters(conn, "2026-09-29T20:00:00+00:00", 99, 9, 9, 9, 50) # after the day
selection.toggle_diagnostics()
diag = readout(conn, selection, NOW).diagnostics
assert diag["window_label"] == "day 2026-09-29"
assert diag["counters"]["power_on_hours"] == {"value": 56, "delta": 6}
assert diag["counters"]["unsafe_shutdowns"]["delta"] == 1
def test_hours_carry_temperature_average(self, conn, kolkata):
selection = TestHours()._selected_day(conn)
_hour(conn, "2026-09-29T00:00:00+00:00", active=1800, idle=1800,
tmin=31, tavg=36.5, tmax=44)
hour = next(h for h in readout(conn, selection, NOW).hours
if h["hour"] == "2026-09-29T00:00:00+00:00")
assert (hour["temperature_min"], hour["temperature_avg"],
hour["temperature_max"]) == (31, 36.5, 44)
def test_history_days_carry_split_and_temperature_range(self, conn, kolkata):
_kolkata_day(conn, "2026-09-29")
_hour(conn, "2026-09-29T00:00:00+00:00", active=1800, idle=1200, off=600,
tmin=30, tavg=34.0, tmax=40)
_hour(conn, "2026-09-29T01:00:00+00:00", active=0, idle=3000, unknown=600,
tmin=28, tavg=30.0, tmax=33)
selection = ActivitySelection()
selection.set_view("history")
selection.toggle_diagnostics()
days = {d["day"]: d for d in readout(conn, selection, NOW).diagnostics["days"]}
day = days["2026-09-29"]
assert (day["active_seconds"], day["idle_seconds"],
day["powered_off_seconds"], day["unknown_seconds"]) == (1800, 4200, 600, 600)
assert (day["temperature_min"], day["temperature_max"]) == (28, 40)
assert day["temperature_avg"] == pytest.approx(32.0)
assert "2026-09-30" not in days # no evidence, no invented split
class TestDiagnosticsText:
def _diag(self, conn, selection):
selection.toggle_diagnostics()
return readout(conn, selection, NOW)
def test_panel_shows_decoded_warning_counters_and_deltas(self, conn, kolkata):
_counters(conn, "2026-09-30T18:00:00+00:00", 100, 6, 1, 0, 100)
_counters(conn, "2026-09-30T19:50:00+00:00", 103, 8, 3, 2, 98, critical=0x05)
text = diagnostics_text(self._diag(conn, ActivitySelection()))
assert "last 3h" in text
assert "0x05" in text and "reliability degraded" in text
assert "Power-on hours" in text and "103" in text and "+3" in text
assert "Unsafe shutdowns" in text and "+2" in text
assert "Available spare" in text and "98%" in text and "-2" in text
def test_no_warning_says_none_and_missing_delta_says_so(self, conn, kolkata):
_counters(conn, "2026-09-30T19:50:00+00:00", 103, 8, 3, 2, 98)
text = diagnostics_text(self._diag(conn, ActivitySelection()))
assert "Critical warning none" in text
assert "Δ n/a" in text
def test_day_view_lists_each_hour_with_temperature_split_and_coverage(self, conn, kolkata):
selection = TestHours()._selected_day(conn)
_hour(conn, "2026-09-29T00:00:00+00:00", active=1800, idle=1200, off=300,
unknown=300, tmin=31, tavg=36.4, tmax=44, coverage=0.75)
text = diagnostics_text(self._diag(conn, selection))
row = next(line for line in text.splitlines() if line.startswith("05:30"))
assert "31/36/44°C" in row
assert "A30m I20m Off5m ?5m" in row
assert "75%" in row
assert any("gap" in line for line in text.splitlines()
if line.startswith("06:30"))
def test_history_view_lists_each_day_with_split_and_temperature(self, conn, kolkata):
_kolkata_day(conn, "2026-09-29")
_hour(conn, "2026-09-29T00:00:00+00:00", active=7200, idle=3600, off=0,
tmin=30, tavg=34.0, tmax=40)
selection = ActivitySelection()
selection.set_view("history")
text = diagnostics_text(self._diag(conn, selection))
row = next(line for line in text.splitlines() if line.startswith("09-29"))
assert "A2h 00m" in row and "I1h 00m" in row and "30/34/40°C" in row
def test_live_view_summarises_interval_temperature(self, conn, kolkata):
for index, (minute, temp) in enumerate(((0, 30), (3, 36), (6, 42))):
conn.execute(
"INSERT INTO samples (ts, device, bytes_written, bytes_read, "
"segment_id, temperature_c) VALUES (?,?,?,?,?,?)",
("2026-09-30T19:%02d:00+00:00" % (50 + minute), "/dev/n", index, index, 1, temp),
)
conn.commit()
text = diagnostics_text(self._diag(conn, ActivitySelection()))
assert "36/39/42°C" in text and "2 intervals" in text # interval ends
+4 -7
View File
@@ -8,7 +8,6 @@ Seams:
- write side: run_collection() → observation store - write side: run_collection() → observation store
- read side: get_status(), compute_projection() → observation store - read side: get_status(), compute_projection() → observation store
""" """
import os
import sqlite3 import sqlite3
from datetime import datetime, timedelta, timezone from datetime import datetime, timedelta, timezone
from pathlib import Path from pathlib import Path
@@ -19,10 +18,9 @@ import sys
sys.path.insert(0, str(Path(__file__).parent.parent / "src")) sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
from fenris.collector import run_collection, normalize_identity from fenris.collector import run_collection
from fenris.store import init_store, get_store_path, SCHEMA_VERSION from fenris.store import init_store, SCHEMA_VERSION
from fenris.monitoring_periods import ensure_period_open, close_period, get_open_period from fenris.monitoring_periods import close_period, get_open_period
from fenris.day_aggregate import derive_day, derive_all_days
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
@@ -154,7 +152,7 @@ class TestSchemaMigration:
# Migrate # Migrate
steps = migrate_to_latest(db) steps = migrate_to_latest(db)
assert steps == 5 # v1→v2→v3→v4→v5→v6 assert steps == 6 # v1→v2→v3→v4→v5→v6→v7
# Verify data preserved # Verify data preserved
conn = sqlite3.connect(str(db)) conn = sqlite3.connect(str(db))
@@ -573,7 +571,6 @@ class TestDisplayStates:
def test_one_sample_awaiting_another_in_tui(self, tmp_path): def test_one_sample_awaiting_another_in_tui(self, tmp_path):
"""One sample → TUI shows awaiting state.""" """One sample → TUI shows awaiting state."""
from fenris.tui import FenrisTuiApp
db = tmp_path / "test.db" db = tmp_path / "test.db"
conn = init_store(db) conn = init_store(db)
conn.execute( conn.execute(
+3 -5
View File
@@ -6,13 +6,11 @@ Tests the thinnest complete write path through the system:
Seam: write side of the observation store database file. Seam: write side of the observation store database file.
""" """
import json
import os import os
import sqlite3 import sqlite3
import tempfile
from datetime import datetime, timezone from datetime import datetime, timezone
from pathlib import Path from pathlib import Path
from typing import Any, Dict, Generator from typing import Any, Dict
import pytest import pytest
@@ -20,8 +18,8 @@ import pytest
import sys import sys
sys.path.insert(0, str(Path(__file__).parent.parent / "src")) sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
from fenris.collector import run_collection, AcquisitionError, InvariantViolationError from fenris.collector import run_collection
from fenris.store import init_store, get_store_path from fenris.store import init_store
# Fixtures # Fixtures
+56 -23
View File
@@ -1,19 +1,20 @@
"""Complete observation day gate tests (issue #94). """Complete observation day condition tests (issues #94, #106).
Verifies that the endurance projection is withheld until at least one Originally a gate (issue #94); ADR 0012 turned it into a contributing
complete local calendar day has been observed within a monitoring period. fact. The projection is no longer withheld until one complete local
calendar day has been observed within a monitoring period, but it says
so while that condition is unmet.
Seams: Seams:
- compute_projection() → gate check via local_days table - compute_projection() → gate check via local_days table
- ProjectionResult.contributing_facts → "waiting for a full local observation day" - ProjectionResult.contributing_facts → "waiting for a full local observation day"
Acceptance criteria: Acceptance criteria:
- Gate-1: No complete local day → UNSUPPORTED with waiting fact - Gate-1: No complete local day → projection renders with waiting fact
- Gate-2: One complete local day → Limited confidence (if other conditions met) - Gate-2: One complete local day → no waiting fact
- Gate-3: Partial days don't satisfy the gate - Gate-3: Partial days don't satisfy the condition
- Gate-4: CLI and TUI share the same gate via compute_projection() - Gate-4: CLI and TUI share the same gate via compute_projection()
""" """
import sqlite3
from datetime import datetime, timedelta, timezone from datetime import datetime, timedelta, timezone
from pathlib import Path from pathlib import Path
@@ -24,8 +25,7 @@ sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
from fenris.store import init_store from fenris.store import init_store
from fenris.monitoring_periods import ensure_period_open from fenris.monitoring_periods import ensure_period_open
from fenris.projection import ( from fenris.projection import (
compute_projection, ConfidenceState, BaselineTier, compute_projection, ConfidenceState,
WARMING_COVERAGE_FLOOR,
) )
@@ -78,8 +78,8 @@ def _insert_day(conn, day, bw=1024*1024*100, coverage=0.95, samples=24):
def _insert_sample(conn, ts, pu=5): def _insert_sample(conn, ts, pu=5):
conn.execute( conn.execute(
"INSERT INTO samples (ts, device, data_units_written, data_units_read, " "INSERT INTO samples (ts, device, data_units_written, data_units_read, "
"percentage_used, bytes_written, bytes_read, power_on_hours) " "percentage_used, bytes_written, bytes_read, power_on_hours, segment_id) "
"VALUES (?, ?, ?, ?, ?, ?, ?, ?)", "VALUES (?, ?, ?, ?, ?, ?, ?, ?, 1)",
(ts, "/dev/nvme0n1", 1000000, 500000, pu, 512000000000, 256000000000, 8765), (ts, "/dev/nvme0n1", 1000000, 500000, pu, 512000000000, 256000000000, 8765),
) )
conn.commit() conn.commit()
@@ -111,14 +111,14 @@ def _open_period(conn, start="2026-09-01T00:00:00+00:00"):
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
# Gate-1: No complete local day → UNSUPPORTED with waiting fact # Gate-1: No complete local day → projection renders with waiting fact
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
class TestGateNoCompleteDay: class TestGateNoCompleteDay:
"""Projection is unavailable before any complete local observation day.""" """Projection still renders before any complete local observation day."""
def test_no_local_days_unsupported(self, store): def test_no_local_days_states_waiting_fact(self, store):
"""With no local_days entries, projection is UNSUPPORTED.""" """With no local_days entries, the projection renders and says it is waiting."""
_insert_baseline(store) _insert_baseline(store)
_insert_segment(store) _insert_segment(store)
_open_period(store) _open_period(store)
@@ -128,11 +128,11 @@ class TestGateNoCompleteDay:
_insert_day(store, d, bw=1024*1024*100) _insert_day(store, d, bw=1024*1024*100)
_insert_sample(store, "2026-09-30T10:00:00+00:00", pu=5) _insert_sample(store, "2026-09-30T10:00:00+00:00", pu=5)
result = compute_projection(store, _clock()) result = compute_projection(store, _clock())
assert result.confidence_state == ConfidenceState.UNSUPPORTED assert result.confidence_state != ConfidenceState.UNSUPPORTED
assert any("full local observation day" in f for f in result.contributing_facts) assert any("full local observation day" in f for f in result.contributing_facts)
assert result.headline_remaining_seconds is None assert result.headline_remaining_seconds is not None
def test_only_partial_local_days_unsupported(self, store): def test_only_partial_local_days_state_waiting_fact(self, store):
"""Partial (incomplete) local days don't satisfy the gate.""" """Partial (incomplete) local days don't satisfy the gate."""
_insert_baseline(store) _insert_baseline(store)
_insert_segment(store) _insert_segment(store)
@@ -146,7 +146,7 @@ class TestGateNoCompleteDay:
d = (datetime(2026, 9, 25) + timedelta(days=i)).strftime("%Y-%m-%d") d = (datetime(2026, 9, 25) + timedelta(days=i)).strftime("%Y-%m-%d")
_insert_local_day(store, d, complete=False, coverage=0.3) _insert_local_day(store, d, complete=False, coverage=0.3)
result = compute_projection(store, _clock()) result = compute_projection(store, _clock())
assert result.confidence_state == ConfidenceState.UNSUPPORTED assert result.confidence_state != ConfidenceState.UNSUPPORTED
assert any("full local observation day" in f for f in result.contributing_facts) assert any("full local observation day" in f for f in result.contributing_facts)
def test_gate_before_warming_check(self, store): def test_gate_before_warming_check(self, store):
@@ -166,7 +166,7 @@ class TestGateNoCompleteDay:
# The key assertion: gate message should NOT appear when gate IS met # The key assertion: gate message should NOT appear when gate IS met
assert not any("full local observation day" in f for f in result.contributing_facts) assert not any("full local observation day" in f for f in result.contributing_facts)
def test_complete_legacy_day_without_trusted_activity_does_not_open_gate( def test_complete_legacy_day_without_trusted_activity_keeps_waiting_fact(
self, store, self, store,
): ):
"""A complete flag cannot make unavailable local activity qualify.""" """A complete flag cannot make unavailable local activity qualify."""
@@ -183,7 +183,40 @@ class TestGateNoCompleteDay:
"WHERE local_date = '2026-09-29'" "WHERE local_date = '2026-09-29'"
) )
result = compute_projection(store, _clock()) result = compute_projection(store, _clock())
assert result.confidence_state == ConfidenceState.UNSUPPORTED assert result.confidence_state != ConfidenceState.UNSUPPORTED
assert any("full local observation day" in fact
for fact in result.contributing_facts)
def test_day_split_by_deliberate_pause_keeps_waiting_fact(self, store):
"""A complete-looking summary cannot span separate monitoring periods."""
_insert_baseline(store)
_insert_segment(store)
for i in range(20):
day = (datetime(2026, 9, 10) + timedelta(days=i)).strftime("%Y-%m-%d")
_insert_day(store, day, bw=1024 * 1024 * 100)
_insert_sample(store, "2026-09-30T10:00:00+00:00", pu=5)
store.executemany(
"INSERT INTO monitoring_periods (started_at, ended_at, end_cause) "
"VALUES (?, ?, ?)",
[
("2026-09-29T00:00:00+00:00", "2026-09-29T12:00:00+00:00", "user_disabled"),
("2026-09-29T13:00:00+00:00", "2026-09-30T00:00:00+00:00", "user_disabled"),
("2026-09-30T00:00:00+00:00", None, None),
],
)
store.commit()
_insert_local_day(
store,
"2026-09-29",
utc_start="2026-09-29T00:00:00+00:00",
utc_end="2026-09-30T00:00:00+00:00",
complete=True,
)
result = compute_projection(store, _clock())
assert result.confidence_state != ConfidenceState.UNSUPPORTED
assert any("full local observation day" in fact assert any("full local observation day" in fact
for fact in result.contributing_facts) for fact in result.contributing_facts)
@@ -257,7 +290,7 @@ class TestGateOneCompleteDay:
class TestGatePartialFirstDay: class TestGatePartialFirstDay:
"""Starting monitoring at noon means the partial first day doesn't count.""" """Starting monitoring at noon means the partial first day doesn't count."""
def test_partial_first_day_not_enough(self, store): def test_partial_first_day_keeps_waiting_fact(self, store):
"""A single incomplete local day (started at noon) doesn't open the gate.""" """A single incomplete local day (started at noon) doesn't open the gate."""
_insert_baseline(store) _insert_baseline(store)
_insert_segment(store, opened_at="2026-09-29T12:00:00+00:00") _insert_segment(store, opened_at="2026-09-29T12:00:00+00:00")
@@ -270,7 +303,7 @@ class TestGatePartialFirstDay:
_insert_local_day(store, "2026-09-29", complete=False, coverage=0.5) _insert_local_day(store, "2026-09-29", complete=False, coverage=0.5)
_insert_local_day(store, "2026-09-30", complete=False, coverage=0.5) _insert_local_day(store, "2026-09-30", complete=False, coverage=0.5)
result = compute_projection(store, _clock()) result = compute_projection(store, _clock())
assert result.confidence_state == ConfidenceState.UNSUPPORTED assert result.confidence_state != ConfidenceState.UNSUPPORTED
assert any("full local observation day" in f for f in result.contributing_facts) assert any("full local observation day" in f for f in result.contributing_facts)
+1 -3
View File
@@ -6,7 +6,7 @@ shared boundary evidence, not duplicated into both days.
Seam: derive._add_unattributed_bytes() → day_aggregates.unattributed_bytes_* Seam: derive._add_unattributed_bytes() → day_aggregates.unattributed_bytes_*
""" """
import sqlite3 import sqlite3
from datetime import datetime, timedelta, timezone from datetime import datetime, timezone
from pathlib import Path from pathlib import Path
import pytest import pytest
@@ -14,8 +14,6 @@ import sys
sys.path.insert(0, str(Path(__file__).parent.parent / "src")) sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
from fenris.collector import run_collection from fenris.collector import run_collection
from fenris.store import init_store
from fenris.monitoring_periods import ensure_period_open
def _make_smartctl(duw: int, dur: int): def _make_smartctl(duw: int, dur: int):
+35 -6
View File
@@ -20,6 +20,7 @@ NOW = datetime(2026, 9, 19, 12, tzinfo=timezone.utc)
@pytest.fixture @pytest.fixture
def dashboard(tmp_path, monkeypatch): def dashboard(tmp_path, monkeypatch):
monkeypatch.setenv("XDG_CONFIG_HOME", str(tmp_path / "prefs")) monkeypatch.setenv("XDG_CONFIG_HOME", str(tmp_path / "prefs"))
monkeypatch.setenv("TZ", "UTC")
class Clock(datetime): class Clock(datetime):
@classmethod @classmethod
@@ -124,6 +125,19 @@ async def test_mouse_inspection_matches_time_axis(dashboard):
assert "09:00 → 09:03 UTC" in text assert "09:00 → 09:03 UTC" in text
@pytest.mark.asyncio
async def test_live_readout_shows_local_time_with_secondary_utc_line(dashboard, monkeypatch):
monkeypatch.setenv("TZ", "Asia/Kolkata")
app = dashboard
async with app.run_test(size=(100, 36)) as pilot:
await pilot.pause()
await pilot.press("left")
text = str(app.query_one("#live-readout").render())
assert "17:24 → 17:27 Asia/Kolkata +05:30" in text
assert text.splitlines()[-1] == "11:54 → 11:57 UTC"
assert "local time" in str(app.query_one("#live-legend").render())
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_theme_control_persists_choice_and_quit_never_pauses(dashboard, monkeypatch): async def test_theme_control_persists_choice_and_quit_never_pauses(dashboard, monkeypatch):
calls = [] calls = []
@@ -144,14 +158,27 @@ async def test_unallocated_volume_survives_day_with_missing_coverage(dashboard,
await pilot.click("#view-history") await pilot.click("#view-history")
graph = dashboard.query_one("#usage-history") graph = dashboard.query_one("#usage-history")
graph.set_data([{ graph.set_data([{
"day": "2026-09-18", "total_bytes": 2_000_000_000, "day": "2026-09-18", "local_label": "2026-09-18",
"unallocated_bytes": 2_000_000_000, "is_gap": True, "timezone_label": "UTC +00:00", "identity": None,
"is_partial": True, "total_bytes": None, "total_written": None, "total_read": None,
"shared_bytes_written": 2_000_000_000, "shared_bytes_read": 0,
"unallocated_bytes_written": 2_000_000_000,
"unallocated_bytes_read": 0, "activity_state": "incomplete",
"is_gap": True, "is_partial": True,
}]) }])
readout = str(dashboard.query_one("#bar-readout").render()) readout = str(dashboard.query_one("#bar-readout").render())
assert "W 2.000 GB unallocated" in readout assert "unallocated W 2.000 GB" in readout
assert "R unavailable" in readout and "gap" in readout assert "W unavailable · R unavailable" in readout
if size[0] >= 80: if size[0] >= 80:
graph.set_data([{
"day": "2026-09-18", "local_label": "2026-09-18",
"timezone_label": "UTC +00:00", "identity": None,
"total_bytes": 2_000_000_000, "total_written": 2_000_000_000,
"total_read": None, "shared_bytes_written": 2_000_000_000,
"shared_bytes_read": 0, "unallocated_bytes_written": 0,
"unallocated_bytes_read": 0, "activity_state": "incomplete",
"is_gap": False, "is_partial": True,
}])
plot = str(dashboard.query_one("#bar-render").render()) plot = str(dashboard.query_one("#bar-render").render())
assert any(0x2801 <= ord(c) <= 0x28ff for c in plot) assert any(0x2801 <= ord(c) <= 0x28ff for c in plot)
graph.measure = "read" graph.measure = "read"
@@ -167,7 +194,9 @@ async def test_small_terminal_hour_readout_does_not_invent_zero(dashboard, state
await pilot.click("#view-day") await pilot.click("#view-day")
graph = dashboard.query_one("#usage-history") graph = dashboard.query_one("#usage-history")
graph.set_hour_data([{ graph.set_hour_data([{
"hour": "2026-09-18T12:00:00+00:00", "local_label": "12", "hour": "2026-09-18T12:00:00+00:00", "local_label": "12:00",
"timezone_label": "UTC +00:00",
"utc_label": "2026-09-18 12:00 UTC",
"is_gap": state == "gap", "is_future": state == "future", "is_gap": state == "gap", "is_future": state == "future",
}]) }])
graph._hourly_selected = 0 graph._hourly_selected = 0
+3 -4
View File
@@ -7,9 +7,8 @@ From spec §5.4, §3.3, ST-4, ST-5:
whose classification is known whose classification is known
- No absent hour ever interpolated/estimated/fabricated (FL-3) - No absent hour ever interpolated/estimated/fabricated (FL-3)
""" """
import sqlite3
import sys import sys
from datetime import datetime, timezone, timedelta from datetime import datetime, timezone
from pathlib import Path from pathlib import Path
import pytest import pytest
@@ -18,8 +17,8 @@ sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
from fenris.store import init_store from fenris.store import init_store
from fenris.monitoring_periods import ensure_period_open, close_period from fenris.monitoring_periods import ensure_period_open, close_period
from fenris.day_aggregate import derive_day, derive_all_days, DayAggregate from fenris.day_aggregate import derive_day, derive_all_days
from fenris.hour_classify import HourSplit, ACTIVE_THRESHOLD_BYTES from fenris.hour_classify import HourSplit
@pytest.fixture @pytest.fixture
+1 -2
View File
@@ -11,11 +11,10 @@ Four splits sum to exactly 3600s. Disabled time is never an hour state.
import sys import sys
from pathlib import Path from pathlib import Path
import pytest
sys.path.insert(0, str(Path(__file__).parent.parent / "src")) sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
from fenris.hour_classify import classify_hour, HourSplit, ACTIVE_THRESHOLD_BYTES from fenris.hour_classify import classify_hour, ACTIVE_THRESHOLD_BYTES
HOUR_SECONDS = 3600 HOUR_SECONDS = 3600
-1
View File
@@ -7,7 +7,6 @@ From spec §2.3:
Padded and unpadded renderings of the same field yield byte-identical stored values. Padded and unpadded renderings of the same field yield byte-identical stored values.
""" """
import pytest
import sys import sys
from pathlib import Path from pathlib import Path
+11 -9
View File
@@ -9,12 +9,9 @@ Covers:
Spec: ADR 0008, §8.4, §8.5, §8.6, §8.7, §8.8 Spec: ADR 0008, §8.4, §8.5, §8.6, §8.7, §8.8
""" """
import os
import sqlite3 import sqlite3
import tempfile
from datetime import datetime, timedelta, timezone
from pathlib import Path from pathlib import Path
from unittest.mock import patch, MagicMock, PropertyMock from unittest.mock import patch, MagicMock
import pytest import pytest
@@ -24,7 +21,6 @@ sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
from fenris.init_system import ( from fenris.init_system import (
InitSystem, InitSystem,
detect_init_system, detect_init_system,
get_init_system,
reset_init_system_cache, reset_init_system_cache,
_systemd_enable, _systemd_enable,
_systemd_disable, _systemd_disable,
@@ -41,8 +37,6 @@ from fenris.init_system import (
collect_now, collect_now,
query_service_state, query_service_state,
journal_hint, journal_hint,
FENRIS_SV_DIR,
FENRIS_SERVICE_LINK,
COLLECT_TIMEOUT_S, COLLECT_TIMEOUT_S,
) )
from fenris.store import init_store from fenris.store import init_store
@@ -685,11 +679,19 @@ class TestEdgeCases:
def test_runit_collect_missing_script(self): def test_runit_collect_missing_script(self):
"""Runit collect exits when fenris-collect script not found.""" """Runit collect exits when fenris-collect script not found."""
with patch("fenris.init_system.Path") as mock_path: with patch("fenris.init_system.subprocess") as mock_sub, \
mock_path.return_value.exists.return_value = False patch("fenris.init_system.Path") as mock_path:
missing = MagicMock()
missing.exists.return_value = False
# Fallback path is built via Path(...).parent... / "src" / ...
missing.parent = missing
missing.__truediv__.return_value = missing
mock_path.return_value = missing
mock_sub.run.return_value = MagicMock(returncode=1)
with pytest.raises(SystemExit) as exc_info: with pytest.raises(SystemExit) as exc_info:
_runit_collect() _runit_collect()
assert exc_info.value.code == 1 assert exc_info.value.code == 1
mock_sub.run.assert_not_called()
def test_systemd_query_state_timeout(self): def test_systemd_query_state_timeout(self):
"""Systemd query state handles subprocess timeout.""" """Systemd query state handles subprocess timeout."""
+251
View File
@@ -0,0 +1,251 @@
"""Additional smartctl diagnostics (issue #111).
Field list fixed from real `smartctl -a -j` output (smartctl 7.5, NVMe 1.4):
nvme_smart_health_information_log carries warning_temp_time, critical_comp_time,
num_err_log_entries, host_reads, host_writes and controller_busy_time. The
thermal-management transition fields (thm_temp1/2_trans_count, thm_temp1/2_total_time)
appear only on drives that implement them, so they stay nullable.
"""
import sqlite3
import sys
from datetime import datetime, timezone
from pathlib import Path
import pytest
sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
from fenris.activity_readout import diagnostics_text, readout
from fenris.activity_selection import ActivitySelection
from fenris.collector import acquire_from_smartctl, run_collection
from fenris.store import SCHEMA_VERSION, init_store, migrate_to_latest
NEW_COLUMNS = (
"host_reads", "host_writes", "controller_busy_time", "num_err_log_entries",
"warning_temp_time", "critical_comp_time",
"thm_temp1_trans_count", "thm_temp1_total_time",
"thm_temp2_trans_count", "thm_temp2_total_time",
)
def _smartctl(**extra_log):
"""Shape of real smartctl -a -j output for an NVMe drive."""
log = {
"critical_warning": 0, "temperature": 37, "available_spare": 100,
"available_spare_threshold": 5, "percentage_used": 52,
"data_units_read": 207986339, "data_units_written": 202978899,
"host_reads": 3543447796, "host_writes": 2458441042,
"controller_busy_time": 61626, "power_cycles": 5324,
"power_on_hours": 11906, "unsafe_shutdowns": 159, "media_errors": 0,
"num_err_log_entries": 0, "warning_temp_time": 0, "critical_comp_time": 0,
"temperature_sensors": [37],
}
log.update(extra_log)
return {
"nvme_smart_health_information_log": log,
"user_capacity": {"bytes": 512110190592},
"model_name": "Drive", "serial_number": "SN1", "firmware_version": "FW1",
}
class TestAcquisition:
def test_real_fields_are_captured(self):
got = acquire_from_smartctl(_smartctl())
assert got["host_reads"] == 3543447796
assert got["host_writes"] == 2458441042
assert got["controller_busy_time"] == 61626
assert got["num_err_log_entries"] == 0
assert got["warning_temp_time"] == 0
assert got["critical_comp_time"] == 0
def test_absent_thermal_management_fields_are_none_not_zero(self):
got = acquire_from_smartctl(_smartctl())
for key in ("thm_temp1_trans_count", "thm_temp1_total_time",
"thm_temp2_trans_count", "thm_temp2_total_time"):
assert got[key] is None
def test_thermal_management_fields_captured_when_reported(self):
got = acquire_from_smartctl(_smartctl(
thm_temp1_trans_count=3, thm_temp1_total_time=120,
thm_temp2_trans_count=1, thm_temp2_total_time=45))
assert (got["thm_temp1_trans_count"], got["thm_temp1_total_time"]) == (3, 120)
assert (got["thm_temp2_trans_count"], got["thm_temp2_total_time"]) == (1, 45)
def test_missing_optional_counters_do_not_fail_the_run(self):
data = _smartctl()
for key in ("host_reads", "host_writes", "controller_busy_time",
"num_err_log_entries", "warning_temp_time", "critical_comp_time"):
del data["nvme_smart_health_information_log"][key]
got = acquire_from_smartctl(data)
assert got["host_reads"] is None and got["warning_temp_time"] is None
@pytest.fixture
def sysfs(tmp_path):
ctrl = tmp_path / "nvme0"
ctrl.mkdir()
for name, value in (("subsysnqn", "nqn.test"), ("model", "Drive"),
("serial", "SN1"), ("firmware_rev", "FW1")):
(ctrl / name).write_text(value + "\n")
return ctrl
class _Clock:
def utcnow(self):
return datetime(2026, 9, 1, 12, 0, tzinfo=timezone.utc)
def test_collection_persists_new_fields(tmp_path, sysfs):
config = {"device": "/dev/nvme0", "store_path": str(tmp_path / "o.db")}
result = run_collection(smartctl_data=_smartctl(thm_temp1_trans_count=3),
sysfs_path=sysfs, config=config, clock=_Clock())
assert result["ok"], result
conn = sqlite3.connect(config["store_path"])
conn.row_factory = sqlite3.Row
row = conn.execute("SELECT * FROM samples").fetchone()
assert row["host_reads"] == 3543447796
assert row["controller_busy_time"] == 61626
assert row["thm_temp1_trans_count"] == 3
assert row["thm_temp2_trans_count"] is None
def _legacy_store(path):
"""A populated schema-6 store, as shipped before this change."""
conn = init_store(path)
for column in reversed(NEW_COLUMNS):
conn.execute(f"ALTER TABLE samples DROP COLUMN {column}")
conn.execute("PRAGMA user_version=6")
for i in range(3):
conn.execute(
"INSERT INTO samples (ts, device, bytes_written, bytes_read, "
"power_on_hours, critical_warning, segment_id) VALUES (?,?,?,?,?,?,1)",
("2026-09-30T1%d:00:00+00:00" % i, "/dev/nvme0", 10 + i, 5, 100 + i, 0))
conn.commit()
conn.close()
class TestMigration:
def test_schema_version_is_seven(self):
assert SCHEMA_VERSION == 7
def test_populated_legacy_store_keeps_rows_and_gains_null_columns(self, tmp_path):
db = tmp_path / "o.db"
_legacy_store(db)
before = sqlite3.connect(db).execute(
"SELECT id, ts, device, bytes_written, power_on_hours FROM samples "
"ORDER BY id").fetchall()
assert migrate_to_latest(db) == 1
conn = sqlite3.connect(db)
assert conn.execute("PRAGMA user_version").fetchone()[0] == 7
assert conn.execute(
"SELECT id, ts, device, bytes_written, power_on_hours FROM samples "
"ORDER BY id").fetchall() == before
cols = {r[1] for r in conn.execute("PRAGMA table_info(samples)")}
assert set(NEW_COLUMNS) <= cols
nulls = conn.execute(
"SELECT %s FROM samples" % " OR ".join(c + " IS NOT NULL" for c in NEW_COLUMNS)
).fetchall()
assert nulls == [(0,)] * 3 # legacy rows stay unknown, never zero
def test_migration_is_idempotent_and_init_store_applies_it(self, tmp_path):
db = tmp_path / "o.db"
_legacy_store(db)
conn = init_store(db)
assert conn.execute("PRAGMA user_version").fetchone()[0] == 7
conn.close()
assert migrate_to_latest(db) == 0
def test_pending_payload_without_new_fields_still_publishes(self, tmp_path):
"""Observations staged by the previous version lack the new keys."""
db = tmp_path / "o.db"
conn = init_store(db)
from fenris.collector import write_sample
sample = {k: v for k, v in acquire_from_smartctl(_smartctl()).items()
if k not in NEW_COLUMNS}
sample.update(ts="2026-09-01T12:00:00+00:00", device="/dev/nvme0")
write_sample(sample, {"subnqn": "nqn.test"}, conn,
datetime(2026, 9, 1, 12, tzinfo=timezone.utc))
assert conn.execute("SELECT host_reads FROM samples").fetchone() == (None,)
def test_rollback_notes_procedure_restores_prior_schema(self, tmp_path):
"""Documented rollback: drop the columns, set user_version back to 6."""
db = tmp_path / "o.db"
_legacy_store(db)
migrate_to_latest(db)
conn = sqlite3.connect(db)
conn.execute(
"UPDATE samples SET host_reads = 1 WHERE id = 1")
for column in NEW_COLUMNS:
conn.execute(f"ALTER TABLE samples DROP COLUMN {column}")
conn.execute("PRAGMA user_version=6")
conn.commit()
assert conn.execute("SELECT COUNT(*) FROM samples").fetchone() == (3,)
cols = {r[1] for r in conn.execute("PRAGMA table_info(samples)")}
assert not set(NEW_COLUMNS) & cols
NOW = datetime(2026, 9, 30, 20, 0, tzinfo=timezone.utc)
def _diag_sample(conn, ts, **values):
cols = ["ts", "device", "bytes_written", "bytes_read", "segment_id"] + list(values)
conn.execute(
"INSERT INTO samples (%s) VALUES (%s)" % (
",".join(cols), ",".join("?" * len(cols))),
[ts, "/dev/nvme0n1", 1, 1, 1] + list(values.values()))
conn.commit()
class TestDiagnosticsPanel:
@pytest.fixture
def conn(self, tmp_path):
c = init_store(tmp_path / "o.db")
yield c
c.close()
def _text(self, conn):
selection = ActivitySelection()
selection.toggle_diagnostics()
return diagnostics_text(readout(conn, selection, NOW))
def test_new_counters_show_value_and_delta(self, conn):
_diag_sample(conn, "2026-09-30T18:00:00+00:00", host_reads=1000,
host_writes=500, controller_busy_time=60,
num_err_log_entries=0, warning_temp_time=2,
critical_comp_time=0)
_diag_sample(conn, "2026-09-30T19:50:00+00:00", host_reads=1300,
host_writes=550, controller_busy_time=65,
num_err_log_entries=1, warning_temp_time=2,
critical_comp_time=0)
text = self._text(conn)
assert "Host reads 1300 Δ +300" in text
assert "Host writes 550 Δ +50" in text
assert "Controller busy time 65 min Δ +5" in text
assert "Error log entries 1 Δ +1" in text
assert "Warning temperature time 2 min Δ ±0" in text
assert "Critical temperature time 0 min Δ ±0" in text
def test_legacy_rows_read_n_a_and_absent_thermal_management_is_hidden(self, conn):
_diag_sample(conn, "2026-09-30T19:50:00+00:00", power_on_hours=5)
text = self._text(conn)
assert "Host reads n/a" in text
assert "Thermal management" not in text
def test_thermal_management_shown_when_the_drive_reports_it(self, conn):
_diag_sample(conn, "2026-09-30T19:50:00+00:00", thm_temp1_trans_count=3,
thm_temp1_total_time=120, thm_temp2_trans_count=1,
thm_temp2_total_time=45)
text = self._text(conn)
assert "Thermal management 1 transitions 3 Δ n/a" in text
assert "Thermal management 1 time 120 s Δ n/a" in text
assert "Thermal management 2 transitions 1 Δ n/a" in text
def test_unmigrated_store_still_renders_diagnostics(self, tmp_path):
"""The dashboard may open a store before the upgrade migrates it."""
db = tmp_path / "legacy.db"
_legacy_store(db)
conn = sqlite3.connect(db)
selection = ActivitySelection()
selection.toggle_diagnostics()
text = diagnostics_text(readout(conn, selection, NOW))
assert "Host reads n/a" in text and "Power-on hours" in text
+6 -4
View File
@@ -7,11 +7,9 @@ Covers:
- TPH-#63: Horizon anchoring at evidence endpoint - TPH-#63: Horizon anchoring at evidence endpoint
- TPH-#64: Burst/habit checks with unknown daily shares - TPH-#64: Burst/habit checks with unknown daily shares
""" """
import sqlite3
from datetime import datetime, timedelta, timezone from datetime import datetime, timedelta, timezone
from pathlib import Path from pathlib import Path
import pytest
import sys import sys
sys.path.insert(0, str(Path(__file__).parent.parent / "src")) sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
@@ -19,8 +17,8 @@ from fenris.store import init_store
from fenris.monitoring_periods import ensure_period_open, close_period from fenris.monitoring_periods import ensure_period_open, close_period
from fenris.derive import derive_hours_from_interval from fenris.derive import derive_hours_from_interval
from fenris.day_aggregate import derive_day from fenris.day_aggregate import derive_day
from fenris.projection import compute_projection, ConfidenceState, STALENESS_HOURS from fenris.projection import compute_projection
from fenris.tui import _query_live_graph_data, _query_daily_graph_data from fenris.activity_readout import _query_live_graph_data
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
@@ -211,6 +209,8 @@ class TestStalenessFact:
_insert_baseline(conn) _insert_baseline(conn)
base = datetime(2026, 9, 15, 12, 0, 0, tzinfo=timezone.utc) base = datetime(2026, 9, 15, 12, 0, 0, tzinfo=timezone.utc)
ensure_period_open(conn, base)
conn.commit()
for i in range(14): for i in range(14):
day = (base + timedelta(days=i)).strftime("%Y-%m-%d") day = (base + timedelta(days=i)).strftime("%Y-%m-%d")
_insert_day(conn, day, bw=10*1024*1024*1024) _insert_day(conn, day, bw=10*1024*1024*1024)
@@ -234,6 +234,8 @@ class TestStalenessFact:
_insert_baseline(conn) _insert_baseline(conn)
base = datetime(2026, 9, 18, 12, 0, 0, tzinfo=timezone.utc) base = datetime(2026, 9, 18, 12, 0, 0, tzinfo=timezone.utc)
ensure_period_open(conn, base)
conn.commit()
for i in range(14): for i in range(14):
day = (base + timedelta(days=i)).strftime("%Y-%m-%d") day = (base + timedelta(days=i)).strftime("%Y-%m-%d")
_insert_day(conn, day, bw=10*1024*1024*1024) _insert_day(conn, day, bw=10*1024*1024*1024)
+2 -4
View File
@@ -6,7 +6,6 @@ These tests verify that:
3. Edge cases like zero-delta intervals and unknown daily shares are handled 3. Edge cases like zero-delta intervals and unknown daily shares are handled
4. qualifying_days_progress shows honest qualifying day count 4. qualifying_days_progress shows honest qualifying day count
""" """
import sqlite3
from datetime import datetime, timedelta, timezone from datetime import datetime, timedelta, timezone
from pathlib import Path from pathlib import Path
@@ -15,10 +14,9 @@ import sys
sys.path.insert(0, str(Path(__file__).parent.parent / "src")) sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
from fenris.store import init_store from fenris.store import init_store
from fenris.monitoring_periods import ensure_period_open, close_period from fenris.monitoring_periods import ensure_period_open
from fenris.projection import ( from fenris.projection import (
compute_projection, ConfidenceState, BaselineTier, compute_projection, ConfidenceState,
WARMING_MIN_DAYS, WARMING_COVERAGE_FLOOR, WARMING_MAX_LOW_COVERAGE,
) )
+18 -19
View File
@@ -5,7 +5,6 @@ Covers:
- TPH-11: Single maker-credit placement, vendor wear under Drive health - TPH-11: Single maker-credit placement, vendor wear under Drive health
- Preserve: continuity, pause block, quit rail, auth banner - Preserve: continuity, pause block, quit rail, auth banner
""" """
import sqlite3
from datetime import datetime, timedelta, timezone from datetime import datetime, timedelta, timezone
from pathlib import Path from pathlib import Path
from unittest.mock import patch from unittest.mock import patch
@@ -93,8 +92,8 @@ class TestFenrisIdentity:
store_path=tmp_path / "nonexistent.db", store_path=tmp_path / "nonexistent.db",
refresh_interval_s=0.2, refresh_interval_s=0.2,
) )
async with app.run_test(size=(120, 24)) as pilot: async with app.run_test(size=(120, 24)):
headline = str(app.query_one("#headline-band").render()) str(app.query_one("#headline-band").render())
assert "🐺 Fenris by Bongbetic" in str(app.query_one("#identity").render()) assert "🐺 Fenris by Bongbetic" in str(app.query_one("#identity").render())
@pytest.mark.asyncio @pytest.mark.asyncio
@@ -105,8 +104,8 @@ class TestFenrisIdentity:
refresh_interval_s=0.2, refresh_interval_s=0.2,
) )
# Simulate narrow terminal that can't render wolf # Simulate narrow terminal that can't render wolf
async with app.run_test(size=(60, 24)) as pilot: async with app.run_test(size=(60, 24)):
headline = str(app.query_one("#headline-band").render()) str(app.query_one("#headline-band").render())
# Either shows wolf or fallback - both are acceptable # Either shows wolf or fallback - both are acceptable
assert "Fenris by Bongbetic" in str(app.query_one("#identity").render()) assert "Fenris by Bongbetic" in str(app.query_one("#identity").render())
@@ -117,7 +116,7 @@ class TestFenrisIdentity:
store_path=tmp_path / "nonexistent.db", store_path=tmp_path / "nonexistent.db",
refresh_interval_s=0.2, refresh_interval_s=0.2,
) )
async with app.run_test(size=(120, 24)) as pilot: async with app.run_test(size=(120, 24)):
headline = str(app.query_one("#headline-band").render()) headline = str(app.query_one("#headline-band").render())
# No replacement character (U+FFFD) should appear # No replacement character (U+FFFD) should appear
assert "\ufffd" not in headline.lower() assert "\ufffd" not in headline.lower()
@@ -137,7 +136,7 @@ class TestFenrisIdentity:
conn.close() conn.close()
app = FenrisTuiApp(store_path=tmp_path / "test.db") app = FenrisTuiApp(store_path=tmp_path / "test.db")
async with app.run_test(size=(120, 24)) as pilot: async with app.run_test(size=(120, 24)):
headline = str(app.query_one("#headline-band").render()) headline = str(app.query_one("#headline-band").render())
# Identity appears once, lifespan is separate data # Identity appears once, lifespan is separate data
assert "🐺 Fenris by Bongbetic" in str(app.query_one("#identity").render()) assert "🐺 Fenris by Bongbetic" in str(app.query_one("#identity").render())
@@ -160,7 +159,7 @@ class TestSingleMakerCredit:
conn.close() conn.close()
app = FenrisTuiApp(store_path=tmp_path / "test.db") app = FenrisTuiApp(store_path=tmp_path / "test.db")
async with app.run_test(size=(120, 24)) as pilot: async with app.run_test(size=(120, 24)):
strip = str(app.query_one("#service-strip").render()) strip = str(app.query_one("#service-strip").render())
# "by Bongbetic" should NOT appear in service strip # "by Bongbetic" should NOT appear in service strip
assert "by Bongbetic" not in strip assert "by Bongbetic" not in strip
@@ -172,15 +171,15 @@ class TestSingleMakerCredit:
store_path=tmp_path / "nonexistent.db", store_path=tmp_path / "nonexistent.db",
refresh_interval_s=0.2, refresh_interval_s=0.2,
) )
async with app.run_test(size=(120, 24)) as pilot: async with app.run_test(size=(120, 24)):
headline = str(app.query_one("#headline-band").render()) str(app.query_one("#headline-band").render())
assert "Fenris by Bongbetic" in str(app.query_one("#identity").render()) assert "Fenris by Bongbetic" in str(app.query_one("#identity").render())
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_empty_store_no_maker_credit_in_strip(self, tmp_path): async def test_empty_store_no_maker_credit_in_strip(self, tmp_path):
"""Empty store: no maker credit in service strip.""" """Empty store: no maker credit in service strip."""
app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db") app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db")
async with app.run_test(size=(120, 24)) as pilot: async with app.run_test(size=(120, 24)):
strip = str(app.query_one("#service-strip").render()) strip = str(app.query_one("#service-strip").render())
assert "by Bongbetic" not in strip assert "by Bongbetic" not in strip
@@ -191,7 +190,7 @@ class TestSingleMakerCredit:
db = tmp_path / "test.db" db = tmp_path / "test.db"
db.write_bytes(b"not a database") db.write_bytes(b"not a database")
app = FenrisTuiApp(store_path=db) app = FenrisTuiApp(store_path=db)
async with app.run_test(size=(120, 24)) as pilot: async with app.run_test(size=(120, 24)):
strip = str(app.query_one("#service-strip").render()) strip = str(app.query_one("#service-strip").render())
assert "by Bongbetic" not in strip assert "by Bongbetic" not in strip
@@ -212,7 +211,7 @@ class TestDriveHealthVendorWear:
conn.close() conn.close()
app = FenrisTuiApp(store_path=tmp_path / "test.db") app = FenrisTuiApp(store_path=tmp_path / "test.db")
async with app.run_test(size=(120, 24)) as pilot: async with app.run_test(size=(120, 24)):
health = str(app.query_one("#drive-health").render()) health = str(app.query_one("#drive-health").render())
# Vendor wear should be present with health context # Vendor wear should be present with health context
assert "vendor wear" in health.lower() assert "vendor wear" in health.lower()
@@ -243,7 +242,7 @@ class TestDriveHealthVendorWear:
conn.close() conn.close()
app = FenrisTuiApp(store_path=tmp_path / "test.db") app = FenrisTuiApp(store_path=tmp_path / "test.db")
async with app.run_test(size=(120, 24)) as pilot: async with app.run_test(size=(120, 24)):
health = str(app.query_one("#drive-health").render()) health = str(app.query_one("#drive-health").render())
# Should show 0% used or honest zero, not crash # Should show 0% used or honest zero, not crash
assert "vendor wear" in health.lower() assert "vendor wear" in health.lower()
@@ -265,7 +264,7 @@ class TestPreservedBehavior:
"last_collect_ok": True, "last_collect_age_s": 60, "last_collect_ok": True, "last_collect_age_s": 60,
"last_collect_reason": None, "last_collect_reason": None,
}): }):
async with app.run_test(size=(120, 24)) as pilot: async with app.run_test(size=(120, 24)):
strip = str(app.query_one("#service-strip").render()) strip = str(app.query_one("#service-strip").render())
assert "continuity" in strip.lower() assert "continuity" in strip.lower()
assert "monitoring" in strip.lower() assert "monitoring" in strip.lower()
@@ -274,7 +273,7 @@ class TestPreservedBehavior:
async def test_quit_rail_preserved(self, tmp_path): async def test_quit_rail_preserved(self, tmp_path):
"""Separate q Quit TUI rail preserved.""" """Separate q Quit TUI rail preserved."""
app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db") app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db")
async with app.run_test(size=(120, 24)) as pilot: async with app.run_test(size=(120, 24)):
rail = str(app.query_one("#action-rail").render()) rail = str(app.query_one("#action-rail").render())
assert "q Quit TUI" in rail assert "q Quit TUI" in rail
@@ -286,11 +285,11 @@ class TestPreservedBehavior:
refresh_interval_s=0.2, refresh_interval_s=0.2,
) )
async with app.run_test(size=(120, 24)) as pilot: async with app.run_test(size=(120, 24)) as pilot:
headline = str(app.query_one("#headline-band").render()) str(app.query_one("#headline-band").render())
assert "polkit" in str(app.query_one("#auth-notice").render()).lower() assert "polkit" in str(app.query_one("#auth-notice").render()).lower()
# Should clear after first tick # Should clear after first tick
await pilot.pause(0.25) await pilot.pause(0.25)
headline_after = str(app.query_one("#headline-band").render()) str(app.query_one("#headline-band").render())
assert not app.query_one("#auth-notice").display assert not app.query_one("#auth-notice").display
@pytest.mark.asyncio @pytest.mark.asyncio
@@ -312,7 +311,7 @@ class TestPreservedBehavior:
"last_collect_ok": None, "last_collect_age_s": None, "last_collect_ok": None, "last_collect_age_s": None,
"last_collect_reason": None, "last_collect_reason": None,
}): }):
async with app.run_test(size=(120, 24)) as pilot: async with app.run_test(size=(120, 24)):
banner = str(app.query_one("#paused-banner").render()) banner = str(app.query_one("#paused-banner").render())
assert "paused" in banner.lower() assert "paused" in banner.lower()
assert "deliberate" in banner.lower() assert "deliberate" in banner.lower()
+10 -15
View File
@@ -8,7 +8,6 @@ Covers:
- AC80-5: Theme roles for graph rendering - AC80-5: Theme roles for graph rendering
- AC80-6: Headless interaction tests with temporary user config - AC80-6: Headless interaction tests with temporary user config
""" """
import json
import os import os
from datetime import datetime, timedelta, timezone from datetime import datetime, timedelta, timezone
from pathlib import Path from pathlib import Path
@@ -21,15 +20,12 @@ sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
from fenris.store import init_store from fenris.store import init_store
from fenris.preferences import ( from fenris.preferences import (
load_preferences,
save_preferences, save_preferences,
get_preference_path,
) )
from fenris.themes import get_theme, get_graph_colors, THEME_NAMES from fenris.themes import get_graph_colors, THEME_NAMES
from fenris.status_composition import ( from fenris.status_composition import (
StatusState, StatusState,
compose_status, compose_status,
render_status_tui,
) )
@@ -100,7 +96,7 @@ class TestPresetLoading:
config_home = _make_prefs_dir(tmp_path) config_home = _make_prefs_dir(tmp_path)
with patch.dict(os.environ, {"XDG_CONFIG_HOME": str(config_home)}): with patch.dict(os.environ, {"XDG_CONFIG_HOME": str(config_home)}):
app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db") app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db")
async with app.run_test() as pilot: async with app.run_test():
# Theme should be fenris-amber # Theme should be fenris-amber
assert app.theme == "fenris-chalktone" assert app.theme == "fenris-chalktone"
@@ -113,7 +109,7 @@ class TestPresetLoading:
with patch.dict(os.environ, {"XDG_CONFIG_HOME": str(config_home)}): with patch.dict(os.environ, {"XDG_CONFIG_HOME": str(config_home)}):
save_preferences(theme="nord", reduced_motion=False) save_preferences(theme="nord", reduced_motion=False)
app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db") app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db")
async with app.run_test() as pilot: async with app.run_test():
assert app.theme == "fenris-nord" assert app.theme == "fenris-nord"
@pytest.mark.asyncio @pytest.mark.asyncio
@@ -125,20 +121,19 @@ class TestPresetLoading:
with patch.dict(os.environ, {"XDG_CONFIG_HOME": str(config_home)}): with patch.dict(os.environ, {"XDG_CONFIG_HOME": str(config_home)}):
save_preferences(theme="high_contrast", reduced_motion=False) save_preferences(theme="high_contrast", reduced_motion=False)
app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db") app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db")
async with app.run_test() as pilot: async with app.run_test():
assert app.theme == "fenris-high-contrast" assert app.theme == "fenris-high-contrast"
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_tui_applies_reduced_motion_from_prefs(self, tmp_path): async def test_tui_applies_reduced_motion_from_prefs(self, tmp_path):
"""TUI respects reduced_motion preference.""" """TUI respects reduced_motion preference."""
from fenris.tui import FenrisTuiApp from fenris.tui import FenrisTuiApp
from fenris.status_composition import compose_status
config_home = _make_prefs_dir(tmp_path) config_home = _make_prefs_dir(tmp_path)
with patch.dict(os.environ, {"XDG_CONFIG_HOME": str(config_home)}): with patch.dict(os.environ, {"XDG_CONFIG_HOME": str(config_home)}):
save_preferences(theme="amber", reduced_motion=True) save_preferences(theme="amber", reduced_motion=True)
app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db") app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db")
async with app.run_test() as pilot: async with app.run_test():
# The app should have reduced_motion set # The app should have reduced_motion set
assert app._reduced_motion is True assert app._reduced_motion is True
@@ -237,7 +232,7 @@ class TestPersistence:
with patch.dict(os.environ, {"XDG_CONFIG_HOME": str(config_home)}): with patch.dict(os.environ, {"XDG_CONFIG_HOME": str(config_home)}):
# First run: change theme via preferences API # First run: change theme via preferences API
app1 = FenrisTuiApp(store_path=tmp_path / "nonexistent.db") app1 = FenrisTuiApp(store_path=tmp_path / "nonexistent.db")
async with app1.run_test() as pilot: async with app1.run_test():
save_preferences(theme="nord", reduced_motion=False) save_preferences(theme="nord", reduced_motion=False)
app1._current_theme_name = "nord" app1._current_theme_name = "nord"
app1.theme = "fenris-nord" app1.theme = "fenris-nord"
@@ -246,7 +241,7 @@ class TestPersistence:
# Second run: theme should persist # Second run: theme should persist
app2 = FenrisTuiApp(store_path=tmp_path / "nonexistent.db") app2 = FenrisTuiApp(store_path=tmp_path / "nonexistent.db")
async with app2.run_test() as pilot: async with app2.run_test():
assert app2.theme == theme_after assert app2.theme == theme_after
@pytest.mark.asyncio @pytest.mark.asyncio
@@ -334,7 +329,7 @@ class TestReducedMotion:
config_home = _make_prefs_dir(tmp_path) config_home = _make_prefs_dir(tmp_path)
with patch.dict(os.environ, {"XDG_CONFIG_HOME": str(config_home)}): with patch.dict(os.environ, {"XDG_CONFIG_HOME": str(config_home)}):
app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db") app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db")
async with app.run_test() as pilot: async with app.run_test():
# The app should check for reduced motion on mount # The app should check for reduced motion on mount
assert hasattr(app, '_reduced_motion') assert hasattr(app, '_reduced_motion')
@@ -380,7 +375,7 @@ class TestSafePersistence:
with patch.dict(os.environ, {"XDG_CONFIG_HOME": str(config_home)}): with patch.dict(os.environ, {"XDG_CONFIG_HOME": str(config_home)}):
app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db") app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db")
async with app.run_test() as pilot: async with app.run_test():
# TUI should start with default theme # TUI should start with default theme
assert app.theme == "fenris-chalktone" assert app.theme == "fenris-chalktone"
# Dashboard should be functional # Dashboard should be functional
@@ -399,7 +394,7 @@ class TestSafePersistence:
with patch.dict(os.environ, {"XDG_CONFIG_HOME": str(config_home)}): with patch.dict(os.environ, {"XDG_CONFIG_HOME": str(config_home)}):
app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db") app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db")
async with app.run_test() as pilot: async with app.run_test():
# TUI should start without crash # TUI should start without crash
assert app.theme in ("fenris-chalktone", "fenris-amber", "fenris-nord", "fenris-high-contrast") assert app.theme in ("fenris-chalktone", "fenris-amber", "fenris-nord", "fenris-high-contrast")
+3 -7
View File
@@ -10,7 +10,6 @@ Covers:
- AC92-7: Keyboard actions verified from normal launch with headless driver - AC92-7: Keyboard actions verified from normal launch with headless driver
- AC92-8: Equivalent clickable actions at 80x24 and constrained widths - AC92-8: Equivalent clickable actions at 80x24 and constrained widths
""" """
import sqlite3
from datetime import datetime, timedelta, timezone from datetime import datetime, timedelta, timezone
from pathlib import Path from pathlib import Path
from unittest.mock import patch from unittest.mock import patch
@@ -111,7 +110,6 @@ def _make_app(tmp_path, clock=None):
""" """
if clock is None: if clock is None:
clock = _clock() clock = _clock()
from unittest.mock import patch
import fenris.tui as tui_mod import fenris.tui as tui_mod
from datetime import datetime as _real_datetime from datetime import datetime as _real_datetime
@@ -819,19 +817,17 @@ class TestHistoricalSelectionIdentity:
# Move from final local hour to the second 01:00 occurrence. # Move from final local hour to the second 01:00 occurrence.
await pilot.press(*(["left"] * 22)) await pilot.press(*(["left"] * 22))
second_occurrence = str(app.query_one("#bar-readout").render()) second_occurrence = str(app.query_one("#bar-readout").render())
assert "01:00 -0500" in second_occurrence assert "01:00 America/New_York -05:00" in second_occurrence
assert "America/New_York -0500" in second_occurrence
assert "06:00 UTC" in second_occurrence assert "06:00 UTC" in second_occurrence
await pilot.press("left") await pilot.press("left")
first_occurrence = str(app.query_one("#bar-readout").render()) first_occurrence = str(app.query_one("#bar-readout").render())
assert "01:00 -0400" in first_occurrence assert "01:00 America/New_York -04:00" in first_occurrence
assert "America/New_York -0400" in first_occurrence
assert "05:00 UTC" in first_occurrence assert "05:00 UTC" in first_occurrence
await pilot.press("left") await pilot.press("left")
incomplete_hour = str(app.query_one("#bar-readout").render()) incomplete_hour = str(app.query_one("#bar-readout").render())
assert "00:00 -0400" in incomplete_hour assert "00:00 America/New_York -04:00" in incomplete_hour
assert "50% coverage · incomplete" in incomplete_hour assert "50% coverage · incomplete" in incomplete_hour
finally: finally:
patcher.stop() patcher.stop()
+3 -7
View File
@@ -11,7 +11,6 @@ Seams:
- Read side: query_local_day_history() returns entries with evidence flags - Read side: query_local_day_history() returns entries with evidence flags
- Repair: repair_derivation() does not touch existing local_days - Repair: repair_derivation() does not touch existing local_days
""" """
import sqlite3
from datetime import datetime, timedelta, timezone from datetime import datetime, timedelta, timezone
from pathlib import Path from pathlib import Path
from typing import Any, Dict from typing import Any, Dict
@@ -21,7 +20,7 @@ import sys
sys.path.insert(0, str(Path(__file__).parent.parent / "src")) sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
from fenris.store import init_store, SCHEMA_VERSION from fenris.store import init_store
from fenris.local_day import ( from fenris.local_day import (
derive_local_day_summary, derive_local_day_summary,
persist_local_day, persist_local_day,
@@ -29,11 +28,9 @@ from fenris.local_day import (
query_local_day_history, query_local_day_history,
LocalDaySummary, LocalDaySummary,
LocalDayHistoryEntry, LocalDayHistoryEntry,
_is_detail_available,
) )
from fenris.pruning import prune_old_samples, RAW_SAMPLE_RETENTION_DAYS from fenris.pruning import prune_old_samples
from fenris.repair import repair_derivation from fenris.repair import repair_derivation
from fenris.monitoring_periods import ensure_period_open, close_period
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
@@ -226,7 +223,7 @@ class TestBoundaryPreservation:
_insert_sample(conn, "2026-09-16T23:55:00+00:00", bw=100) _insert_sample(conn, "2026-09-16T23:55:00+00:00", bw=100)
_insert_sample(conn, "2026-09-17T12:30:00+00:00", bw=200) _insert_sample(conn, "2026-09-17T12:30:00+00:00", bw=200)
pruned = prune_old_samples(conn, now, retention_days=14) prune_old_samples(conn, now, retention_days=14)
# Boundary anchor should be retained # Boundary anchor should be retained
cursor = conn.execute( cursor = conn.execute(
@@ -305,7 +302,6 @@ class TestLegacyDataHandling:
def test_incomplete_legacy_labelled_correctly(self, tmp_path): def test_incomplete_legacy_labelled_correctly(self, tmp_path):
"""Legacy summary without full evidence is labelled incomplete.""" """Legacy summary without full evidence is labelled incomplete."""
conn = init_store(tmp_path / "obs.db") conn = init_store(tmp_path / "obs.db")
now = datetime(2026, 10, 1, 12, 0, 0, tzinfo=timezone.utc)
# Simulate a legacy summary that can't establish a full local-day total # Simulate a legacy summary that can't establish a full local-day total
legacy = LocalDaySummary( legacy = LocalDaySummary(
+2 -2
View File
@@ -12,7 +12,7 @@ from fenris import collector
from fenris.projection import compute_projection from fenris.projection import compute_projection
from fenris.status import _query_drive_facts, get_status, read_status from fenris.status import _query_drive_facts, get_status, read_status
from fenris.status_composition import render_status_tui from fenris.status_composition import render_status_tui
from fenris.store import init_store from fenris.store import SCHEMA_VERSION, init_store
class FakeClock: class FakeClock:
@@ -288,7 +288,7 @@ def test_v3_readers_ignore_pending_table_until_store_migrates(tmp_path):
migrated = init_store(store_path) migrated = init_store(store_path)
try: try:
assert migrated.execute("PRAGMA user_version").fetchone()[0] == 6 assert migrated.execute("PRAGMA user_version").fetchone()[0] == SCHEMA_VERSION
assert migrated.execute("SELECT COUNT(*) FROM pending_publications").fetchone()[0] == 0 assert migrated.execute("SELECT COUNT(*) FROM pending_publications").fetchone()[0] == 0
finally: finally:
migrated.close() migrated.close()
+1 -4
View File
@@ -4,9 +4,6 @@ Tests the idempotent, interruption-safe import of history.jsonl into the
observation store. observation store.
""" """
import json import json
import os
import sqlite3
import tempfile
from datetime import datetime, timezone from datetime import datetime, timezone
from pathlib import Path from pathlib import Path
from typing import Any, Dict from typing import Any, Dict
@@ -17,7 +14,7 @@ import pytest
import sys import sys
sys.path.insert(0, str(Path(__file__).parent.parent / "src")) sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
from fenris.legacy import import_legacy_history, is_legacy_imported, _parse_history_line from fenris.legacy import import_legacy_history, _parse_history_line
from fenris.store import init_store from fenris.store import init_store
+8 -9
View File
@@ -18,12 +18,9 @@ from fenris.activity_selection import IntervalIdentity
from fenris.monitoring_periods import ensure_period_open from fenris.monitoring_periods import ensure_period_open
from fenris.status import ACCURACY_SEC, CADENCE_DEFAULT_S, FRESH_THRESHOLD_S from fenris.status import ACCURACY_SEC, CADENCE_DEFAULT_S, FRESH_THRESHOLD_S
from fenris.store import init_store from fenris.store import init_store
from fenris.tui import ( from fenris.timefmt import local_clock, tz_label, utc_range_label
LIVE_WINDOW_H, from fenris.activity_readout import LIVE_WINDOW_H, _query_live_graph_data
FenrisTuiApp, from fenris.tui import FenrisTuiApp, LiveActivityGraph
LiveActivityGraph,
_query_live_graph_data,
)
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
# Helpers # Helpers
@@ -70,8 +67,10 @@ def _live_intervals(count=4):
intervals.append({ intervals.append({
"start_ts": start.isoformat(), "start_ts": start.isoformat(),
"end_ts": end.isoformat(), "end_ts": end.isoformat(),
"start_label": start.strftime("%H:%M"), "start_label": local_clock(start, "UTC"),
"end_label": end.strftime("%H:%M"), "end_label": local_clock(end, "UTC"),
"timezone_label": tz_label(end, "UTC"),
"utc_label": utc_range_label(start, end),
"bytes_written": (index + 1) * 1000, "bytes_written": (index + 1) * 1000,
"bytes_read": (index + 1) * 500, "bytes_read": (index + 1) * 500,
"elapsed_s": 180, "elapsed_s": 180,
@@ -282,7 +281,7 @@ class TestLiveActivityGraph:
await pilot.pause() await pilot.pause()
header = str(graph.query_one("#live-header").render()) header = str(graph.query_one("#live-header").render())
assert "1 intervals" in header assert "1 intervals" in header
assert "w W/R" in str(app.query_one("#activity-tools").render()) assert "w Toggle read/write" in str(app.query_one("#activity-tools").render())
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
+4 -1
View File
@@ -624,6 +624,7 @@ class TestCollectorIntegration:
assert summary["activity_state"] in ("incomplete", "so_far") assert summary["activity_state"] in ("incomplete", "so_far")
conn.close() conn.close()
from fenris.activity_readout import selected_local_day
from fenris.status import read_status from fenris.status import read_status
from fenris.tui import FenrisTuiApp from fenris.tui import FenrisTuiApp
@@ -634,7 +635,9 @@ class TestCollectorIntegration:
Path(store), second_at, query_services=False Path(store), second_at, query_services=False
) as (reader, _): ) as (reader, _):
assert reader is not None assert reader is not None
app._render_local_day(reader) app._render_local_day(*selected_local_day(
reader, app._activity_selection, second_at,
))
visible = str(app.query_one("#local-day").render()) visible = str(app.query_one("#local-day").render())
assert "2026-09-02" in visible assert "2026-09-02" in visible
assert "Asia/Kolkata +05:30" in visible assert "Asia/Kolkata +05:30" in visible
+1 -5
View File
@@ -21,10 +21,8 @@ import sys
sys.path.insert(0, str(Path(__file__).parent.parent / "src")) sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
from fenris.collector import run_collection from fenris.collector import run_collection
from fenris.store import init_store
from fenris.day_aggregate import derive_day from fenris.day_aggregate import derive_day
from fenris.monitoring_periods import ensure_period_open from fenris.activity_readout import _query_daily_graph_data, _query_hourly_graph_data
from fenris.tui import _query_daily_graph_data, _query_hourly_graph_data
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
@@ -247,7 +245,6 @@ class TestCrossHourAttribution:
for day in ("2026-09-01",): for day in ("2026-09-01",):
agg = derive_day(conn, day) agg = derive_day(conn, day)
assert agg is not None assert agg is not None
total_accounted = agg.bytes_written_delta + agg.bytes_read_delta
unattributed_w = conn.execute( unattributed_w = conn.execute(
"SELECT unattributed_bytes_written FROM day_aggregates WHERE day = ?", "SELECT unattributed_bytes_written FROM day_aggregates WHERE day = ?",
(day,) (day,)
@@ -483,7 +480,6 @@ class TestCrossDayBoundary:
# The cross-day delta is unattributed at the day level # The cross-day delta is unattributed at the day level
sep1 = day_map["2026-09-01"] sep1 = day_map["2026-09-01"]
sep2 = day_map["2026-09-02"]
# Both days may show the unattributed bytes # Both days may show the unattributed bytes
# (the delta is added to both days' unattributed totals as evidence) # (the delta is added to both days' unattributed totals as evidence)
total_w = sep1["allocated_bytes"] + sep1["unallocated_bytes"] total_w = sep1["allocated_bytes"] + sep1["unallocated_bytes"]
+25 -7
View File
@@ -3,7 +3,6 @@
Spec: §8.4, §8.5, §8.6, §8.7 Spec: §8.4, §8.5, §8.6, §8.7
""" """
import json import json
import sqlite3
from datetime import datetime, timezone from datetime import datetime, timezone
from pathlib import Path from pathlib import Path
from unittest.mock import patch, MagicMock from unittest.mock import patch, MagicMock
@@ -56,7 +55,7 @@ class TestEnableIdempotentMatrix:
"""A fresh package install has a store directory but no database yet.""" """A fresh package install has a store directory but no database yet."""
args = MagicMock(now=False, store_path=store_path) args = MagicMock(now=False, store_path=store_path)
with patch("fenris.monitor.enable_timer") as mock_enable: with patch("fenris.monitor.enable_timer"):
cmd_enable(args) cmd_enable(args)
conn = init_store(store_path) conn = init_store(store_path)
@@ -73,7 +72,7 @@ class TestEnableIdempotentMatrix:
args = MagicMock(now=False, store_path=store_path) args = MagicMock(now=False, store_path=store_path)
with patch("fenris.monitor.enable_timer") as mock_enable: with patch("fenris.monitor.enable_timer"):
cmd_enable(args) cmd_enable(args)
# Period should be open # Period should be open
@@ -84,6 +83,25 @@ class TestEnableIdempotentMatrix:
assert cursor.fetchone() is not None assert cursor.fetchone() is not None
conn.close() conn.close()
def test_enable_reports_period_start_in_local_time(
self, store_path, monkeypatch, capsys,
):
"""The opened-at message is local time with its timezone label."""
monkeypatch.setenv("TZ", "Asia/Kolkata")
args = MagicMock(now=True, store_path=store_path)
conn = init_store(store_path)
conn.execute("DELETE FROM monitoring_periods")
conn.commit()
conn.close()
with patch("fenris.monitor.enable_timer"):
cmd_enable(args)
out = capsys.readouterr().out
assert "Monitoring period opened at" in out
assert "Asia/Kolkata +05:30" in out
assert "+00:00" not in out
def test_resume_with_open_period_noop(self, store_path): def test_resume_with_open_period_noop(self, store_path):
"""Resume with open period: no-op (gap stays inside as unknown).""" """Resume with open period: no-op (gap stays inside as unknown)."""
# Initialize store and open a period # Initialize store and open a period
@@ -98,7 +116,7 @@ class TestEnableIdempotentMatrix:
args = MagicMock(now=True, store_path=store_path) args = MagicMock(now=True, store_path=store_path)
with patch("fenris.monitor.enable_timer") as mock_enable: with patch("fenris.monitor.enable_timer"):
cmd_enable(args) cmd_enable(args)
# Should still have exactly one open period # Should still have exactly one open period
@@ -122,7 +140,7 @@ class TestEnableIdempotentMatrix:
args = MagicMock(now=True, store_path=store_path) args = MagicMock(now=True, store_path=store_path)
with patch("fenris.monitor.enable_timer") as mock_enable: with patch("fenris.monitor.enable_timer"):
cmd_enable(args) cmd_enable(args)
# Should have a new open period # Should have a new open period
@@ -151,7 +169,7 @@ class TestDisableIdempotentMatrix:
args = MagicMock(now=True, store_path=store_path) args = MagicMock(now=True, store_path=store_path)
with patch("fenris.monitor.disable_timer") as mock_disable: with patch("fenris.monitor.disable_timer"):
cmd_disable(args) cmd_disable(args)
# Period should be closed with user_disabled # Period should be closed with user_disabled
@@ -169,7 +187,7 @@ class TestDisableIdempotentMatrix:
args = MagicMock(now=True, store_path=store_path) args = MagicMock(now=True, store_path=store_path)
with patch("fenris.monitor.disable_timer") as mock_disable: with patch("fenris.monitor.disable_timer"):
cmd_disable(args) cmd_disable(args)
# No periods should exist # No periods should exist
+1 -2
View File
@@ -6,9 +6,8 @@ From spec §5.2, §8.6, §9.8:
- Powered-off time stays inside a period; disabled time does not - Powered-off time stays inside a period; disabled time does not
- End causes: user_disabled, migrated, unknown_gap - End causes: user_disabled, migrated, unknown_gap
""" """
import sqlite3
import sys import sys
from datetime import datetime, timezone, timedelta from datetime import datetime, timezone
from pathlib import Path from pathlib import Path
import pytest import pytest
+1 -5
View File
@@ -10,11 +10,11 @@ Covers:
- CLI status and collector behaviour unchanged by preferences - CLI status and collector behaviour unchanged by preferences
""" """
import json import json
from datetime import datetime, timezone
import os import os
from pathlib import Path from pathlib import Path
from unittest.mock import patch from unittest.mock import patch
import pytest
import sys import sys
sys.path.insert(0, str(Path(__file__).parent.parent / "src")) sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
@@ -295,7 +295,3 @@ class TestCLIIsolation:
tables_after = sorted(r[0] for r in cursor.fetchall()) tables_after = sorted(r[0] for r in cursor.fetchall())
conn.close() conn.close()
assert tables_before == tables_after assert tables_before == tables_after
# Need datetime for CLI isolation test
from datetime import datetime, timezone
+122 -38
View File
@@ -9,7 +9,6 @@ Covers acceptance criteria:
- PR-13: Baseline provenance and validation per register - PR-13: Baseline provenance and validation per register
- PR-17: Arithmetic exactly E_rated = TBW * 10^12, E_implied = 100*W/p, projected = max(E-W,0)/rate - PR-17: Arithmetic exactly E_rated = TBW * 10^12, E_implied = 100*W/p, projected = max(E-W,0)/rate
""" """
import sqlite3
from datetime import datetime, timedelta, timezone from datetime import datetime, timedelta, timezone
from pathlib import Path from pathlib import Path
@@ -18,11 +17,10 @@ import sys
sys.path.insert(0, str(Path(__file__).parent.parent / "src")) sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
from fenris.store import init_store from fenris.store import init_store
from fenris.monitoring_periods import ensure_period_open, close_period from fenris.monitoring_periods import ensure_period_open
from fenris.projection import ( from fenris.projection import (
compute_projection, ConfidenceState, BaselineTier, ScenarioRange, compute_projection, ConfidenceState, BaselineTier, ScenarioRange,
TBW_TO_BYTES, HORIZON_DAYS, WARMING_MIN_DAYS, STALENESS_HOURS, TBW_TO_BYTES, DISCLOSURES,
YOUNG_REGIME_DAYS, DISCLOSURES, _compute_horizon_rate,
) )
@@ -74,12 +72,13 @@ def _insert_day(conn, day, bw=1024*1024*100, coverage=0.95, samples=24):
conn.commit() conn.commit()
def _insert_sample(conn, ts, pu=5): def _insert_sample(conn, ts, pu=5, bytes_written=512000000000, segment_id=1):
conn.execute( conn.execute(
"INSERT INTO samples (ts, device, data_units_written, data_units_read, " "INSERT INTO samples (ts, device, data_units_written, data_units_read, "
"percentage_used, bytes_written, bytes_read, power_on_hours) " "percentage_used, bytes_written, bytes_read, power_on_hours, segment_id) "
"VALUES (?, ?, ?, ?, ?, ?, ?, ?)", "VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)",
(ts, "/dev/nvme0n1", 1000000, 500000, pu, 512000000000, 256000000000, 8765), (ts, "/dev/nvme0n1", bytes_written // 512000, 500000, pu, bytes_written,
256000000000, 8765, segment_id),
) )
conn.commit() conn.commit()
@@ -223,6 +222,88 @@ class TestImpliedBaseline:
result = compute_projection(store, _clock()) result = compute_projection(store, _clock())
assert result.baseline_tier == BaselineTier.VERIFIED assert result.baseline_tier == BaselineTier.VERIFIED
def _setup_implied(self, store, pus):
"""No override baseline; one sample per PU value inside the segment."""
_insert_segment(store)
_open_period(store)
for i in range(20):
d = (datetime(2026, 9, 10) + timedelta(days=i)).strftime("%Y-%m-%d")
_insert_day(store, d, bw=1024*1024*100)
for i, pu in enumerate(pus):
_insert_sample(store, "2026-09-%02dT10:00:00+00:00" % (20 + i), pu=pu)
_insert_complete_local_days(store, "2026-09-29", 1)
@pytest.mark.parametrize("pus", [[5], [5, 5, 5], [5, 6]])
def test_implied_unavailable_before_two_increments(self, store, pus):
self._setup_implied(store, pus)
result = compute_projection(store, _clock())
assert result.confidence_state == ConfidenceState.UNSUPPORTED
assert result.baseline_tier == BaselineTier.NONE
assert result.headline_remaining_seconds is None
assert "vendor wear estimate too coarse to imply endurance" in result.contributing_facts
def test_implied_unavailable_ignores_increments_in_other_segments(self, store):
_insert_segment(store, opened_at="2026-09-01T00:00:00+00:00")
_insert_segment(store, opened_at="2026-09-15T00:00:00+00:00", identity_key="nqn.new")
_open_period(store)
for i in range(20):
d = (datetime(2026, 9, 10) + timedelta(days=i)).strftime("%Y-%m-%d")
_insert_day(store, d, bw=1024*1024*100)
# Two increments in the old segment, none in the current one
_insert_sample(store, "2026-09-02T10:00:00+00:00", pu=3, segment_id=1)
_insert_sample(store, "2026-09-03T10:00:00+00:00", pu=4, segment_id=1)
_insert_sample(store, "2026-09-20T10:00:00+00:00", pu=5, segment_id=2)
_insert_complete_local_days(store, "2026-09-29", 1)
result = compute_projection(store, _clock())
assert result.baseline_tier == BaselineTier.NONE
assert "vendor wear estimate too coarse to imply endurance" in result.contributing_facts
def test_implied_unavailable_when_pu_out_of_range(self, store):
self._setup_implied(store, [0, 1, 2])
store.execute("UPDATE samples SET percentage_used = 255 WHERE id = 3")
store.commit()
result = compute_projection(store, _clock())
assert result.baseline_tier == BaselineTier.NONE
assert "vendor wear estimate too coarse to imply endurance" in result.contributing_facts
def test_implied_eligible_after_two_increments(self, store):
self._setup_implied(store, [5, 6, 7])
W_t = 512000000000
result = compute_projection(store, _clock())
assert result.baseline_tier == BaselineTier.IMPLIED
# Implied baseline is never Supported-eligible
assert result.confidence_state == ConfidenceState.LIMITED
assert "vendor wear estimate too coarse to imply endurance" not in result.contributing_facts
E_implied = 100 * W_t / 7
regime_bytes = 20 * 1024 * 1024 * 100
regime_start = datetime(2026, 9, 10, 0, 0, 0, tzinfo=timezone.utc)
rate = regime_bytes / int((_clock() - regime_start).total_seconds())
assert abs(result.headline_remaining_seconds - max(E_implied - W_t, 0) / rate) < 1.0
def test_override_wins_over_implied(self, store):
_insert_baseline(store, tbw_tb=1.0, verified=True)
self._setup_implied(store, [5, 6, 7])
result = compute_projection(store, _clock())
assert result.baseline_tier == BaselineTier.VERIFIED
class TestHorizonAgreement:
def test_single_horizon_passes_agreement(self, store):
"""ADR 0002 §8: agreement is judged across existing horizons; one passes."""
_insert_baseline(store, tbw_tb=1.0, verified=True)
_insert_segment(store)
_open_period(store)
# 14 days covers only the 7-day horizon
for i in range(14):
d = (datetime(2026, 9, 17) + timedelta(days=i)).strftime("%Y-%m-%d")
_insert_day(store, d, bw=1024*1024*100)
_insert_sample(store, "2026-09-30T10:00:00+00:00", pu=5)
_insert_complete_local_days(store, "2026-09-29", 1)
result = compute_projection(store, _clock())
assert list(result.scenario_range.rates) == [7]
assert not any("regime only" in f for f in result.contributing_facts)
assert result.confidence_state == ConfidenceState.SUPPORTED
class TestZeroRate: class TestZeroRate:
def test_zero_rate_fixed_phrase(self, store): def test_zero_rate_fixed_phrase(self, store):
@@ -315,16 +396,16 @@ class TestArithmetic:
_insert_day(store, d, bw=1024*1024*100) _insert_day(store, d, bw=1024*1024*100)
_insert_sample(store, "2026-09-30T10:00:00+00:00", pu=5) _insert_sample(store, "2026-09-30T10:00:00+00:00", pu=5)
result = compute_projection(store, _clock()) result = compute_projection(store, _clock())
if result.headline_remaining_seconds is not None: E_rated = 1.0 * TBW_TO_BYTES
E_rated = 1.0 * TBW_TO_BYTES W_t = 512000000000 # lifetime bytes written of the newest published sample
regime_bytes = 30 * 1024 * 1024 * 100 regime_bytes = 30 * 1024 * 1024 * 100
# Actual wall-clock: Sep 1 00:00 -> Sep 30 12:00 = 29.5 days # Actual wall-clock: Sep 1 00:00 -> Sep 30 12:00 = 29.5 days
period_start = datetime(2026, 9, 1, 0, 0, 0, tzinfo=timezone.utc) period_start = datetime(2026, 9, 1, 0, 0, 0, tzinfo=timezone.utc)
period_end = _clock() actual_wc = int((_clock() - period_start).total_seconds())
actual_wc = int((period_end - period_start).total_seconds()) rate = regime_bytes / actual_wc
rate = regime_bytes / actual_wc expected = max(E_rated - W_t, 0) / rate
expected = max(E_rated - regime_bytes, 0) / rate assert result.headline_remaining_seconds is not None
assert abs(result.headline_remaining_seconds - expected) < 1.0 assert abs(result.headline_remaining_seconds - expected) < 1.0
def test_implied_baseline_formula(self, store): def test_implied_baseline_formula(self, store):
W_t = 1024 * 1024 * 1000 W_t = 1024 * 1024 * 1000
@@ -339,17 +420,19 @@ class TestArithmetic:
for i in range(30): for i in range(30):
d = (datetime(2026, 9, 1) + timedelta(days=i)).strftime("%Y-%m-%d") d = (datetime(2026, 9, 1) + timedelta(days=i)).strftime("%Y-%m-%d")
_insert_day(store, d, bw=1024*1024*100) _insert_day(store, d, bw=1024*1024*100)
_insert_sample(store, "2026-09-30T10:00:00+00:00", pu=5) W_t = 512000000000 # lifetime written bytes of the newest sample
_insert_sample(store, "2026-09-30T10:00:00+00:00", pu=5, bytes_written=W_t)
_insert_complete_local_days(store, "2026-09-29", 1)
result = compute_projection(store, _clock()) result = compute_projection(store, _clock())
if result.headline_remaining_seconds is not None: assert result.headline_remaining_seconds is not None
E_rated = 2.0 * TBW_TO_BYTES E_rated = 2.0 * TBW_TO_BYTES
regime_bytes = 30 * 1024 * 1024 * 100 regime_bytes = 30 * 1024 * 1024 * 100
period_start = datetime(2026, 9, 1, 0, 0, 0, tzinfo=timezone.utc) period_start = datetime(2026, 9, 1, 0, 0, 0, tzinfo=timezone.utc)
period_end = _clock() actual_wc = int((_clock() - period_start).total_seconds())
actual_wc = int((period_end - period_start).total_seconds()) rate = regime_bytes / actual_wc
rate = regime_bytes / actual_wc # W_t is lifetime written bytes, not the regime delta
expected = max(E_rated - regime_bytes, 0) / rate expected = max(E_rated - W_t, 0) / rate
assert abs(result.headline_remaining_seconds - expected) < 1.0 assert abs(result.headline_remaining_seconds - expected) < 1.0
def test_wearing_rate_proportional(self, store): def test_wearing_rate_proportional(self, store):
_insert_baseline(store, tbw_tb=1.0, verified=True) _insert_baseline(store, tbw_tb=1.0, verified=True)
@@ -359,6 +442,7 @@ class TestArithmetic:
d = (datetime(2026, 9, 1) + timedelta(days=i)).strftime("%Y-%m-%d") d = (datetime(2026, 9, 1) + timedelta(days=i)).strftime("%Y-%m-%d")
_insert_day(store, d, bw=1024*1024*100) _insert_day(store, d, bw=1024*1024*100)
_insert_sample(store, "2026-09-30T10:00:00+00:00", pu=5) _insert_sample(store, "2026-09-30T10:00:00+00:00", pu=5)
_insert_complete_local_days(store, "2026-09-29", 1)
r_slow = compute_projection(store, _clock()) r_slow = compute_projection(store, _clock())
store.execute("DELETE FROM day_aggregates") store.execute("DELETE FROM day_aggregates")
@@ -368,9 +452,9 @@ class TestArithmetic:
_insert_day(store, d, bw=2*1024*1024*100) _insert_day(store, d, bw=2*1024*1024*100)
r_fast = compute_projection(store, _clock()) r_fast = compute_projection(store, _clock())
if r_slow.headline_remaining_seconds is not None and r_fast.headline_remaining_seconds is not None: assert r_slow.headline_remaining_seconds is not None
assert r_fast.headline_remaining_seconds < r_slow.headline_remaining_seconds assert r_fast.headline_remaining_seconds is not None
assert r_fast.headline_remaining_seconds < r_slow.headline_remaining_seconds
# =========================================================================== # ===========================================================================
@@ -394,17 +478,19 @@ class TestSustainedRegimeRate:
for i in range(30): for i in range(30):
d = (datetime(2026, 9, 1) + timedelta(days=i)).strftime("%Y-%m-%d") d = (datetime(2026, 9, 1) + timedelta(days=i)).strftime("%Y-%m-%d")
_insert_day(store, d, bw=bw) _insert_day(store, d, bw=bw)
_insert_sample(store, "2026-09-30T10:00:00+00:00", pu=5) W_t = 512000000000
_insert_sample(store, "2026-09-30T10:00:00+00:00", pu=5, bytes_written=W_t)
_insert_complete_local_days(store, "2026-09-29", 1)
result = compute_projection(store, _clock()) result = compute_projection(store, _clock())
# Regime = full 30 days; rate = 30*bw / wall-clock # Regime = full 30 days; rate = 30*bw / wall-clock
regime_bytes = 30 * bw regime_bytes = 30 * bw
period_start = datetime(2026, 9, 1, 0, 0, 0, tzinfo=timezone.utc) period_start = datetime(2026, 9, 1, 0, 0, 0, tzinfo=timezone.utc)
wc = int((_clock() - period_start).total_seconds()) wc = int((_clock() - period_start).total_seconds())
expected_rate = regime_bytes / wc expected_rate = regime_bytes / wc
if result.headline_remaining_seconds is not None: assert result.headline_remaining_seconds is not None
E = 10.0 * TBW_TO_BYTES E = 10.0 * TBW_TO_BYTES
expected_seconds = max(E - regime_bytes, 0) / expected_rate expected_seconds = max(E - W_t, 0) / expected_rate
assert abs(result.headline_remaining_seconds - expected_seconds) < 1.0 assert abs(result.headline_remaining_seconds - expected_seconds) < 1.0
def test_regime_capped_at_90_days(self, store): def test_regime_capped_at_90_days(self, store):
"""Default regime is full history capped at 90 days.""" """Default regime is full history capped at 90 days."""
@@ -1039,8 +1125,6 @@ class TestEvidenceAnchoredHorizons:
# cumulative_bytes = 30 * 100 * 1024 * 1024 # cumulative_bytes = 30 * 100 * 1024 * 1024
# rate = cumulative_bytes / wall_clock # rate = cumulative_bytes / wall_clock
# headline = (E_baseline - cumulative_bytes) / rate # headline = (E_baseline - cumulative_bytes) / rate
E_baseline = 10.0 * TBW_TO_BYTES
cumulative_bytes = 30 * bw
assert result.headline_remaining_seconds >= 0 assert result.headline_remaining_seconds >= 0
def test_zero_boundary_delta_returns_zero(self, store): def test_zero_boundary_delta_returns_zero(self, store):
+2 -3
View File
@@ -5,7 +5,6 @@ day aggregates are retained indefinitely.
Issue #74: Boundary anchors required for successor evidence are retained. Issue #74: Boundary anchors required for successor evidence are retained.
""" """
import sqlite3
import sys import sys
from datetime import datetime, timezone, timedelta from datetime import datetime, timezone, timedelta
from pathlib import Path from pathlib import Path
@@ -124,7 +123,7 @@ class TestPruneOldSamples:
_insert_sample(store_conn, "2026-09-16T12:30:00+00:00", 2000000) _insert_sample(store_conn, "2026-09-16T12:30:00+00:00", 2000000)
# Run pruning # Run pruning
pruned = prune_old_samples(store_conn, now, retention_days=14) prune_old_samples(store_conn, now, retention_days=14)
# The boundary anchor should be retained # The boundary anchor should be retained
cursor = store_conn.execute( cursor = store_conn.execute(
@@ -148,7 +147,7 @@ class TestPruneOldSamples:
store_conn.commit() store_conn.commit()
# Run pruning # Run pruning
pruned = prune_old_samples(store_conn, now, retention_days=14) prune_old_samples(store_conn, now, retention_days=14)
# Keep the source samples until local-day replacement evidence exists. # Keep the source samples until local-day replacement evidence exists.
cursor = store_conn.execute( cursor = store_conn.execute(
+1 -3
View File
@@ -58,7 +58,7 @@ def _rpm_filename(version: str, release: int = 1) -> str:
def _registry_upload_deb_url(version: str) -> str: def _registry_upload_deb_url(version: str) -> str:
"""Expected registry upload URL for a deb package.""" """Expected registry upload URL for a deb package."""
return f"debian/pool/bookworm/main/upload" return "debian/pool/bookworm/main/upload"
def _registry_upload_rpm_url() -> str: def _registry_upload_rpm_url() -> str:
@@ -258,8 +258,6 @@ class TestRevisionBumping:
"""When revision is bumped, the deb filename also changes.""" """When revision is bumped, the deb filename also changes."""
version = _get_version() version = _get_version()
# Deb filename includes release in nfpm naming # Deb filename includes release in nfpm naming
deb_r1 = f"fenris_{version}_amd64.deb"
deb_r2 = f"fenris_{version}_amd64.deb"
# For deb, the filename doesn't change with revision (deb uses epoch) # For deb, the filename doesn't change with revision (deb uses epoch)
# But the RPM does — this verifies we test RPM revision correctly # But the RPM does — this verifies we test RPM revision correctly
rpm_r1 = _rpm_filename(version, 1) rpm_r1 = _rpm_filename(version, 1)
+6 -8
View File
@@ -4,9 +4,8 @@ Tests the idempotent, safe repair of hour observations and day aggregates
from surviving raw samples, boundary anchor retention, and legacy summary from surviving raw samples, boundary anchor retention, and legacy summary
handling at actual precision. handling at actual precision.
""" """
import sqlite3
import sys import sys
from datetime import datetime, timedelta, timezone from datetime import datetime, timezone
from pathlib import Path from pathlib import Path
import pytest import pytest
@@ -102,7 +101,6 @@ class TestRepairUsesSameEvidenceRules:
def test_repair_idempotent_on_fully_derived(self, store_conn): def test_repair_idempotent_on_fully_derived(self, store_conn):
"""Repair on store with existing derived data does not duplicate.""" """Repair on store with existing derived data does not duplicate."""
now = datetime(2026, 9, 15, 12, 0, 0, tzinfo=timezone.utc)
_open_period(store_conn, "2026-09-14T00:00:00+00:00") _open_period(store_conn, "2026-09-14T00:00:00+00:00")
# Insert samples that span an hour # Insert samples that span an hour
@@ -138,7 +136,7 @@ class TestRepairUsesSameEvidenceRules:
store_conn.commit() store_conn.commit()
# Run repair # Run repair
result = repair_derivation(store_conn) repair_derivation(store_conn)
# Verify marker preserved # Verify marker preserved
cursor = store_conn.execute( cursor = store_conn.execute(
@@ -265,7 +263,7 @@ class TestBoundaryAnchorRetention:
_insert_sample(store_conn, "2026-09-29T12:00:00+00:00", 3000000) _insert_sample(store_conn, "2026-09-29T12:00:00+00:00", 3000000)
# Run pruning # Run pruning
pruned = prune_old_samples(store_conn, now, retention_days=14) prune_old_samples(store_conn, now, retention_days=14)
# The boundary anchor should be retained # The boundary anchor should be retained
cursor = store_conn.execute( cursor = store_conn.execute(
@@ -286,7 +284,7 @@ class TestBoundaryAnchorRetention:
bytes_written_delta=1000000) bytes_written_delta=1000000)
# Run pruning # Run pruning
pruned = prune_old_samples(store_conn, now, retention_days=14) prune_old_samples(store_conn, now, retention_days=14)
# The source remains until local-day evidence is also durable. # The source remains until local-day evidence is also durable.
cursor = store_conn.execute( cursor = store_conn.execute(
@@ -309,7 +307,7 @@ class TestLegacySummaryPrecision:
bytes_written_delta=5000000) bytes_written_delta=5000000)
# Run repair # Run repair
result = repair_derivation(store_conn) repair_derivation(store_conn)
# Should not create hour observations for legacy day # Should not create hour observations for legacy day
cursor = store_conn.execute( cursor = store_conn.execute(
@@ -324,7 +322,7 @@ class TestLegacySummaryPrecision:
bytes_written_delta=5000000) bytes_written_delta=5000000)
# Run repair # Run repair
result = repair_derivation(store_conn) repair_derivation(store_conn)
# Day aggregate should not be modified # Day aggregate should not be modified
cursor = store_conn.execute( cursor = store_conn.execute(
+2 -2
View File
@@ -259,8 +259,8 @@ class TestKeyCeremonyDoc:
def test_documents_private_key_storage(self): def test_documents_private_key_storage(self):
content = self._doc_content() content = self._doc_content()
assert "password manager" in content.lower(), \ assert "gitea repository actions secret `gpg_private_key`" in content.lower(), \
"Must document that private key lives in password manager" "Must document that Gitea Actions stores the private signing key"
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
+221
View File
@@ -0,0 +1,221 @@
"""Staged projection with an evidence ladder (issue #106, ADR 0012).
Every gate is exercised through compute_projection() against SQLite
fixtures built by seed_evidence(): N hours or days of complete evidence
written as hour observations, then derived into day aggregates the same
way a collection run does.
"""
import sys
from datetime import datetime, timedelta, timezone
from pathlib import Path
import pytest
sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
from fenris.day_aggregate import derive_all_days, persist_day_aggregate
from fenris.monitoring_periods import ensure_period_open
from fenris.projection import (
BaselineTier, ConfidenceState, ProjectionStage, compute_projection,
)
from fenris.store import init_store
START = datetime(2026, 9, 1, 0, 0, 0, tzinfo=timezone.utc)
HOUR_BYTES = 10 * 1024 ** 3
MODEL = "Samsung SSD 970 EVO Plus 1TB"
@pytest.fixture
def store(tmp_path):
conn = init_store(tmp_path / "test.db")
yield conn
conn.close()
def seed_evidence(conn, hours, baseline="verified", start=START, degraded=False):
"""Seed *hours* hours of complete evidence and return the clock.
Monitoring opens at *start*; each hour is fully sampled and active.
The returned clock is the end of the last observed hour.
"""
conn.execute(
"INSERT INTO controller_segments "
"(opened_at, identity_key, identity_degraded, subnqn, sn, mn, fr, vid, ssvid, transport) "
"VALUES (?, ?, ?, 'nqn.test', 'SN1', ?, 'FW1', '0x144d', '0x144d', 'pcie')",
(start.isoformat(), "" if degraded else "nqn.test", degraded, MODEL),
)
if baseline:
conn.execute(
"INSERT INTO endurance_baseline "
"(tbw_terabytes, source_url, document_revision, entry_date, model_string, "
" nominal_capacity_bytes, validated_by, verified, created_at, updated_at) "
"VALUES (600, ?, 'v1', '2026-01-01', ?, 1024000000000, ?, ?, "
" '2026-01-01T00:00:00+00:00', '2026-01-01T00:00:00+00:00')",
("https://example.com/spec" if baseline == "verified" else None, MODEL,
"machine_match" if baseline == "verified" else None,
baseline == "verified"),
)
ensure_period_open(conn, start)
for h in range(hours):
hour = start + timedelta(hours=h)
conn.execute(
"INSERT INTO hour_observations "
"(hour, active_seconds, idle_seconds, powered_off_seconds, unknown_seconds, "
" bytes_written_delta, bytes_read_delta, sample_count, coverage) "
"VALUES (?, 3600, 0, 0, 0, ?, 0, 1, 1.0)",
(hour.strftime("%Y-%m-%dT%H:00:00Z"), HOUR_BYTES),
)
written = HOUR_BYTES * (h + 1)
conn.execute(
"INSERT INTO samples (ts, device, data_units_written, data_units_read, "
"percentage_used, bytes_written, bytes_read, power_on_hours, segment_id) "
"VALUES (?, '/dev/nvme0n1', ?, 0, 1, ?, 0, 100, 1)",
((hour + timedelta(hours=1)).isoformat(), written // 512000, written),
)
for aggregate in derive_all_days(conn):
persist_day_aggregate(conn, aggregate)
conn.commit()
return start + timedelta(hours=hours)
class TestHourStages:
def test_empty_store_has_no_observations(self, store):
result = compute_projection(store, START)
assert result.stage == ProjectionStage.NO_OBSERVATIONS
assert result.headline_remaining_seconds is None
def test_two_hours_is_too_few_for_a_number(self, store):
clock = seed_evidence(store, 2)
result = compute_projection(store, clock)
assert result.stage == ProjectionStage.NO_OBSERVATIONS
assert result.headline_remaining_seconds is None
assert result.hours_observed == 2
def test_three_hours_is_provisional_with_a_number(self, store):
clock = seed_evidence(store, 3)
result = compute_projection(store, clock)
assert result.stage == ProjectionStage.PROVISIONAL
assert result.headline_remaining_seconds is not None
assert result.headline_remaining_seconds > 0
assert result.hours_observed == 3
assert "3 hours observed" in result.contributing_facts
assert "daily cycle not yet seen" in result.contributing_facts
def test_three_hours_shows_short_horizon_spread(self, store):
clock = seed_evidence(store, 3)
result = compute_projection(store, clock)
assert result.scenario_range is not None
assert set(result.scenario_range.rates) <= {1, 3}
assert 1 in result.scenario_range.rates
def test_provisional_rate_is_the_observed_write_rate(self, store):
clock = seed_evidence(store, 3)
result = compute_projection(store, clock)
assert result.write_rate == pytest.approx(HOUR_BYTES / 3600, rel=0.01)
def test_complete_local_day_is_a_fact_not_a_gate(self, store):
clock = seed_evidence(store, 3)
result = compute_projection(store, clock)
assert result.headline_remaining_seconds is not None
assert "waiting for a full local observation day" in result.contributing_facts
def test_provisional_until_24_hours_then_warming(self, store):
clock = seed_evidence(store, 23)
assert compute_projection(store, clock).stage == ProjectionStage.PROVISIONAL
def test_twenty_four_hours_is_warming(self, store):
clock = seed_evidence(store, 24)
result = compute_projection(store, clock)
assert result.stage == ProjectionStage.WARMING
assert "daily cycle not yet seen" not in result.contributing_facts
class TestDayStages:
def test_warming_until_fourteen_qualifying_days(self, store):
clock = seed_evidence(store, 24 * 13)
assert compute_projection(store, clock).stage == ProjectionStage.WARMING
def test_fourteen_days_with_verified_baseline_is_supported(self, store):
clock = seed_evidence(store, 24 * 14)
result = compute_projection(store, clock)
assert result.stage == ProjectionStage.SUPPORTED
assert result.confidence_state == ConfidenceState.SUPPORTED
def test_unverified_baseline_is_limited_after_warm_up(self, store):
clock = seed_evidence(store, 24 * 14, baseline="unverified")
result = compute_projection(store, clock)
assert result.stage == ProjectionStage.LIMITED
assert result.baseline_tier == BaselineTier.UNVERIFIED
def test_degraded_identity_is_limited(self, store):
clock = seed_evidence(store, 24 * 14, degraded=True)
assert compute_projection(store, clock).stage == ProjectionStage.LIMITED
def test_stale_history_is_limited(self, store):
clock = seed_evidence(store, 24 * 14) + timedelta(days=4)
assert compute_projection(store, clock).stage == ProjectionStage.LIMITED
class TestNoBaseline:
def test_write_rate_replaces_lifespan(self, store):
clock = seed_evidence(store, 3, baseline=None)
result = compute_projection(store, clock)
assert result.stage == ProjectionStage.UNAVAILABLE
assert result.headline_remaining_seconds is None
assert result.write_rate == pytest.approx(HOUR_BYTES / 3600, rel=0.01)
def test_no_baseline_is_not_synthesised(self, store):
clock = seed_evidence(store, 24 * 14, baseline=None)
result = compute_projection(store, clock)
assert result.baseline_tier == BaselineTier.NONE
assert result.headline_remaining_seconds is None
assert result.write_rate is not None
class TestShortHorizons:
def test_short_horizons_appear_once_covered(self, store):
clock = seed_evidence(store, 24 * 2)
rates = compute_projection(store, clock).scenario_range.rates
assert 1 in rates
assert 3 not in rates
def test_three_day_horizon_covered_at_four_days(self, store):
clock = seed_evidence(store, 24 * 4)
rates = compute_projection(store, clock).scenario_range.rates
assert {1, 3} <= set(rates)
def test_short_horizons_drop_when_seven_day_covered(self, store):
clock = seed_evidence(store, 24 * 9)
rates = compute_projection(store, clock).scenario_range.rates
assert 7 in rates
assert 1 not in rates and 3 not in rates
class TestEvidenceLadder:
def test_ladder_lists_each_supported_condition_with_reason(self, store):
clock = seed_evidence(store, 3)
ladder = compute_projection(store, clock).evidence_ladder
assert len(ladder) == 8
assert all(c.reason for c in ladder)
assert all(isinstance(c.met, bool) for c in ladder)
def test_ladder_all_met_when_supported(self, store):
clock = seed_evidence(store, 24 * 14)
result = compute_projection(store, clock)
assert result.ladder_met == result.ladder_total == 8
def test_ladder_count_rises_as_evidence_accrues(self, store, tmp_path):
counts = []
for hours in (3, 24 * 2, 24 * 9, 24 * 14):
conn = init_store(tmp_path / ("ladder-%d.db" % hours))
clock = seed_evidence(conn, hours)
counts.append(compute_projection(conn, clock).ladder_met)
conn.close()
assert counts == sorted(counts)
assert counts[0] < counts[-1]
assert len(set(counts)) >= 3
def test_unmet_condition_names_its_reason(self, store):
clock = seed_evidence(store, 3)
unmet = [c for c in compute_projection(store, clock).evidence_ladder if not c.met]
assert any("qualifying days" in c.reason for c in unmet)
+112
View File
@@ -0,0 +1,112 @@
"""CLI and TUI render the projection stage, never pre-gate it (issue #106).
Seams: get_status() and the TUI headline band. Both must show what
compute_projection() reports: the stage, the ladder count, and the full
ladder in the outlook; no caller decides what the projection can show.
"""
import sys
from datetime import datetime, timedelta, timezone
from pathlib import Path
from unittest.mock import patch
import pytest
sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
sys.path.insert(0, str(Path(__file__).parent))
from fenris.status import get_status
from fenris.store import init_store
from fenris.tui import FenrisTuiApp
from test_staged_projection import seed_evidence
SERVICES = {
"boot_enabled": False, "timer_active": False,
"last_collect_ok": None, "last_collect_age_s": None,
"last_collect_reason": None,
}
def _status(db, clock):
with patch("fenris.status.query_service_state", return_value=SERVICES):
return get_status(store_path=db, clock_now=clock,
query_services=False, query_journal=False)
@pytest.fixture
def db(tmp_path):
return tmp_path / "observations.db"
class TestCliStatus:
def test_provisional_stage_ladder_count_and_full_ladder(self, db):
conn = init_store(db)
clock = seed_evidence(conn, 3)
conn.close()
out = _status(db, clock)
assert "Provisional" in out
assert "3 hours observed" in out
assert "daily cycle not yet seen" in out
assert "remaining" in out
assert "conditions met" in out
assert "Evidence ladder" in out
assert "[ ] 14 qualifying days" in out
assert "[x] verified baseline" in out
def test_single_sample_is_not_pre_gated(self, db):
conn = init_store(db)
seed_evidence(conn, 1)
conn.close()
out = _status(db, datetime(2026, 9, 1, 1, 0, tzinfo=timezone.utc))
assert "requires at least two samples" not in out
assert "1 of 3 hours observed" in out
def test_no_baseline_shows_write_rate_not_lifespan(self, db):
conn = init_store(db)
clock = seed_evidence(conn, 3, baseline=None)
conn.close()
out = _status(db, clock)
assert "write rate" in out.lower()
assert "GB/day" in out
def test_supported_stage(self, db):
conn = init_store(db)
clock = seed_evidence(conn, 24 * 14)
conn.close()
out = _status(db, clock)
assert "Supported" in out
assert "8 of 8 conditions met" in out
class TestTuiHeadline:
@pytest.mark.asyncio
async def test_provisional_headline_and_ladder(self, db):
now = datetime.now(timezone.utc).replace(minute=0, second=0, microsecond=0)
conn = init_store(db)
seed_evidence(conn, 3, start=now - timedelta(hours=3))
conn.close()
with patch("fenris.status.query_service_state", return_value=SERVICES):
app = FenrisTuiApp(store_path=db)
async with app.run_test(size=(120, 50)):
text = str(app.query_one("#headline-band").render())
assert "Provisional" in text
assert "3 hours observed" in text
assert "conditions met" in text
assert "Evidence ladder" in text
@pytest.mark.asyncio
async def test_single_sample_is_not_pre_gated(self, db):
now = datetime.now(timezone.utc).replace(minute=0, second=0, microsecond=0)
conn = init_store(db)
seed_evidence(conn, 1, start=now - timedelta(hours=1))
conn.close()
with patch("fenris.status.query_service_state", return_value=SERVICES):
app = FenrisTuiApp(store_path=db)
async with app.run_test(size=(120, 50)):
text = str(app.query_one("#headline-band").render())
assert "at least two samples" not in text
def test_callers_carry_no_projection_pre_gate():
root = Path(__file__).parent.parent / "src" / "fenris"
for name in ("tui.py", "status.py"):
assert "at least two samples" not in (root / name).read_text()
+3 -5
View File
@@ -11,13 +11,11 @@ Covers:
- Retired command rejection with migration pointers - Retired command rejection with migration pointers
- Configuration error surfaced from direct reads - Configuration error surfaced from direct reads
""" """
import os
import sqlite3 import sqlite3
import sys import sys
import tempfile
from datetime import datetime, timedelta, timezone from datetime import datetime, timedelta, timezone
from pathlib import Path from pathlib import Path
from unittest.mock import patch, MagicMock from unittest.mock import patch
import pytest import pytest
@@ -25,7 +23,6 @@ sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
from fenris.status import ( from fenris.status import (
grade_freshness, grade_freshness,
freshness_age_human,
format_disclosures, format_disclosures,
check_retired_command, check_retired_command,
check_retired_flag, check_retired_flag,
@@ -35,7 +32,8 @@ from fenris.status import (
ACCURACY_SEC, ACCURACY_SEC,
) )
from fenris.store import init_store, SCHEMA_VERSION from fenris.store import init_store, SCHEMA_VERSION
from fenris.projection import DISCLOSURES, ConfidenceState from fenris.projection import DISCLOSURES
from fenris.timefmt import freshness_age_human
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
+5 -11
View File
@@ -10,10 +10,9 @@ Covers:
- AC78-5: Separate freshness, last outcome, boot enablement, activity facts - AC78-5: Separate freshness, last outcome, boot enablement, activity facts
- AC78-6: 5s poll reevaluates freshness from cached clock - AC78-6: 5s poll reevaluates freshness from cached clock
""" """
import sqlite3
from datetime import datetime, timedelta, timezone from datetime import datetime, timedelta, timezone
from pathlib import Path from pathlib import Path
from unittest.mock import patch, MagicMock from unittest.mock import patch
import pytest import pytest
import sys import sys
@@ -23,12 +22,9 @@ sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
from fenris.store import init_store from fenris.store import init_store
from fenris.status_composition import ( from fenris.status_composition import (
StatusState, StatusState,
StatusComposition,
compose_status, compose_status,
render_status_cli, render_status_cli,
render_status_tui, render_status_tui,
FRESH_THRESHOLD_S,
STALENESS_THRESHOLD_S,
) )
@@ -682,7 +678,6 @@ class TestStoreFaultSuppression:
conn.close() conn.close()
def test_newer_schema_suppresses_projection(self, tmp_path): def test_newer_schema_suppresses_projection(self, tmp_path):
import fenris.store as store_mod
conn = init_store(tmp_path / "test.db") conn = init_store(tmp_path / "test.db")
now = _clock() now = _clock()
@@ -957,8 +952,7 @@ class TestTUIIntegration:
conn = init_store(tmp_path / "test.db") conn = init_store(tmp_path / "test.db")
_insert_segment(conn) _insert_segment(conn)
_open_period(conn) _open_period(conn)
now = _clock() ts = (datetime.now(timezone.utc) - timedelta(minutes=2)).isoformat()
ts = (now - timedelta(minutes=2)).isoformat()
_insert_sample(conn, ts) _insert_sample(conn, ts)
for i in range(20): for i in range(20):
d = (datetime(2026, 9, 10) + timedelta(days=i)).strftime("%Y-%m-%d") d = (datetime(2026, 9, 10) + timedelta(days=i)).strftime("%Y-%m-%d")
@@ -971,7 +965,7 @@ class TestTUIIntegration:
"last_collect_ok": True, "last_collect_age_s": 120, "last_collect_ok": True, "last_collect_age_s": 120,
"last_collect_reason": None, "last_collect_reason": None,
}): }):
async with app.run_test() as pilot: async with app.run_test():
strip = str(app.query_one("#service-strip").render()) strip = str(app.query_one("#service-strip").render())
assert "●" in strip assert "●" in strip
assert "Monitoring" in strip or "monitoring" in strip.lower() assert "Monitoring" in strip or "monitoring" in strip.lower()
@@ -997,7 +991,7 @@ class TestTUIIntegration:
"last_collect_ok": None, "last_collect_age_s": None, "last_collect_ok": None, "last_collect_age_s": None,
"last_collect_reason": None, "last_collect_reason": None,
}): }):
async with app.run_test() as pilot: async with app.run_test():
strip = str(app.query_one("#service-strip").render()) strip = str(app.query_one("#service-strip").render())
# Should show Paused state # Should show Paused state
assert "‖" in strip or "Paused" in strip or "paused" in strip.lower() assert "‖" in strip or "Paused" in strip or "paused" in strip.lower()
@@ -1024,7 +1018,7 @@ class TestTUIIntegration:
"last_collect_ok": False, "last_collect_age_s": 60, "last_collect_ok": False, "last_collect_age_s": 60,
"last_collect_reason": "exit code 3", "last_collect_reason": "exit code 3",
}): }):
async with app.run_test() as pilot: async with app.run_test():
strip = str(app.query_one("#service-strip").render()) strip = str(app.query_one("#service-strip").render())
# Should show Error state # Should show Error state
assert "✖" in strip or "Error" in strip or "error" in strip.lower() assert "✖" in strip or "Error" in strip or "error" in strip.lower()
+1 -2
View File
@@ -6,7 +6,6 @@ instead of degrading to the Store fault view; (2) even group members could
not open the WAL-mode store because root-created sidecars lacked group write not open the WAL-mode store because root-created sidecars lacked group write
and the store directory lacked group execute-then-write. and the store directory lacked group execute-then-write.
""" """
import sqlite3
import sys import sys
from pathlib import Path from pathlib import Path
@@ -14,7 +13,7 @@ import pytest
sys.path.insert(0, str(Path(__file__).parent.parent / "src")) sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
from fenris.store import DEFAULT_STORE_PATH, init_store from fenris.store import init_store
from fenris.status import StoreFault, open_store_readonly from fenris.status import StoreFault, open_store_readonly
-1
View File
@@ -7,7 +7,6 @@ Covers:
- Status semantic colours/glyphs/text always win over theme - Status semantic colours/glyphs/text always win over theme
- Global action reachability and focus contrast in every preset - Global action reachability and focus contrast in every preset
""" """
import pytest
import sys import sys
from pathlib import Path from pathlib import Path
+29 -36
View File
@@ -13,39 +13,33 @@ import sqlite3
from xml.etree import ElementTree from xml.etree import ElementTree
from datetime import datetime, timedelta, timezone from datetime import datetime, timedelta, timezone
from pathlib import Path from pathlib import Path
from unittest.mock import patch, MagicMock from unittest.mock import patch
import pytest import pytest
import sys import sys
sys.path.insert(0, str(Path(__file__).parent.parent / "src")) sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
from textual.app import App
from textual.pilot import Pilot
from fenris.store import init_store, SCHEMA_VERSION from fenris.store import init_store
from fenris.monitoring_periods import ensure_period_open, close_period from fenris.monitoring_periods import ensure_period_open
from fenris.projection import ( from fenris.projection import (
ConfidenceState, ConfidenceState,
compute_projection, compute_projection,
DISCLOSURES,
WARMING_MIN_DAYS,
STALENESS_HOURS,
YOUNG_REGIME_DAYS,
) )
from fenris.status import ( from fenris.status import (
FRESH_THRESHOLD_S, FRESH_THRESHOLD_S,
STALENESS_THRESHOLD_S,
grade_freshness, grade_freshness,
) )
from fenris.activity_readout import (
_query_daily_graph_data,
_query_drive_health,
_query_hourly_graph_data,
)
from fenris.tui import ( from fenris.tui import (
FenrisTuiApp, FenrisTuiApp,
HistoryGraph, HistoryGraph,
_format_remaining, _format_remaining,
_query_drive_health,
_query_daily_graph_data,
_query_hourly_graph_data,
_RANGE_OPTIONS,
_RANGE_DEFAULT, _RANGE_DEFAULT,
_MIN_WIDTH, _MIN_WIDTH,
_MIN_HEIGHT, _MIN_HEIGHT,
@@ -60,6 +54,13 @@ def _clock(year=2026, month=9, day=30, hour=12):
return datetime(year, month, day, hour, 0, 0, tzinfo=timezone.utc) return datetime(year, month, day, hour, 0, 0, tzinfo=timezone.utc)
class _FrozenTuiDateTime(datetime):
@classmethod
def now(cls, tz=None):
instant = datetime(2026, 9, 28, 12, 0, 0, tzinfo=timezone.utc)
return instant.replace(tzinfo=None) if tz is None else instant.astimezone(tz)
def _insert_baseline(conn, tbw_tb=1.0, verified=True, def _insert_baseline(conn, tbw_tb=1.0, verified=True,
model="Samsung SSD 970 EVO Plus 1TB"): model="Samsung SSD 970 EVO Plus 1TB"):
conn.execute( conn.execute(
@@ -100,8 +101,8 @@ def _insert_day(conn, day, bw=1024*1024*100, coverage=0.95, samples=24):
def _insert_sample(conn, ts, pu=5, device="/dev/nvme0n1"): def _insert_sample(conn, ts, pu=5, device="/dev/nvme0n1"):
conn.execute( conn.execute(
"INSERT INTO samples (ts, device, data_units_written, data_units_read, " "INSERT INTO samples (ts, device, data_units_written, data_units_read, "
"percentage_used, bytes_written, bytes_read, power_on_hours) " "percentage_used, bytes_written, bytes_read, power_on_hours, segment_id) "
"VALUES (?, ?, ?, ?, ?, ?, ?, ?)", "VALUES (?, ?, ?, ?, ?, ?, ?, ?, 1)",
(ts, device, 1000000, 500000, pu, 512000000000, 256000000000, 8765), (ts, device, 1000000, 500000, pu, 512000000000, 256000000000, 8765),
) )
conn.commit() conn.commit()
@@ -276,7 +277,7 @@ class TestDenseScreen:
conn.close() conn.close()
app = FenrisTuiApp(store_path=tmp_path / "test.db") app = FenrisTuiApp(store_path=tmp_path / "test.db")
async with app.run_test() as pilot: async with app.run_test():
assert app.query_one("#headline-band") is not None assert app.query_one("#headline-band") is not None
assert app.query_one("#usage-history") is not None assert app.query_one("#usage-history") is not None
assert app.query_one("#drive-health") is not None assert app.query_one("#drive-health") is not None
@@ -296,7 +297,7 @@ class TestDenseScreen:
conn.close() conn.close()
app = FenrisTuiApp(store_path=tmp_path / "test.db") app = FenrisTuiApp(store_path=tmp_path / "test.db")
async with app.run_test() as pilot: async with app.run_test():
headline = str(app.query_one("#headline-band").render()) headline = str(app.query_one("#headline-band").render())
assert "remaining" in headline.lower() or "projection" in headline.lower() assert "remaining" in headline.lower() or "projection" in headline.lower()
@@ -314,7 +315,7 @@ class TestDenseScreen:
conn.close() conn.close()
app = FenrisTuiApp(store_path=tmp_path / "test.db") app = FenrisTuiApp(store_path=tmp_path / "test.db")
async with app.run_test() as pilot: async with app.run_test():
headline = str(app.query_one("#headline-band").render()) headline = str(app.query_one("#headline-band").render())
assert "projection confidence" in headline.lower() assert "projection confidence" in headline.lower()
# Contributing facts shown, never a percentage as confidence # Contributing facts shown, never a percentage as confidence
@@ -336,7 +337,7 @@ class TestDenseScreen:
conn.close() conn.close()
app = FenrisTuiApp(store_path=tmp_path / "test.db") app = FenrisTuiApp(store_path=tmp_path / "test.db")
async with app.run_test() as pilot: async with app.run_test():
strip = str(app.query_one("#service-strip").render()) strip = str(app.query_one("#service-strip").render())
assert "Boot:" in strip assert "Boot:" in strip
assert "Timer:" in strip assert "Timer:" in strip
@@ -477,7 +478,6 @@ class TestDenseScreen:
auth_notice = "Open with fenris (no sudo). Actions authenticate via polkit. ? Help" auth_notice = "Open with fenris (no sudo). Actions authenticate via polkit. ? Help"
async with app.run_test() as pilot: async with app.run_test() as pilot:
headline = str(app.query_one("#headline-band").render())
# Identity now shows Fenris by Bongbetic (issue #79) # Identity now shows Fenris by Bongbetic (issue #79)
assert "Fenris by Bongbetic" in str(app.query_one("#identity").render()) assert "Fenris by Bongbetic" in str(app.query_one("#identity").render())
assert auth_notice in str(app.query_one("#auth-notice").render()) assert auth_notice in str(app.query_one("#auth-notice").render())
@@ -519,7 +519,7 @@ class TestDisclosuresAndGreeting:
async def test_empty_store_greeting(self, tmp_path): async def test_empty_store_greeting(self, tmp_path):
"""Empty store shows 'no observations yet' with enable hint.""" """Empty store shows 'no observations yet' with enable hint."""
app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db") app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db")
async with app.run_test() as pilot: async with app.run_test():
headline = str(app.query_one("#headline-band").render()) headline = str(app.query_one("#headline-band").render())
assert "no observations yet" in headline.lower() assert "no observations yet" in headline.lower()
assert "enable" in headline.lower() or "resume" in headline.lower() assert "enable" in headline.lower() or "resume" in headline.lower()
@@ -584,9 +584,8 @@ class TestFirstRun:
async def test_first_run_prompt(self, tmp_path): async def test_first_run_prompt(self, tmp_path):
"""First-run prompt makes the keyboard action and boot effect explicit.""" """First-run prompt makes the keyboard action and boot effect explicit."""
app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db") app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db")
async with app.run_test() as pilot: async with app.run_test():
headline = str(app.query_one("#headline-band").render()) headline = str(app.query_one("#headline-band").render())
strip = str(app.query_one("#service-strip").render())
assert "no observations yet" in headline.lower() assert "no observations yet" in headline.lower()
assert "r resume — enable monitoring and future boots" in headline.lower() assert "r resume — enable monitoring and future boots" in headline.lower()
assert "r resume" in str(app.query_one("#action-rail").render()).lower() assert "r resume" in str(app.query_one("#action-rail").render()).lower()
@@ -859,7 +858,6 @@ class TestQueryHourlyGraphData:
class TestHistoryGraph: class TestHistoryGraph:
def test_empty_data(self, tmp_path): def test_empty_data(self, tmp_path):
"""Empty data shows awaiting message.""" """Empty data shows awaiting message."""
app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db")
# We test the widget directly via the app's compose # We test the widget directly via the app's compose
graph = HistoryGraph() graph = HistoryGraph()
# Simulate setting empty data # Simulate setting empty data
@@ -1022,7 +1020,7 @@ class TestBarGraphTUI:
assert len(graph._day_data) == 90 assert len(graph._day_data) == 90
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_readout_updates_on_selection(self, tmp_path): async def test_readout_updates_on_selection(self, tmp_path, monkeypatch):
"""Readout shows selected day info.""" """Readout shows selected day info."""
conn = init_store(tmp_path / "test.db") conn = init_store(tmp_path / "test.db")
_insert_segment(conn) _insert_segment(conn)
@@ -1034,6 +1032,7 @@ class TestBarGraphTUI:
_insert_sample(conn, "2026-09-30T10:00:00+00:00") _insert_sample(conn, "2026-09-30T10:00:00+00:00")
conn.close() conn.close()
monkeypatch.setattr("fenris.tui.datetime", _FrozenTuiDateTime)
app = FenrisTuiApp(store_path=tmp_path / "test.db") app = FenrisTuiApp(store_path=tmp_path / "test.db")
async with app.run_test(size=(80, 24)) as pilot: async with app.run_test(size=(80, 24)) as pilot:
await pilot.press("v", "v") await pilot.press("v", "v")
@@ -1056,7 +1055,7 @@ class TestBarGraphTUI:
assert "W 0.105 GB known" in readout assert "W 0.105 GB known" in readout
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_hourly_drill_down_and_back(self, tmp_path): async def test_hourly_drill_down_and_back(self, tmp_path, monkeypatch):
"""Enter drills into hourly view, Esc returns to daily.""" """Enter drills into hourly view, Esc returns to daily."""
conn = init_store(tmp_path / "test.db") conn = init_store(tmp_path / "test.db")
_insert_segment(conn) _insert_segment(conn)
@@ -1073,6 +1072,7 @@ class TestBarGraphTUI:
_insert_sample(conn, "2026-09-30T10:00:00+00:00") _insert_sample(conn, "2026-09-30T10:00:00+00:00")
conn.close() conn.close()
monkeypatch.setattr("fenris.tui.datetime", _FrozenTuiDateTime)
app = FenrisTuiApp(store_path=tmp_path / "test.db") app = FenrisTuiApp(store_path=tmp_path / "test.db")
async with app.run_test(size=(80, 24)) as pilot: async with app.run_test(size=(80, 24)) as pilot:
await pilot.press("v", "v") await pilot.press("v", "v")
@@ -1120,7 +1120,6 @@ class TestBarGraphTUI:
app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db") app = FenrisTuiApp(store_path=tmp_path / "nonexistent.db")
async with app.run_test(size=(80, 24)) as pilot: async with app.run_test(size=(80, 24)) as pilot:
await pilot.press("v", "v") await pilot.press("v", "v")
graph = app.query_one("#usage-history")
assert app.query_one("#activity-panel").border_title == "Drive activity" assert app.query_one("#activity-panel").border_title == "Drive activity"
@pytest.mark.asyncio @pytest.mark.asyncio
@@ -1346,15 +1345,9 @@ class TestConstrainedLayout:
headline = str(app.query_one("#headline-band").render()) headline = str(app.query_one("#headline-band").render())
assert "remaining" in headline.lower() or "projection" in headline.lower() assert "remaining" in headline.lower() or "projection" in headline.lower()
# Service strip should have actions # Under 80x24 the footer collapses to help and quit (issue #110)
strip = str(app.query_one("#action-rail").render())
assert "p Pause" in strip
assert "r Resume" in strip
assert "q Quit TUI" in strip
# Quit rail should be visible
rail = str(app.query_one("#action-rail").render()) rail = str(app.query_one("#action-rail").render())
assert "Quit" in rail assert rail == "? help · q quit"
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_constrained_long_reasons_visible(self, tmp_path): async def test_constrained_long_reasons_visible(self, tmp_path):
+214
View File
@@ -0,0 +1,214 @@
"""Enter rated TBW from the TUI (issue #107, ADR 0012 §7).
Seam: the app's helper invocation (`_run_helper`), faked here the way the
other TUI tests fake it. The form builds an unverified override and hands it
to `fenris-monitor baseline set`; it never offers verified provenance.
"""
import json
import sys
from datetime import datetime, timedelta, timezone
from pathlib import Path
from types import SimpleNamespace
from unittest.mock import patch
import pytest
sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
sys.path.insert(0, str(Path(__file__).parent))
from fenris.monitor import cmd_baseline_set
from fenris.store import init_store
from fenris.tui import FenrisTuiApp
from test_staged_projection import seed_evidence
SERVICES = {
"boot_enabled": False, "timer_active": False,
"last_collect_ok": None, "last_collect_age_s": None,
"last_collect_reason": None,
}
@pytest.fixture
def db(tmp_path):
return tmp_path / "observations.db"
def _app(db):
return FenrisTuiApp(store_path=db)
def _seed_without_baseline(db):
now = datetime.now(timezone.utc).replace(minute=0, second=0, microsecond=0)
conn = init_store(db)
seed_evidence(conn, 3, baseline=None, start=now - timedelta(hours=3))
conn.close()
def _text(app, selector):
return str(app.query_one(selector).render())
async def _open_form(pilot):
await pilot.press("b")
await pilot.pause()
async def _fill(pilot, app, tbw, url=""):
app.screen.query_one("#tbw-input").value = tbw
app.screen.query_one("#source-input").value = url
await pilot.press("enter")
await pilot.pause()
class TestForm:
@pytest.mark.asyncio
async def test_b_opens_form_with_required_tbw_and_optional_source(self, db):
_seed_without_baseline(db)
with patch("fenris.status.query_service_state", return_value=SERVICES):
app = _app(db)
async with app.run_test(size=(120, 50)) as pilot:
await _open_form(pilot)
assert len(app.screen_stack) == 2
assert app.screen.query_one("#tbw-input")
assert app.screen.query_one("#source-input")
text = str(app.screen.query_one("#baseline-header").render())
assert "unverified" in text.lower()
@pytest.mark.asyncio
@pytest.mark.parametrize("value", ["", "abc", "0", "-5", "nan", "inf"])
async def test_invalid_tbw_is_rejected_without_calling_helper(self, db, value):
_seed_without_baseline(db)
with patch("fenris.status.query_service_state", return_value=SERVICES):
app = _app(db)
with patch.object(app, "_run_helper") as run_helper:
async with app.run_test(size=(120, 50)) as pilot:
await _open_form(pilot)
await _fill(pilot, app, value)
assert len(app.screen_stack) == 2
assert str(app.screen.query_one("#baseline-error").render()).strip()
run_helper.assert_not_called()
@pytest.mark.asyncio
async def test_invalid_source_url_is_rejected(self, db):
_seed_without_baseline(db)
with patch("fenris.status.query_service_state", return_value=SERVICES):
app = _app(db)
with patch.object(app, "_run_helper") as run_helper:
async with app.run_test(size=(120, 50)) as pilot:
await _open_form(pilot)
await _fill(pilot, app, "600", "not a url")
assert len(app.screen_stack) == 2
assert "url" in str(app.screen.query_one("#baseline-error").render()).lower()
run_helper.assert_not_called()
@pytest.mark.asyncio
async def test_escape_cancels_without_calling_helper(self, db):
_seed_without_baseline(db)
with patch("fenris.status.query_service_state", return_value=SERVICES):
app = _app(db)
with patch.object(app, "_run_helper") as run_helper:
async with app.run_test(size=(120, 50)) as pilot:
await _open_form(pilot)
await pilot.press("escape")
await pilot.pause()
assert len(app.screen_stack) == 1
run_helper.assert_not_called()
class TestSubmit:
@pytest.mark.asyncio
async def test_submit_routes_unverified_override_to_baseline_set(self, db):
_seed_without_baseline(db)
with patch("fenris.status.query_service_state", return_value=SERVICES):
app = _app(db)
with patch.object(app, "_run_helper", return_value=True) as run_helper:
async with app.run_test(size=(120, 50)) as pilot:
await _open_form(pilot)
await _fill(pilot, app, "600", "https://example.com/spec")
assert len(app.screen_stack) == 1
run_helper.assert_called_once()
operation, args = run_helper.call_args.args
assert operation == "baseline"
assert args[0] == "set"
payload = json.loads(args[1])
assert payload["tbw_terabytes"] == 600
assert payload["source_url"] == "https://example.com/spec"
assert payload["verified"] is False
assert payload["validated_by"] == "user"
# Incomplete provenance keeps the override unverified.
assert payload["document_revision"] is None
@pytest.mark.asyncio
async def test_blank_source_is_stored_as_absent(self, db):
_seed_without_baseline(db)
with patch("fenris.status.query_service_state", return_value=SERVICES):
app = _app(db)
with patch.object(app, "_run_helper", return_value=True) as run_helper:
async with app.run_test(size=(120, 50)) as pilot:
await _open_form(pilot)
await _fill(pilot, app, "1.5")
payload = json.loads(run_helper.call_args.args[1][1])
assert payload["tbw_terabytes"] == 1.5
assert payload["source_url"] is None
@pytest.mark.asyncio
async def test_headline_changes_from_write_rate_to_lifespan(self, db):
_seed_without_baseline(db)
def fake_helper(operation, extra_args=None):
cmd_baseline_set(SimpleNamespace(store_path=db, baseline_json=extra_args[1]))
return True
with patch("fenris.status.query_service_state", return_value=SERVICES):
app = _app(db)
with patch.object(app, "_run_helper", side_effect=fake_helper):
async with app.run_test(size=(120, 50)) as pilot:
before = _text(app, "#headline-band")
assert "Write rate" in before
assert "remaining" not in before
await _open_form(pilot)
await _fill(pilot, app, "600")
app.on_refresh_tick()
await pilot.pause()
after = _text(app, "#headline-band")
assert "remaining" in after
assert "Write rate" not in after
class TestBanner:
@pytest.mark.asyncio
async def test_banner_shown_when_no_baseline_applies(self, db):
_seed_without_baseline(db)
with patch("fenris.status.query_service_state", return_value=SERVICES):
app = _app(db)
async with app.run_test(size=(120, 50)):
banner = app.query_one("#baseline-banner")
assert banner.display
assert "b" in str(banner.render()).lower()
assert "rated tbw" in str(banner.render()).lower()
@pytest.mark.asyncio
async def test_banner_shown_on_first_run(self, tmp_path):
with patch("fenris.status.query_service_state", return_value=SERVICES):
app = _app(tmp_path / "missing.db")
async with app.run_test(size=(120, 50)):
assert app.query_one("#baseline-banner").display
@pytest.mark.asyncio
async def test_banner_hidden_once_baseline_exists(self, db):
now = datetime.now(timezone.utc).replace(minute=0, second=0, microsecond=0)
conn = init_store(db)
seed_evidence(conn, 3, start=now - timedelta(hours=3))
conn.close()
with patch("fenris.status.query_service_state", return_value=SERVICES):
app = _app(db)
async with app.run_test(size=(120, 50)):
assert not app.query_one("#baseline-banner").display
@pytest.mark.asyncio
async def test_banner_hidden_for_unreadable_store(self, db):
db.write_bytes(b"not a sqlite database" * 100)
with patch("fenris.status.query_service_state", return_value=SERVICES):
app = _app(db)
async with app.run_test(size=(120, 50)):
assert not app.query_one("#baseline-banner").display
+152
View File
@@ -0,0 +1,152 @@
"""Diagnostics panel on the dashboard (issue #109): toggle, render, badge."""
import sqlite3
import pytest
from test_dashboard_design import dashboard, visible # noqa: F401 (fixtures)
from fenris.tui import FenrisTuiApp, HelpScreen
def _store(app):
return sqlite3.connect(app.store_path)
def _set_latest_warning(app, value):
conn = _store(app)
conn.execute(
"UPDATE samples SET critical_warning = ?, power_on_hours = id, "
"unsafe_shutdowns = id / 20 WHERE 1", (value,))
conn.commit()
conn.close()
async def _settle(app, pilot):
app.on_refresh_tick()
await pilot.pause()
def _text(app, selector):
return str(app.query_one(selector).render())
def test_i_is_a_declared_binding_and_d_stays_disclosures():
keys = {b.key: b.action for b in FenrisTuiApp.BINDINGS}
assert keys["i"] == "toggle_diagnostics"
assert keys["d"] == "disclose"
@pytest.mark.asyncio
@pytest.mark.parametrize("size", [(140, 44), (100, 30)])
async def test_i_toggles_the_diagnostics_panel_and_hides_the_drive_pane(dashboard, size): # noqa: F811
app = dashboard
_set_latest_warning(app, 0)
async with app.run_test(size=size) as pilot:
await _settle(app, pilot)
assert not app.query_one("#diagnostics-panel").display
assert app.query_one("#drive-panel").display
await pilot.press("i")
await _settle(app, pilot)
assert app.query_one("#diagnostics-panel").display
assert not app.query_one("#drive-panel").display
body = _text(app, "#diagnostics")
assert "Diagnostics" in body and "Critical warning none" in body
assert "Power-on hours 61 Δ +60" in body
await pilot.press("i")
await _settle(app, pilot)
assert not app.query_one("#diagnostics-panel").display
assert app.query_one("#drive-panel").display
@pytest.mark.asyncio
async def test_footer_and_help_list_the_diagnostics_key(dashboard): # noqa: F811
app = dashboard
async with app.run_test(size=(140, 40)) as pilot:
await _settle(app, pilot)
assert "i Diagnostics" in _text(app, "#action-rail")
await pilot.press("?")
assert isinstance(app.screen, HelpScreen)
assert "Diagnostics" in str(app.screen.query_one("#help-text").render())
@pytest.mark.asyncio
async def test_diagnostics_follow_the_activity_view(dashboard): # noqa: F811
app = dashboard
async with app.run_test(size=(140, 44)) as pilot:
await _settle(app, pilot)
await pilot.press("i")
await _settle(app, pilot)
assert "last 3h" in _text(app, "#diagnostics")
await pilot.press("v") # Day
await _settle(app, pilot)
body = _text(app, "#diagnostics")
assert "· day 20" in body and "Hours ·" in body
await pilot.press("v") # History
await _settle(app, pilot)
assert "last 14 days" in _text(app, "#diagnostics")
@pytest.mark.asyncio
async def test_critical_warning_badge_shows_in_the_outlook_without_the_panel(dashboard): # noqa: F811
app = dashboard
_set_latest_warning(app, 0x04)
async with app.run_test(size=(140, 44)) as pilot:
await _settle(app, pilot)
assert not app.query_one("#diagnostics-panel").display
band = _text(app, "#headline-band")
assert "0x04" in band and "reliability degraded" in band
@pytest.mark.asyncio
async def test_no_badge_when_the_drive_reports_no_warning(dashboard): # noqa: F811
app = dashboard
_set_latest_warning(app, 0)
async with app.run_test(size=(140, 44)) as pilot:
await _settle(app, pilot)
assert "critical warning" not in _text(app, "#headline-band").lower()
@pytest.mark.asyncio
async def test_diagnostics_work_in_constrained_mode(dashboard): # noqa: F811
app = dashboard
_set_latest_warning(app, 0x01)
async with app.run_test(size=(60, 20)) as pilot:
await _settle(app, pilot)
assert app._is_constrained_mode
await pilot.press("i")
await _settle(app, pilot)
assert app.query_one("#diagnostics-panel").display
body = _text(app, "#diagnostics")
assert "available spare below threshold" in body
assert "Power-on hours" in body
await pilot.press("i")
await _settle(app, pilot)
assert app.query_one("#drive-panel").display
@pytest.mark.asyncio
async def test_toggling_while_zoomed_restores_the_grid_and_keeps_focus(dashboard): # noqa: F811
app = dashboard
async with app.run_test(size=(140, 44)) as pilot:
await _settle(app, pilot)
await pilot.press("z")
await pilot.press("i")
await _settle(app, pilot)
assert app._zoomed_panel is None
assert app.focused is not None
@pytest.mark.asyncio
async def test_history_bars_draw_reads_alongside_writes_only_with_diagnostics(dashboard): # noqa: F811
app = dashboard
async with app.run_test(size=(140, 44)) as pilot:
await _settle(app, pilot)
await pilot.press("v", "v") # History
await _settle(app, pilot)
assert "Reads" not in _text(app, "#bar-legend")
await pilot.press("i")
await _settle(app, pilot)
legend = _text(app, "#bar-legend")
assert "Writes" in legend and "Reads" in legend
await pilot.press("i")
await _settle(app, pilot)
assert "Reads" not in _text(app, "#bar-legend")
+456
View File
@@ -0,0 +1,456 @@
"""Unified keyboard and mouse navigation (issue #110).
Every action has one declaration: a Binding. The footer, the help screen and
the clickable chips are all generated from those bindings, and the keyboard,
mouse and wheel paths reach the same actions. Pilot drives each path.
"""
import re
from datetime import date, timedelta
from unittest.mock import patch
import pytest
from test_dashboard_design import dashboard # noqa: F401 (pytest fixture)
from textual import events
from textual.geometry import Region
from fenris.tui import (
ConfirmPause,
DatePickerScreen,
BaselineScreen,
DisclosuresScreen,
FenrisTuiApp,
HelpScreen,
HistoryGraph,
LiveActivityGraph,
)
BINDING_SOURCES = (FenrisTuiApp, LiveActivityGraph, HistoryGraph)
# -- helpers ---------------------------------------------------------------
async def _settle(app, pilot):
app.on_refresh_tick()
await pilot.pause()
def _chip(app, label):
"""Offset of a footer or tool chip label inside its Static."""
for selector in ("#action-rail", "#activity-tools"):
widget = app.query_one(selector)
region = Region(0, 0, widget.size.width, widget.size.height)
for y, strip in enumerate(widget.render_lines(region)):
x = strip.text.find(label)
if x >= 0:
return selector, (x + 1, y)
raise AssertionError("no chip %r in footer" % label)
async def _click_chip(app, pilot, label):
selector, offset = _chip(app, label)
await pilot.click(selector, offset=offset)
await pilot.pause()
def _scroll(widget, direction):
event = (events.MouseScrollUp if direction < 0 else events.MouseScrollDown)(
widget, 3, 1, 0, direction, 0, False, False, False,
)
widget.post_message(event)
def _help_rows(app):
text = str(app.screen.query_one("#help-text").render())
section = text.split("Keyboard controls\n", 1)[1].split("\n\n", 1)[0]
rows = {}
for line in section.splitlines():
keys, description = re.match(r"^(\S.*?)\s{2,}(\S.*)$", line).groups()
rows[description] = set(keys.split(" / "))
return rows
def _binding_rows(app):
rows = {}
for source in BINDING_SOURCES:
for binding in source.BINDINGS:
rows.setdefault(binding.description, set()).add(app.get_key_display(binding))
return rows
# -- one source of truth ---------------------------------------------------
def test_graphs_declare_bindings_instead_of_key_handlers():
for graph in (HistoryGraph, LiveActivityGraph):
assert "on_key" not in vars(graph)
assert graph.BINDINGS
@pytest.mark.asyncio
async def test_help_content_equals_binding_set(dashboard): # noqa: F811
async with dashboard.run_test(size=(100, 36)) as pilot:
await pilot.press("?")
assert isinstance(dashboard.screen, HelpScreen)
assert _help_rows(dashboard) == _binding_rows(dashboard)
assert "The dashboard does not need sudo" in str(
dashboard.screen.query_one("#help-text").render())
@pytest.mark.asyncio
async def test_footer_chips_are_generated_from_visible_bindings(dashboard): # noqa: F811
async with dashboard.run_test(size=(120, 36)) as pilot:
await pilot.pause()
footer = str(dashboard.query_one("#action-rail").render())
shown = [b for b in FenrisTuiApp.BINDINGS if b.show]
assert shown
for binding in shown:
assert "%s %s" % (dashboard.get_key_display(binding), binding.description) in footer
for binding in FenrisTuiApp.BINDINGS:
if not binding.show:
label = "%s %s" % (dashboard.get_key_display(binding), binding.description)
assert label not in footer
@pytest.mark.asyncio
@pytest.mark.parametrize("size", [(79, 24), (80, 23), (60, 18)])
async def test_footer_collapses_under_80x24(dashboard, size): # noqa: F811
async with dashboard.run_test(size=size) as pilot:
await pilot.pause()
assert str(dashboard.query_one("#action-rail").render()) == "? help · q quit"
await _click_chip(dashboard, pilot, "? help")
assert isinstance(dashboard.screen, HelpScreen)
await pilot.press("escape")
await _click_chip(dashboard, pilot, "q quit")
assert not dashboard.is_running
@pytest.mark.asyncio
async def test_footer_is_full_at_80x24(dashboard): # noqa: F811
async with dashboard.run_test(size=(80, 24)) as pilot:
await pilot.pause()
footer = str(dashboard.query_one("#action-rail").render())
assert "p Pause" in footer and "q Quit TUI" in footer
# -- keyboard: live graph --------------------------------------------------
@pytest.mark.asyncio
async def test_live_home_end_and_arrows(dashboard): # noqa: F811
app = dashboard
async with app.run_test(size=(100, 36)) as pilot:
await _settle(app, pilot)
graph = app.query_one("#live-activity")
last = len(graph._data) - 1
assert last > 3
await pilot.press("home")
assert graph._selected_index == 0
await pilot.press("right")
assert graph._selected_index == 1
await pilot.press("end")
assert graph._selected_index == last
await pilot.press("left")
assert graph._selected_index == last - 1
# -- keyboard: history graph -----------------------------------------------
async def _open_history(app, pilot):
await pilot.click("#view-history")
await _settle(app, pilot)
graph = app.query_one("#usage-history")
assert app.focused is graph
return graph
@pytest.mark.asyncio
async def test_history_home_end_and_week_jumps(dashboard): # noqa: F811
app = dashboard
async with app.run_test(size=(100, 36)) as pilot:
graph = await _open_history(app, pilot)
last = len(graph._day_data) - 1
assert last >= 13
await pilot.press("home")
assert graph.selected_index == 0
await pilot.press("end")
assert graph.selected_index == last
assert app._browse_date == graph._day_data[last]["day"]
await pilot.press("pageup")
assert graph.selected_index == last - 7
assert app._browse_date == graph._day_data[last - 7]["day"]
await pilot.press("pagedown")
assert graph.selected_index == last
await pilot.press("pagedown")
assert graph.selected_index == last
await pilot.press("home", "pageup")
assert graph.selected_index == 0
@pytest.mark.asyncio
async def test_history_range_keys_and_drill_bindings(dashboard): # noqa: F811
app = dashboard
async with app.run_test(size=(100, 36)) as pilot:
graph = await _open_history(app, pilot)
await pilot.press("1")
assert graph.range_days == 7
await pilot.press("3")
assert graph.range_days == 30
await pilot.press("left", "enter")
assert app._activity_view == "day" and graph.view_mode == "hourly"
await pilot.press("1")
assert graph.range_days == 30 # range keys only apply to the day graph
await pilot.press("escape")
assert graph.view_mode == "daily" and app._activity_view == "history"
await pilot.press("enter")
await pilot.press("backspace")
assert graph.view_mode == "daily"
@pytest.mark.asyncio
async def test_hour_graph_home_end_arrows_and_week_jump(dashboard): # noqa: F811
app = dashboard
async with app.run_test(size=(100, 36)) as pilot:
graph = await _open_history(app, pilot)
await pilot.press("enter")
day = app._browse_date
await pilot.press("home")
assert graph._hourly_selected == 0
await pilot.press("right")
assert graph._hourly_selected == 1
await pilot.press("end")
assert graph._hourly_selected == len(graph._hour_data) - 1
await pilot.press("left")
assert graph._hourly_selected == len(graph._hour_data) - 2
await pilot.press("pageup")
assert app._activity_view == "day"
assert app._browse_date == (date.fromisoformat(day) - timedelta(days=7)).isoformat()
@pytest.mark.asyncio
async def test_escape_in_zoomed_hour_view_restores_zoom_first(dashboard): # noqa: F811
app = dashboard
async with app.run_test(size=(100, 36)) as pilot:
graph = await _open_history(app, pilot)
await pilot.press("enter", "z")
assert app._zoomed_panel == "activity-panel"
await pilot.press("escape")
assert app._zoomed_panel is None and graph.view_mode == "hourly"
await pilot.press("escape")
assert graph.view_mode == "daily"
# -- keyboard: focus ring --------------------------------------------------
@pytest.mark.asyncio
async def test_tab_cycles_panels_with_visible_focus_ring(dashboard): # noqa: F811
app = dashboard
async with app.run_test(size=(120, 40)) as pilot:
await pilot.pause()
order = [app.focused.id]
for _ in range(3):
await pilot.press("tab")
order.append(app.focused.id)
assert order == ["live-activity", "drive-panel", "endurance-panel", "live-activity"]
await pilot.press("shift+tab")
assert app.focused.id == "endurance-panel"
await pilot.press("shift+tab")
assert app.focused.id == "drive-panel"
def ring(pane_id):
return app.query_one("#" + pane_id).styles.border_top[1]
assert ring("drive-panel") != ring("endurance-panel")
await pilot.press("tab")
assert app.focused.id == "endurance-panel"
assert ring("endurance-panel") != ring("drive-panel")
await pilot.press("tab")
assert ring("activity-panel") != ring("drive-panel")
# -- mouse -----------------------------------------------------------------
@pytest.mark.asyncio
async def test_click_focuses_each_panel(dashboard): # noqa: F811
app = dashboard
async with app.run_test(size=(120, 40)) as pilot:
await pilot.pause()
await pilot.click("#drive-health")
assert app.focused.id == "drive-panel"
await pilot.click("#headline-band")
assert app.focused.id == "endurance-panel"
await pilot.click("#local-day")
assert app.focused.id == "live-activity"
await pilot.click("#view-history")
await pilot.click("#drive-health")
await pilot.click("#local-day")
assert app.focused.id == "usage-history"
@pytest.mark.asyncio
async def test_view_tabs_are_clickable(dashboard): # noqa: F811
app = dashboard
async with app.run_test(size=(100, 36)) as pilot:
for view in ("history", "day", "live"):
await pilot.click("#view-" + view)
assert app._activity_view == view
assert app.query_one("#activity-tabs").active == "view-" + view
@pytest.mark.asyncio
async def test_action_chips_fire_their_bindings(dashboard): # noqa: F811
app = dashboard
calls = []
async with app.run_test(size=(120, 40)) as pilot:
await pilot.pause()
with patch.object(app, "_run_helper", side_effect=lambda *a: calls.append(a) or True):
await _click_chip(app, pilot, "p Pause")
assert isinstance(app.screen, ConfirmPause)
await pilot.press("n")
await _click_chip(app, pilot, "r Resume")
assert calls == [("enable", ["--now"])]
await _click_chip(app, pilot, "c Collect")
assert calls[-1] == ("collect",)
await _click_chip(app, pilot, "b Rated TBW")
assert isinstance(app.screen, BaselineScreen)
await pilot.press("escape")
await _click_chip(app, pilot, "s Theme")
assert app.theme == "fenris-amber"
await _click_chip(app, pilot, "d Disclosures")
assert isinstance(app.screen, DisclosuresScreen)
await pilot.press("escape")
await _click_chip(app, pilot, "z Zoom")
assert app._zoomed_panel is not None
await _click_chip(app, pilot, "z Zoom")
assert app._zoomed_panel is None
await _click_chip(app, pilot, "v View")
assert app._activity_view == "day"
await _click_chip(app, pilot, "m Motion")
assert app._reduced_motion is True
@pytest.mark.asyncio
async def test_activity_tool_chips_are_generated_from_bindings(dashboard): # noqa: F811
app = dashboard
async with app.run_test(size=(120, 40)) as pilot:
await pilot.pause()
tools = str(app.query_one("#activity-tools").render())
for action in ("prev_day", "next_day", "go_to_date", "today", "toggle_measure"):
binding = next(b for b in FenrisTuiApp.BINDINGS if b.action == action)
assert "%s %s" % (app.get_key_display(binding), binding.description) in tools
await _click_chip(app, pilot, "w Toggle read/write")
assert app.query_one("#live-activity").measure == "read"
await _click_chip(app, pilot, "g Go to date")
assert isinstance(app.screen, DatePickerScreen)
await pilot.press("escape")
await _click_chip(app, pilot, "Prev day")
assert app._activity_view == "day"
await _click_chip(app, pilot, "t Today")
assert app._activity_view == "live"
@pytest.mark.asyncio
async def test_wheel_moves_live_selection(dashboard): # noqa: F811
app = dashboard
async with app.run_test(size=(100, 36)) as pilot:
await _settle(app, pilot)
graph = app.query_one("#live-activity")
last = len(graph._data) - 1
_scroll(graph, -1)
await pilot.pause()
assert graph._selected_index == last - 1
_scroll(graph, -1)
await pilot.pause()
assert graph._selected_index == last - 2
_scroll(graph, 1)
await pilot.pause()
assert graph._selected_index == last - 1
@pytest.mark.asyncio
async def test_wheel_moves_history_day_and_hour_selection(dashboard): # noqa: F811
app = dashboard
async with app.run_test(size=(100, 36)) as pilot:
graph = await _open_history(app, pilot)
last = len(graph._day_data) - 1
_scroll(graph, -1)
await pilot.pause()
assert graph.selected_index == last - 1
_scroll(graph, 1)
await pilot.pause()
assert graph.selected_index == last
await pilot.press("enter", "end")
end = graph._hourly_selected
_scroll(graph, -1)
await pilot.pause()
assert graph._hourly_selected == end - 1
@pytest.mark.asyncio
async def test_click_to_inspect_stays(dashboard): # noqa: F811
app = dashboard
async with app.run_test(size=(100, 36)) as pilot:
await pilot.pause()
graph = app.query_one("#live-activity")
await pilot.click("#live-render", offset=(graph._point_columns[0], 1))
assert graph._selected_index == 0
# -- modal keys ------------------------------------------------------------
@pytest.mark.asyncio
async def test_confirm_pause_y_n_and_escape(dashboard): # noqa: F811
app = dashboard
async with app.run_test(size=(100, 36)) as pilot:
with patch.object(app, "_run_helper") as helper:
await pilot.press("p", "n")
assert not isinstance(app.screen, ConfirmPause)
await pilot.press("p", "escape")
assert not isinstance(app.screen, ConfirmPause)
helper.assert_not_called()
await pilot.press("p", "y")
assert not isinstance(app.screen, ConfirmPause)
helper.assert_called_once_with("disable", ["--now"])
@pytest.mark.asyncio
async def test_date_picker_keys(dashboard): # noqa: F811
app = dashboard
async with app.run_test(size=(100, 36)) as pilot:
await _settle(app, pilot)
await pilot.press("g", "escape")
assert not isinstance(app.screen, DatePickerScreen)
await pilot.press("g", "enter")
assert isinstance(app.screen, DatePickerScreen)
assert "Please enter a date" in str(app.screen.query_one("#date-error").render())
await pilot.press(*"2026-13-45", "enter")
assert "Invalid date format" in str(app.screen.query_one("#date-error").render())
app.screen.query_one("#date-input").value = ""
await pilot.press(*"2999-01-01", "enter")
assert "future" in str(app.screen.query_one("#date-error").render())
app.screen.query_one("#date-input").value = ""
await pilot.press(*"2026-09-17", "enter")
assert not isinstance(app.screen, DatePickerScreen)
assert app._browse_date == "2026-09-17"
assert app._activity_view == "day"
@pytest.mark.asyncio
async def test_disclosures_and_help_toggle_keys(dashboard): # noqa: F811
app = dashboard
async with app.run_test(size=(100, 36)) as pilot:
await pilot.press("d")
assert isinstance(app.screen, DisclosuresScreen)
await pilot.press("d")
assert not isinstance(app.screen, DisclosuresScreen)
await pilot.press("d", "escape")
assert not isinstance(app.screen, DisclosuresScreen)
await pilot.press("?")
assert isinstance(app.screen, HelpScreen)
await pilot.press("?")
assert not isinstance(app.screen, HelpScreen)
await pilot.press("?", "escape")
assert not isinstance(app.screen, HelpScreen)
@pytest.mark.asyncio
async def test_single_dashboard_has_no_page_navigation_bindings(dashboard): # noqa: F811
keys = {b.key for b in FenrisTuiApp.BINDINGS}
assert not keys & {"left", "right", "1", "2", "3", "4", "home", "end", "pageup", "pagedown"}